fix: add 3 missing ARIA 1.3 roles + report specific offending token (Copilot review)

The PR body claimed the ARIA 1.3 draft allowlist covers 5 roles (associationlist,
associationlistitemkey, associationlistitemvalue, comment, suggestion). The
code only listed 2 ('comment', 'suggestion'); the gap was invisible because
no tests exercised any of them. Verified against aria-query 5.3.2:
roles.has() returns false for all 5, so all 5 belong in the inline allowlist
until aria-query catches up.

Also: when reporting presentation/none on a semantic element, include the
offending token in the message data instead of the raw role attribute
string — avoids surfacing e.g. 'presentation listbox' when only
'presentation' is the issue.

Tests: add 5 valid cases in each of the gts and hbs blocks covering all
ARIA 1.3 draft roles.

Author: johanrd

lib/rules/template-no-invalid-role.js

@@ -1,11 +1,19 @@
 const { roles } = require('aria-query');
 
-// Valid ARIA roles = concrete (non-abstract) entries from aria-query, plus a
-// couple of WAI-ARIA 1.3 draft roles that aria-query doesn't yet ship. The
+// Valid ARIA roles = concrete (non-abstract) entries from aria-query, plus the
+// WAI-ARIA 1.3 draft roles that aria-query 5.3.2 doesn't yet ship. The
 // ARIA 1.2 base roles, DPUB-ARIA (doc-*), and Graphics-ARIA (graphics-*) all
-// come from aria-query. Both `comment` and `suggestion` are present in the
-// current ARIA 1.3 editor's draft (https://w3c.github.io/aria/).
-const ARIA_13_DRAFT_ROLES = ['comment', 'suggestion'];
+// come from aria-query. `associationlist*`, `comment`, and `suggestion` are in
+// the current ARIA 1.3 editor's draft (https://w3c.github.io/aria/) but not
+// yet in aria-query, so they're listed here until the next aria-query release
+// adds them.
+const ARIA_13_DRAFT_ROLES = [
+  'associationlist',
+  'associationlistitemkey',
+  'associationlistitemvalue',
+  'comment',
+  'suggestion',
+];
 const VALID_ROLES = new Set([
   ...[...roles.keys()].filter((role) => !roles.get(role).abstract),
   ...ARIA_13_DRAFT_ROLES,
@@ -171,14 +179,15 @@ module.exports = {
         // Check for presentation/none role on semantic elements (case-insensitive per WAI-ARIA 1.2:
         // "Case-sensitivity of the comparison inherits from the case-sensitivity of the host language"
         // and HTML is case-insensitive — https://www.w3.org/TR/wai-aria-1.2/#document-handling_author-errors_roles)
-        if (
-          tokens.some((t) => t === 'presentation' || t === 'none') &&
-          SEMANTIC_ELEMENTS.has(node.tag)
-        ) {
+        const offendingToken = tokens.find((t) => t === 'presentation' || t === 'none');
+        if (offendingToken && SEMANTIC_ELEMENTS.has(node.tag)) {
           context.report({
             node: roleAttr,
             messageId: 'presentationOnSemantic',
-            data: { role: raw, tag: node.tag },
+            // Report the specific offending token, not the whole raw role
+            // string — e.g. for role="presentation foo" we point at
+            // 'presentation' rather than the full attribute value.
+            data: { role: offendingToken, tag: node.tag },
           });
         }
       },

tests/lib/rules/template-no-invalid-role.js

@@ -80,6 +80,14 @@ ruleTester.run('template-no-invalid-role', rule, {
     '<template><div role="tabpanel row"></div></template>',
     '<template><svg role="graphics-document document"></svg></template>',
     '<template><section role="doc-appendix doc-bibliography"></section></template>',
+
+    // ARIA 1.3 draft roles — not in aria-query 5.3.2 but spec-blessed, so
+    // the rule accepts them via the inline allowlist.
+    '<template><div role="associationlist"></div></template>',
+    '<template><div role="associationlistitemkey"></div></template>',
+    '<template><div role="associationlistitemvalue"></div></template>',
+    '<template><div role="comment"></div></template>',
+    '<template><div role="suggestion"></div></template>',
   ],
 
   invalid: [
@@ -263,6 +271,14 @@ hbsRuleTester.run('template-no-invalid-role', rule, {
     '<div role="tabpanel row"></div>',
     '<svg role="graphics-document document"></svg>',
     '<section role="doc-appendix doc-bibliography"></section>',
+
+    // ARIA 1.3 draft roles — not in aria-query 5.3.2 but spec-blessed, so
+    // the rule accepts them via the inline allowlist.
+    '<div role="associationlist"></div>',
+    '<div role="associationlistitemkey"></div>',
+    '<div role="associationlistitemvalue"></div>',
+    '<div role="comment"></div>',
+    '<div role="suggestion"></div>',
   ],
   invalid: [
     {