fix(template-require-mandatory-role-attributes): use classifyAttribute (rows i2, h6, h9, h10)

Two bugs fixed; both stem from AST-based classification ignoring runtime
rendering.

Bug 1 — bare-mustache string-literal role ignored (i2 analog).

Before: getStaticRolesFromElement only recognized role attributes whose
value was a `GlimmerTextNode`. The form `role={{"option"}}` (which renders
`role="option"` per the doc's i2-analog row — bare-mustache string literals
never coerce) was treated as dynamic and silently skipped, so the rule
never validated required ARIA attributes for it.

After: getStaticRolesFromElement uses classifyAttribute. Static text,
bare-string-literal mustache, and concat with all-literal parts (i1, i2,
i3 analogs) all resolve to the same string and feed into role-token
splitting.

Bug 2 — bare-mustache falsy aria attribute counted as satisfying required-aria (h6, h9, h10).

Before: required-ARIA satisfaction was checked by AST attribute name
presence — `<div role="option" aria-selected={{false}} />` was treated as
having aria-selected even though Glimmer OMITS the attribute at runtime
per doc rows h6 (`{{false}}`), h9 (`{{null}}`), h10 (`{{undefined}}`).
This was *also* encoded as a passing valid fixture, locking the bug in.

After: the aria-attribute filter excludes attributes whose
`classifyAttribute(attr).presence === 'absent'`. The previously-passing
fixture moved from valid to invalid; replaced with positive cases that
use static aria values (`aria-selected="true"` / `"false"`) and the
new i2 role classification.

Test coverage:
- Valid (new): `<div role={{"option"}} aria-selected="true" />`
- Invalid (new): `<div role="option" aria-selected={{false}} />` (h6)
- Invalid (new): `<div role="option" aria-selected={{null}} />` (h9)
- Invalid (new): `<div role={{"option"}} />` (i2 + missing aria)
- All variants in both GJS and HBS suites.
- Replaced the bug-encoding fixture (valid `<div role="option" aria-selected={{false}} />`) with `aria-selected="true"`/`"false"` static-value cases preserving the original "aria-selected satisfies role=option" intent.

106 tests pass. Doc rows cited: i1, i2, i3 (role classification); h6, h9, h10 (aria-* falsy-coercion).

Author: johanrd

lib/rules/template-require-mandatory-role-attributes.js

@@ -1,14 +1,25 @@
+'use strict';
+
 const { roles } = require('aria-query');
 const { AXObjectRoles, elementAXObjects } = require('axobject-query');
+const { classifyAttribute } = require('../utils/glimmer-attr-presence');
 
 // ARIA role values are whitespace-separated tokens compared ASCII-case-insensitively.
 // Returns the list of normalised tokens, or undefined when the attribute is
 // missing or dynamic.
+//
+// `role` is a plain string attribute (no boolean coercion — see
+// docs/glimmer-attribute-behavior.md cross-attribute observations).
+// Recognise every source form that renders a statically-known role string:
+//   - GlimmerTextNode (i1): `role="button"`
+//   - bare-mustache string literal (i2 analog): `role={{"button"}}`
+//   - concat with all-literal parts (i3 analog): `role="{{'button'}}"`
+// classifyAttribute resolves all three to the same string value.
 function getStaticRolesFromElement(node) {
   const roleAttr = node.attributes?.find((attr) => attr.name === 'role');
-
-  if (roleAttr?.value?.type === 'GlimmerTextNode') {
-    return splitRoleTokens(roleAttr.value.chars);
+  const { presence, value } = classifyAttribute(roleAttr);
+  if (presence === 'present' && value !== null) {
+    return splitRoleTokens(value);
   }
 
   return undefined;
@@ -231,8 +242,19 @@ module.exports = {
           return;
         }
 
+        // Per docs/glimmer-attribute-behavior.md cross-attribute observations,
+        // bare-mustache falsy literals on aria-* attributes (rows h6, h9, h10)
+        // cause Glimmer to OMIT the attribute at runtime. AST-presence is not
+        // a proxy for runtime-presence here: an element written as
+        // <div role="option" aria-selected={{false}}> renders without any
+        // aria-selected attribute and should NOT be treated as satisfying
+        // role="option"'s required ARIA state.
         const foundAriaAttributes = (node.attributes ?? [])
-          .filter((attribute) => attribute.name?.startsWith('aria-'))
+          .filter(
+            (attribute) =>
+              attribute.name?.startsWith('aria-') &&
+              classifyAttribute(attribute).presence !== 'absent'
+          )
           .map((attribute) => attribute.name);
 
         const result = getMissingRequiredAttributes(roleTokens, foundAriaAttributes, node, context);

tests/lib/rules/template-require-mandatory-role-attributes.js

@@ -12,7 +12,15 @@ ruleTester.run('template-require-mandatory-role-attributes', rule, {
     '<template><div aria-disabled="true" /></template>',
     '<template><div role="complementary" /></template>',
     '<template><div role="combobox" aria-expanded="false" aria-controls="ctrlId" /></template>',
-    '<template><div role="option" aria-selected={{false}} /></template>',
+    // Static aria-selected satisfies role="option"'s required ARIA. Both empty-
+    // value and any literal value are recognized — what matters is that the
+    // attribute is rendered at runtime.
+    '<template><div role="option" aria-selected="true" /></template>',
+    '<template><div role="option" aria-selected="false" /></template>',
+    // Bare-mustache string-literal role (i2 analog) renders `role="option"`
+    // and is now recognized as a static role token. The required aria-selected
+    // is satisfied by its static text value.
+    '<template><div role={{"option"}} aria-selected="true" /></template>',
     '<template><FakeComponent /></template>',
     '<template><FakeComponent role="fakerole" /></template>',
     '<template><CustomComponent role="checkbox" aria-checked="false" /></template>',
@@ -74,6 +82,29 @@ ruleTester.run('template-require-mandatory-role-attributes', rule, {
       output: null,
       errors: [{ message: 'The attribute aria-selected is required by the role option' }],
     },
+    // Bare-mustache falsy aria attribute (h6) — Glimmer omits the attribute at
+    // runtime, so the required-ARIA check should NOT consider it satisfied.
+    // Previously this case was silently treated as valid (encoded as a passing
+    // fixture) because the rule counted AST attribute names, not runtime
+    // presence. Per docs/glimmer-attribute-behavior.md cross-attribute
+    // observations, aria-* is in the falsy-coercion list.
+    {
+      code: '<template><div role="option" aria-selected={{false}} /></template>',
+      output: null,
+      errors: [{ message: 'The attribute aria-selected is required by the role option' }],
+    },
+    {
+      code: '<template><div role="option" aria-selected={{null}} /></template>',
+      output: null,
+      errors: [{ message: 'The attribute aria-selected is required by the role option' }],
+    },
+    // Bare-mustache string-literal role (i2 analog) — now recognized; missing
+    // aria-selected is correctly flagged.
+    {
+      code: '<template><div role={{"option"}} /></template>',
+      output: null,
+      errors: [{ message: 'The attribute aria-selected is required by the role option' }],
+    },
     // Plain widget roles missing all required attrs — basic coverage that
     // peer plugins (jsx-a11y / vue-a11y / angular-eslint) also flag.
     {
@@ -246,7 +277,10 @@ hbsRuleTester.run('template-require-mandatory-role-attributes', rule, {
     '<div aria-disabled="true" />',
     '<div role="complementary" />',
     '<div role="combobox" aria-expanded="false" aria-controls="ctrlId" />',
-    '<div role="option" aria-selected={{false}} />',
+    '<div role="option" aria-selected="true" />',
+    '<div role="option" aria-selected="false" />',
+    // i2 analog: bare-mustache string-literal role renders `role="option"`.
+    '<div role={{"option"}} aria-selected="true" />',
     '<FakeComponent />',
     '<FakeComponent role="fakerole" />',
     '<CustomComponent role="checkbox" aria-checked="false" />',
@@ -285,6 +319,23 @@ hbsRuleTester.run('template-require-mandatory-role-attributes', rule, {
       output: null,
       errors: [{ message: 'The attribute aria-selected is required by the role option' }],
     },
+    // Bare-mustache falsy aria attribute (h6, h9) — Glimmer omits at runtime.
+    {
+      code: '<div role="option" aria-selected={{false}} />',
+      output: null,
+      errors: [{ message: 'The attribute aria-selected is required by the role option' }],
+    },
+    {
+      code: '<div role="option" aria-selected={{null}} />',
+      output: null,
+      errors: [{ message: 'The attribute aria-selected is required by the role option' }],
+    },
+    // Bare-mustache string-literal role (i2 analog) — now recognized.
+    {
+      code: '<div role={{"option"}} />',
+      output: null,
+      errors: [{ message: 'The attribute aria-selected is required by the role option' }],
+    },
     {
       code: '<CustomComponent role="checkbox" aria-required="true" />',
       output: null,