Skip to content

Commit ee679ec

Browse files
committed
Add regression tests for ember-template-lint#2926 and #2924
Verify our text-based fixer avoids the AST mutation bugs: - #2926: multi-line element does not duplicate lines - #2924: params preceding the fixable path are preserved
1 parent 89b919a commit ee679ec

1 file changed

Lines changed: 21 additions & 0 deletions

File tree

tests/lib/rules/template-no-obscure-array-access.js

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,27 @@ ruleTester.run('template-no-obscure-array-access', rule, {
7373
output: '<template><Foo @bar={{get this.list "0.name.1.foo"}} /></template>',
7474
errors: [{ messageId: 'noObscureArrayAccess' }],
7575
},
76+
// Regression: ember-template-lint#2926 — multi-line must NOT duplicate lines
77+
{
78+
code: `<template><Component
79+
title="<error>"
80+
id={{@model.0.id}}
81+
as |value|
82+
></Component></template>`,
83+
output: `<template><Component
84+
title="<error>"
85+
id={{get @model "0.id"}}
86+
as |value|
87+
></Component></template>`,
88+
errors: [{ messageId: 'noObscureArrayAccess' }],
89+
},
90+
// Regression: ember-template-lint#2924 — must NOT eat preceding params
91+
{
92+
code: '<template><Button @onClick={{fn this.myFunc @row.0.sha256}}>Button</Button></template>',
93+
output:
94+
'<template><Button @onClick={{fn this.myFunc (get @row "0.sha256")}}>Button</Button></template>',
95+
errors: [{ messageId: 'noObscureArrayAccess' }],
96+
},
7697
],
7798
});
7899

0 commit comments

Comments
 (0)