Updates

Author: NullVoxPopuli

README.md

@@ -422,7 +422,7 @@ rules in templates can be disabled with eslint directives with mustache or html
 | :------------------------------------------------------------------------------------------------------------------------- | :-------------------------------------------------------- | :- | :- | :- |
 | [template-no-extra-mut-helper-argument](docs/rules/template-no-extra-mut-helper-argument.md)                               | disallow passing more than one argument to the mut helper |    |    |    |
 | [template-no-jsx-attributes](docs/rules/template-no-jsx-attributes.md)                                                     | disallow JSX-style camelCase attributes                   |    | 🔧 |    |
-| [template-no-scope-outside-table-headings](docs/rules/template-no-scope-outside-table-headings.md)                         | disallow scope attribute outside th/td elements           |    |    |    |
+| [template-no-scope-outside-table-headings](docs/rules/template-no-scope-outside-table-headings.md)                         | disallow scope attribute outside th elements              |    |    |    |
 | [template-no-shadowed-elements](docs/rules/template-no-shadowed-elements.md)                                               | disallow shadowing of built-in HTML elements              |    |    |    |
 | [template-no-unbalanced-curlies](docs/rules/template-no-unbalanced-curlies.md)                                             | disallow unbalanced mustache curlies                      |    |    |    |
 | [template-no-unknown-arguments-for-builtin-components](docs/rules/template-no-unknown-arguments-for-builtin-components.md) | disallow unknown arguments for built-in components        |    |    |    |

docs/rules/template-deprecated-inline-view-helper.md

@@ -8,16 +8,26 @@ In Ember 1.12, support for invoking the inline View helper was deprecated.
 
 ## Rule Details
 
-This rule flags `{{view}}` mustache or block statements that have hash pair arguments (e.g., `{{view 'foo' key=value}}`). Simple `{{view.property}}` path expressions or other usages without hash pairs are not flagged.
+This rule flags:
+
+- `{{view}}` mustache or block statements that have params or hash pair arguments (e.g., `{{view 'foo'}}`, `{{view 'foo' key=value}}`).
+- `{{view.property}}` path expressions (e.g., `{{view.also-bad}}`).
+- Hash values referencing `view.*` paths (e.g., `please=view.stop`).
 
 ## Examples
 
 This rule **forbids** the following:
 
 ```hbs
-{{view 'this-is-bad' tagName='span'}}
+{{view 'this-is-bad'}}
+
+{{view.also-bad}}
+
+{{qux-qaz please=view.stop}}
 
-{{#view tagName='span'}}content{{/view}}
+{{#not-this please=view.stop}}{{/not-this}}
+
+<div foo={{view.bar}}></div>
 ```
 
 This rule **allows** the following:
@@ -27,6 +37,8 @@ This rule **allows** the following:
 
 {{qux-qaz this=good}}
 
+{{#ok-this yay=nice}}{{/ok-this}}
+
 <div foo={{bar}}></div>
 ```
 

docs/rules/template-no-action-modifiers.md

@@ -42,6 +42,23 @@ This rule disallows using `{{action}}` as an element modifier.
 <form {{on 'submit' this.handleSubmit}}>Submit</form>
 ```
 
+## Configuration
+
+The following values are valid configuration:
+
+- boolean -- `true` for enabled / `false` for disabled
+- array -- an allowlist of element tag names, which will accept action modifiers
+
+For example, to allow action modifiers only on specific elements:
+
+```js
+module.exports = {
+  rules: {
+    'ember/template-no-action-modifiers': ['error', { allowlist: ['form'] }],
+  },
+};
+```
+
 ## Related Rules
 
 - [template-no-action](./template-no-action.md)

docs/rules/template-no-action-on-submit-button.md

@@ -2,56 +2,48 @@
 
 <!-- end auto-generated rule header -->
 
-Disallow `action` attribute on submit buttons.
+Disallow click action on submit buttons within a form.
 
-Using the `action` attribute on submit buttons is a common mistake. Instead, you should use the `{{on}}` modifier to handle click events, or handle form submission at the form level.
+In a `<form>`, all `<button>` elements with a `type="submit"` attribute (or no `type`, since buttons default to `type="submit"`) should not have any click action. The action should be on the `<form>` element instead of directly on the button.
 
 ## Rule Details
 
-This rule disallows using the `action` attribute on `<button>` elements (which default to type="submit") and `<input type="submit">` elements.
+This rule disallows:
 
-## Examples
-
-### Incorrect ❌
+- Using `{{action}}` or `{{on "click"}}` modifiers on submit buttons inside a `<form>`.
+- Using the HTML `action` attribute on submit buttons or `<input type="submit">` elements.
 
-```gjs
-<template>
-  <button action="save">Save</button>
-</template>
-```
+## Examples
 
-```gjs
-<template>
-  <button type="submit" action="submit">Submit</button>
-</template>
-```
+### Incorrect
 
-```gjs
-<template>
-  <input type="submit" action="go" />
-</template>
+```hbs
+<form>
+  <button type='submit' {{on 'click' this.handleClick}} />
+  <button type='submit' {{action 'handleClick'}} />
+  <button {{on 'click' this.handleClick}} />
+  <button {{action 'handleClick'}} />
+</form>
 ```
 
-### Correct ✅
+### Correct
 
-```gjs
-<template>
-  <button {{on "click" this.handleClick}}>Save</button>
-</template>
+```hbs
+<form>
+  <button type='button' {{on 'click' this.handleClick}} />
+  <button type='button' {{action 'handleClick'}} />
+  <button type='submit' />
+  <button />
+</form>
 ```
 
-```gjs
-<template>
-  <button type="button" action="doSomething">Click</button>
-</template>
-```
+Buttons outside a `<form>` are allowed to have click actions:
 
-```gjs
-<template>
-  <form {{on "submit" this.handleSubmit}}>
-    <button type="submit">Submit</button>
-  </form>
-</template>
+```hbs
+<button type='submit' {{on 'click' this.handleClick}} />
+<button type='submit' {{action 'handleClick'}} />
+<button {{on 'click' this.handleClick}} />
+<button {{action 'handleClick'}} />
 ```
 
 ## Related Rules

docs/rules/template-no-arguments-for-html-elements.md

@@ -52,6 +52,26 @@ This rule disallows using `@arguments` on HTML elements. Use regular attributes
 </template>
 ```
 
+Yielded components, named blocks, and path expressions are also allowed:
+
+```hbs
+{{#let (component 'bar') as |foo|}}
+  <foo @name='1' />
+{{/let}}
+```
+
+```hbs
+<foo.some.name @name='1' />
+<@foo @name='2' />
+<@foo.bar @name='2' />
+```
+
+```hbs
+<MyComponent>
+  <:slot @name='Header'></:slot>
+</MyComponent>
+```
+
 ## Related Rules
 
 - [template-no-block-params-for-html-elements](./template-no-block-params-for-html-elements.md)

docs/rules/template-no-aria-unsupported-elements.md

@@ -10,14 +10,10 @@ Certain HTML elements do not support ARIA roles, states, and properties. This ru
 
 This rule disallows ARIA attributes on elements that do not support them, including:
 
-- `meta`
 - `html`
+- `meta`
 - `script`
 - `style`
-- `title`
-- `base`
-- `head`
-- `link`
 
 ## Examples
 

docs/rules/template-no-array-prototype-extensions.md

@@ -12,8 +12,6 @@ This rule disallows using Ember Array prototype extensions in templates:
 
 - `firstObject`
 - `lastObject`
-- `@each`
-- `[]`
 
 ## Examples
 
@@ -31,12 +29,6 @@ This rule disallows using Ember Array prototype extensions in templates:
 </template>
 ```
 
-```gjs
-<template>
-  {{this.data.@each}}
-</template>
-```
-
 ### Correct ✅
 
 ```gjs

docs/rules/template-no-capital-arguments.md

@@ -6,7 +6,14 @@ Disallow capital letters in argument names. Use lowercase argument names (e.g.,
 
 ## Rule Details
 
-This rule enforces the convention that argument names should start with lowercase letters.
+This rule enforces the convention that argument names should start with lowercase letters. Anything that does not start with a lowercase letter (such as `@Foo`, `@0`, `@!` etc) is a reserved argument name. This is purely speculative and the goal is to carve out some space for future features. If we don't end up needing them, we can always relax the restrictions down the road.
+
+Additionally, the following are reserved names and will also be flagged by this rule:
+
+- `@arguments`
+- `@args`
+- `@block`
+- `@else`
 
 ## Examples
 
@@ -24,6 +31,18 @@ Examples of **incorrect** code for this rule:
 </template>
 ```
 
+```gjs
+<template>
+  <div>{{@arguments}}</div>
+</template>
+```
+
+```gjs
+<template>
+  <Foo @args={{true}} />
+</template>
+```
+
 Examples of **correct** code for this rule:
 
 ```gjs
@@ -40,4 +59,5 @@ Examples of **correct** code for this rule:
 
 ## References
 
+- [RFC #276 - Reserved Names](https://github.com/emberjs/rfcs/blob/68812bf2d439c6bb77ad491e0159b371b68c5c35/text/0276-named-args.md#reserved-names)
 - [Ember Style Guide](https://github.com/ember-cli/ember-styleguide)

docs/rules/template-no-duplicate-landmark-elements.md

@@ -12,12 +12,13 @@ This rule ensures that when multiple landmark elements of the same type appear i
 
 Landmark elements checked:
 
-- `header`
-- `footer`
-- `main`
-- `nav`
-- `aside`
-- `section`
+- `header` (banner)
+- `footer` (contentinfo)
+- `main` (main)
+- `nav` (navigation)
+- `aside` (complementary)
+- `section` (region)
+- `form` (form, search)
 
 ## Examples
 

docs/rules/template-no-inline-linkto.md

@@ -8,6 +8,8 @@ Disallows inline form of the LinkTo component.
 
 The inline form of `<LinkTo>` (self-closing without content) should be avoided. Use the block form instead to provide link text.
 
+This rule also disallows the curly `{{link-to}}` inline form (e.g., `{{link-to "text" "route"}}`). The block form `{{#link-to}}...{{/link-to}}` or `<LinkTo>` angle bracket syntax should be used instead.
+
 ## Examples
 
 Examples of **incorrect** code for this rule:
@@ -24,6 +26,18 @@ Examples of **incorrect** code for this rule:
 </template>
 ```
 
+```gjs
+<template>
+  {{link-to "Link text" "routeName"}}
+</template>
+```
+
+```gjs
+<template>
+  {{link-to "Link text" "routeName" prop1 prop2}}
+</template>
+```
+
 Examples of **correct** code for this rule:
 
 ```gjs
@@ -40,6 +54,12 @@ Examples of **correct** code for this rule:
 </template>
 ```
 
+```gjs
+<template>
+  {{#link-to "routeName" prop1 prop2}}Link text{{/link-to}}
+</template>
+```
+
 ## References
 
 - [eslint-plugin-ember template-no-inline-link-to](https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/template-no-inline-link-to.md)