Merge pull request #2541 from johanrd/issue/2339-array-extensions-mirage

[BUGFIX legacy]: Broaden mirage.js `findBy` exclusion in `no-array-prototype-extensions`

Author: NullVoxPopuli

lib/rules/no-array-prototype-extensions.js

@@ -93,8 +93,8 @@ const KNOWN_NON_ARRAY_FUNCTION_CALLS = new Set([
  * Ignore these function calls using RegExps.
  */
 const KNOWN_NON_ARRAY_FUNCTION_CALLS_REGEXP = new Set([
-  // ember-cli-mirage
-  /\.server\.schema\.(.*)\.findBy\(\)/,
+  // ember-cli-mirage: server.schema.X.findBy(), schema.X.findBy(), server.X.findBy(), server.db.X.findBy()
+  /(^|\.)(server|schema)\b.*\.findBy\(\)/,
 ]);
 
 /**

tests/lib/rules/no-array-prototype-extensions.js

@@ -253,6 +253,10 @@ ruleTester.run('no-array-prototype-extensions', rule, {
     'this.server.schema.devices.findBy()',
     'this.server.schema.users.findBy({ foo: "bar" })',
     'this.server.schema.devices.findBy({ foo: "bar" })',
+    'server.schema.users.findBy({ email: "[email protected]" })',
+    'schema.users.findBy({ email: "[email protected]" })',
+    'server.users.findBy({ email: "[email protected]" })',
+    'server.db.users.findBy({ email: "[email protected]" })',
   ],
   invalid: [
     {