Skip to content

Commit d9c0452

Browse files
committed
chore: remove 'upstream' references from comments
1 parent b71e729 commit d9c0452

2 files changed

Lines changed: 11 additions & 12 deletions

File tree

lib/rules/template-require-iframe-title.js

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ module.exports = {
1010
},
1111
schema: [],
1212
messages: {
13-
// Split from a single `missingTitle` into four messageIds aligned with
14-
// upstream ember-template-lint, providing richer diagnostic detail.
13+
// Four messageIds (missingTitle, emptyTitle, dynamicFalseTitle,
14+
// duplicateTitle) for richer diagnostic detail.
1515
missingTitle: '<iframe> elements must have a unique title property.',
1616
emptyTitle: '<iframe> elements must have a unique title property.',
1717
dynamicFalseTitle: '<iframe> elements must have a unique title property.',
@@ -61,20 +61,19 @@ module.exports = {
6161
if (value.length === 0) {
6262
context.report({ node, messageId: 'emptyTitle' });
6363
} else {
64-
// Check for duplicate titles. Upstream reports BOTH the
65-
// first and the current occurrence of a duplicated title
66-
// on every collision, sharing a `#N` index so users can
67-
// correlate them. For three or more duplicates the first
68-
// occurrence is therefore re-reported once per collision.
64+
// Check for duplicate titles. Reports BOTH the first and the
65+
// current occurrence on every collision, sharing a `#N` index
66+
// so users can correlate them. For three or more duplicates
67+
// the first occurrence is therefore re-reported once per
68+
// collision.
6969
const existing = knownTitles.find((entry) => entry.value === value);
7070
if (existing) {
7171
if (existing.index === null) {
7272
existing.index = nextDuplicateIndex++;
7373
}
7474
const index = existing.index;
7575

76-
// Report on the first occurrence on every collision,
77-
// matching upstream ember-template-lint behavior.
76+
// Report on the first occurrence on every collision.
7877
context.report({
7978
node: existing.node,
8079
messageId: 'duplicateTitleFirst',

tests/lib/rules/template-require-iframe-title.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ ruleTester.run('template-require-iframe-title', rule, {
3232
},
3333

3434
{
35-
// Upstream reports BOTH occurrences with a shared `#N` index.
35+
// Both occurrences are reported with a shared `#N` index.
3636
code: '<template><iframe title="foo" /><iframe title="foo" /></template>',
3737
output: null,
3838
errors: [
@@ -44,7 +44,7 @@ ruleTester.run('template-require-iframe-title', rule, {
4444
],
4545
},
4646
{
47-
// Three duplicates → upstream re-reports the first occurrence on every
47+
// Three duplicates → the first occurrence is re-reported on every
4848
// collision, so iframe #1 is flagged twice (once per later collision)
4949
// and iframes #2 and #3 are each flagged once. ESLint sorts by source
5050
// location, so the two first-occurrence reports (same location) come
@@ -136,7 +136,7 @@ hbsRuleTester.run('template-require-iframe-title', rule, {
136136
],
137137
},
138138
{
139-
// Three duplicates: upstream re-reports the first occurrence on every
139+
// Three duplicates: the first occurrence is re-reported on every
140140
// collision, so iframe #1 is flagged twice and each later iframe once.
141141
code: '<iframe title="foo" /><iframe title="foo" /><iframe title="foo" />',
142142
output: null,

0 commit comments

Comments
 (0)