refactor: extract validateByType to drop isValidAriaValue complexity below 20

Author: johanrd

lib/rules/template-no-invalid-aria-attributes.js

@@ -11,29 +11,7 @@ function isNumeric(value) {
   return !Number.isNaN(Number(value));
 }
 
-function isValidAriaValue(attrName, value) {
-  const attrDef = aria.get(attrName);
-  if (!attrDef) {
-    return true;
-  }
-
-  // Check whether 'undefined' is an explicit token in the attribute's value list
-  // (e.g. aria-orientation allows 'undefined' per aria-query) BEFORE applying the
-  // generic allowundefined shortcut. Otherwise valid tokens get rejected for
-  // attributes where allowundefined is false.
-  if (
-    value === 'undefined' &&
-    (attrDef.type === 'token' || attrDef.type === 'tokenlist') &&
-    Array.isArray(attrDef.values) &&
-    attrDef.values.includes('undefined')
-  ) {
-    return true;
-  }
-
-  if (value === 'undefined') {
-    return Boolean(attrDef.allowundefined);
-  }
-
+function validateByType(attrDef, value) {
   switch (attrDef.type) {
     case 'boolean': {
       return isBoolean(value);
@@ -73,6 +51,32 @@ function isValidAriaValue(attrName, value) {
   }
 }
 
+function isValidAriaValue(attrName, value) {
+  const attrDef = aria.get(attrName);
+  if (!attrDef) {
+    return true;
+  }
+
+  // Check whether 'undefined' is an explicit token in the attribute's value list
+  // (e.g. aria-orientation allows 'undefined' per aria-query) BEFORE applying the
+  // generic allowundefined shortcut. Otherwise valid tokens get rejected for
+  // attributes where allowundefined is false.
+  if (
+    value === 'undefined' &&
+    (attrDef.type === 'token' || attrDef.type === 'tokenlist') &&
+    Array.isArray(attrDef.values) &&
+    attrDef.values.includes('undefined')
+  ) {
+    return true;
+  }
+
+  if (value === 'undefined') {
+    return Boolean(attrDef.allowundefined);
+  }
+
+  return validateByType(attrDef, value);
+}
+
 function getExpectedTypeDescription(attrName) {
   const attrDef = aria.get(attrName);
   if (!attrDef) {