Merge branch 'master' into night_fix/template-no-obsolete-elements

Author: johanrd

README.md

@@ -249,7 +249,7 @@ rules in templates can be disabled with eslint directives with mustache or html
 | [template-no-model-argument-in-route-templates](docs/rules/template-no-model-argument-in-route-templates.md)       | disallow @model argument in route templates                                  |    | 🔧 |    |
 | [template-no-multiple-empty-lines](docs/rules/template-no-multiple-empty-lines.md)                                 | disallow multiple consecutive empty lines in templates                       |    | 🔧 |    |
 | [template-no-mut-helper](docs/rules/template-no-mut-helper.md)                                                     | disallow usage of (mut) helper                                               |    |    |    |
-| [template-no-negated-comparison](docs/rules/template-no-negated-comparison.md)                                     | disallow negated comparisons in templates                                    |    |    |    |
+| [template-no-negated-condition](docs/rules/template-no-negated-condition.md)                                       | disallow negated conditions in if/unless                                     |    | 🔧 |    |
 | [template-no-nested-splattributes](docs/rules/template-no-nested-splattributes.md)                                 | disallow nested ...attributes usage                                          |    |    |    |
 | [template-no-obscure-array-access](docs/rules/template-no-obscure-array-access.md)                                 | disallow obscure array access patterns like `[email protected]`      |    | 🔧 |    |
 | [template-no-obsolete-elements](docs/rules/template-no-obsolete-elements.md)                                       | disallow obsolete HTML elements                                              |    |    |    |
@@ -283,7 +283,7 @@ rules in templates can be disabled with eslint directives with mustache or html
 | [template-require-valid-named-block-naming-format](docs/rules/template-require-valid-named-block-naming-format.md) | require valid named block naming format                                      |    | 🔧 |    |
 | [template-self-closing-void-elements](docs/rules/template-self-closing-void-elements.md)                           | require self-closing on void elements                                        |    | 🔧 |    |
 | [template-simple-modifiers](docs/rules/template-simple-modifiers.md)                                               | require simple modifier syntax                                               |    |    |    |
-| [template-simple-unless](docs/rules/template-simple-unless.md)                                                     | require simple conditions in unless blocks                                   |    |    |    |
+| [template-simple-unless](docs/rules/template-simple-unless.md)                                                     | require simple conditions in unless blocks                                   |    | 🔧 |    |
 | [template-sort-invocations](docs/rules/template-sort-invocations.md)                                               | require sorted attributes and modifiers                                      |    | 🔧 |    |
 | [template-splat-attributes-only](docs/rules/template-splat-attributes-only.md)                                     | disallow ...spread other than ...attributes                                  |    |    |    |
 | [template-style-concatenation](docs/rules/template-style-concatenation.md)                                         | disallow string concatenation in inline styles                               |    |    |    |
@@ -418,7 +418,7 @@ rules in templates can be disabled with eslint directives with mustache or html
 | [template-no-scope-outside-table-headings](docs/rules/template-no-scope-outside-table-headings.md)                         | disallow scope attribute outside th elements                      |    |    |    |
 | [template-no-shadowed-elements](docs/rules/template-no-shadowed-elements.md)                                               | disallow ambiguity with block param names shadowing HTML elements |    |    |    |
 | [template-no-unbalanced-curlies](docs/rules/template-no-unbalanced-curlies.md)                                             | disallow unbalanced mustache curlies                              |    |    |    |
-| [template-no-unknown-arguments-for-builtin-components](docs/rules/template-no-unknown-arguments-for-builtin-components.md) | disallow unknown arguments for built-in components                |    |    |    |
+| [template-no-unknown-arguments-for-builtin-components](docs/rules/template-no-unknown-arguments-for-builtin-components.md) | disallow unknown arguments for built-in components                |    | 🔧 |    |
 
 ### Routes
 

docs/rules/template-no-action.md

@@ -42,6 +42,25 @@ Examples of **correct** code for this rule:
 </template>
 ```
 
+```gjs
+import action from './my-action-helper';
+<template>
+  {{action this.handleClick}}
+</template>
+```
+
+```gjs
+<template>
+  {{#each items as |action|}}
+    <button {{action this.handleClick}}>x</button>
+  {{/each}}
+</template>
+```
+
+## Strict-mode behavior
+
+`action` is an ambient strict-mode keyword in Ember (registered in `STRICT_MODE_KEYWORDS`), so `{{action this.x}}` works in `.gjs`/`.gts` templates without an explicit import. The rule still flags those uses to discourage the deprecated keyword — but skips reports when `action` resolves to a JS-scope binding (an import or local declaration) or a template block param.
+
 ## Migration
 
 - Replace `(action "methodName")` with method references or `(fn this.methodName)`

docs/rules/template-no-dynamic-subexpression-invocations.md

@@ -26,12 +26,6 @@ This rule disallows invoking helpers dynamically using `this` or `@` properties.
 </template>
 ```
 
-```gjs
-<template>
-  {{this.formatter this.data}}
-</template>
-```
-
 ### Correct ✅
 
 ```gjs
@@ -52,6 +46,13 @@ This rule disallows invoking helpers dynamically using `this` or `@` properties.
 </template>
 ```
 
+```gjs
+{{! Body-position dynamic helpers are allowed }}
+<template>
+  {{this.formatter this.data}}
+</template>
+```
+
 ## Related Rules
 
 - [template-no-implicit-this](./template-no-implicit-this.md)

docs/rules/template-no-inline-linkto.md

@@ -62,6 +62,19 @@ Examples of **correct** code for this rule:
 </template>
 ```
 
+```gjs
+// User-authored `<LinkTo>` (not from `@ember/routing`) is not flagged in
+// strict mode, even when childless.
+import LinkTo from './my-link-to-component';
+<template>
+  <LinkTo />
+</template>
+```
+
+## Strict-mode behavior
+
+In `.gjs`/`.gts` strict mode, `<LinkTo>` only refers to Ember's router link when explicitly imported from `@ember/routing` (this also covers renamed imports such as `import { LinkTo as Link } from '@ember/routing'`). Without that import, `<LinkTo>` is treated as a user-authored component and the rule does not fire. The curly `{{link-to ...}}` form is unreachable in strict mode (`link-to` cannot be a JS identifier) and the autofix is skipped there.
+
 ## References
 
 - [eslint-plugin-ember template-no-inline-link-to](https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/template-no-inline-link-to.md)

docs/rules/template-no-mut-helper.md

@@ -1,7 +1,5 @@
 # ember/template-no-mut-helper
 
-> **HBS Only**: This rule applies to classic `.hbs` template files only (loose mode). It is not relevant for `gjs`/`gts` files (strict mode), where these patterns cannot occur.
-
 <!-- end auto-generated rule header -->
 
 Disallow usage of the `(mut)` helper.

docs/rules/template-no-negated-comparison.md

@@ -0,0 +1,53 @@
+# ember/template-no-negated-condition
+
+🔧 This rule is automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/latest/user-guide/command-line-interface#--fix).
+
+<!-- end auto-generated rule header -->
+
+Disallow negated conditions in `{{#if}}` blocks. Use `{{#unless}}` instead or rewrite the condition.
+
+## Rule Details
+
+This rule discourages the use of `{{#if (not condition)}}` in favor of `{{#unless condition}}` for better readability.
+
+## Examples
+
+Examples of **incorrect** code for this rule:
+
+```gjs
+<template>
+  {{#if (not isValid)}}
+    Invalid
+  {{/if}}
+</template>
+```
+
+Examples of **correct** code for this rule:
+
+```gjs
+<template>
+  {{#unless isValid}}
+    Invalid
+  {{/unless}}
+</template>
+
+<template>
+  {{#if isValid}}
+    Valid
+  {{/if}}
+</template>
+```
+
+## Options
+
+| Name              | Type      | Default | Description                                                                                                             |
+| ----------------- | --------- | ------- | ----------------------------------------------------------------------------------------------------------------------- |
+| `simplifyHelpers` | `boolean` | `true`  | When `true`, also reports negated comparison helpers (e.g. `(not (eq ...))`) and suggests using `(not-eq ...)` instead. |
+
+## Related Rules
+
+- [simple-unless](template-simple-unless.md)
+
+## References
+
+- [no-negated-condition](https://eslint.org/docs/rules/no-negated-condition) from eslint

docs/rules/template-no-negated-condition.md

@@ -1,7 +1,5 @@
 # ember/template-no-unbound
 
-> **HBS Only**: This rule applies to classic `.hbs` template files only (loose mode). It is not relevant for `gjs`/`gts` files (strict mode), where these patterns cannot occur.
-
 <!-- end auto-generated rule header -->
 
 `{{unbound}}` is a legacy hold over from the days in which Ember's template engine was less performant. Its use today

docs/rules/template-no-unbound.md

@@ -1,5 +1,7 @@
 # ember/template-no-unknown-arguments-for-builtin-components
 
+🔧 This rule is automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/latest/user-guide/command-line-interface#--fix).
+
 <!-- end auto-generated rule header -->
 
 The builtin components `LinkTo`, `Input`, `Textarea` has list of allowed arguments, and some argument names may be mistyped, this rule trying to highlight possible typos, checking for unknown arguments, also, some components has conflicted and required arguments, rule addressing this behavior.

docs/rules/template-no-unknown-arguments-for-builtin-components.md

@@ -1,5 +1,7 @@
 # ember/template-simple-unless
 
+🔧 This rule is automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/latest/user-guide/command-line-interface#--fix).
+
 <!-- end auto-generated rule header -->
 
 Require simple conditions in `{{#unless}}` blocks. Complex expressions should use `{{#if}}` with negation instead.