Skip to content

Commit bb93fff

Browse files
Merge pull request #2504 from johanrd/fix/2484
Post-merge review of #2484 (`template-no-nested-interactive`)
2 parents 9539f9b + b5360d9 commit bb93fff

2 files changed

Lines changed: 9 additions & 7 deletions

File tree

docs/rules/template-no-nested-interactive.md

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -99,12 +99,13 @@ Examples of **correct** code for this rule:
9999

100100
## Options
101101

102-
| Name | Type | Default | Description |
103-
| --------------------------- | ---------- | ------- | ----------------------------------------------------------- |
104-
| `additionalInteractiveTags` | `string[]` | `[]` | Extra tag names to consider interactive. |
105-
| `ignoredTags` | `string[]` | `[]` | Tag names to skip checking. |
106-
| `ignoreTabindex` | `boolean` | `false` | If `true`, `tabindex` does not make an element interactive. |
107-
| `ignoreUsemap` | `boolean` | `false` | If `true`, `usemap` does not make an element interactive. |
102+
| Name | Type | Default | Description |
103+
| --------------------------- | ---------- | ------- | ------------------------------------------------------------- |
104+
| `additionalInteractiveTags` | `string[]` | `[]` | Extra tag names to consider interactive. |
105+
| `ignoredTags` | `string[]` | `[]` | Tag names to skip checking. |
106+
| `ignoreTabindex` | `boolean` | `false` | If `true`, `tabindex` does not make an element interactive. |
107+
| `ignoreUsemap` | `boolean` | `false` | If `true`, `usemap` does not make an element interactive. |
108+
| `ignoreUsemapAttribute` | `boolean` | `false` | Alias for `ignoreUsemap` (original ember-template-lint name). |
108109

109110
## References
110111

lib/rules/template-no-nested-interactive.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@ module.exports = {
7979
ignoredTags: { type: 'array', items: { type: 'string' } },
8080
ignoreTabindex: { type: 'boolean' },
8181
ignoreUsemap: { type: 'boolean' },
82+
ignoreUsemapAttribute: { type: 'boolean' },
8283
},
8384
additionalProperties: false,
8485
},
@@ -99,7 +100,7 @@ module.exports = {
99100
const additionalInteractiveTags = new Set(options.additionalInteractiveTags || []);
100101
const ignoredTags = new Set(options.ignoredTags || []);
101102
const ignoreTabindex = options.ignoreTabindex || false;
102-
const ignoreUsemap = options.ignoreUsemap || false;
103+
const ignoreUsemap = options.ignoreUsemap || options.ignoreUsemapAttribute || false;
103104

104105
const interactiveStack = [];
105106
// Stack for saving/restoring label interactiveChildCount across GlimmerBlock boundaries

0 commit comments

Comments
 (0)