Skip to content

Commit b65f24b

Browse files
Fix strictGjs/strictGts placement in template-require-input-label
Co-authored-by: NullVoxPopuli <[email protected]>
1 parent b0353ea commit b65f24b

5 files changed

Lines changed: 123 additions & 119 deletions

File tree

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,7 @@ rules in templates can be disabled with eslint directives with mustache or html
219219
| [template-no-redundant-landmark-role](docs/rules/template-no-redundant-landmark-role.md) | disallow redundant landmark roles that are implicit on HTML elements | ![badge-strict-gjs][] ![badge-strict-gts][] | 🔧 | |
220220
| [template-require-context-role](docs/rules/template-require-context-role.md) | require ARIA roles to be used in appropriate context | ![badge-strict-gjs][] ![badge-strict-gts][] | | |
221221
| [template-require-iframe-title](docs/rules/template-require-iframe-title.md) | require iframe elements to have a title attribute | ![badge-strict-gjs][] ![badge-strict-gts][] | | |
222-
| [template-require-input-label](docs/rules/template-require-input-label.md) | Require label for form input elements | | | |
222+
| [template-require-input-label](docs/rules/template-require-input-label.md) | require label for form input elements | ![badge-strict-gjs][] ![badge-strict-gts][] | | |
223223
| [template-require-lang-attribute](docs/rules/template-require-lang-attribute.md) | require lang attribute on html element | ![badge-strict-gjs][] ![badge-strict-gts][] | | |
224224
| [template-require-media-caption](docs/rules/template-require-media-caption.md) | require captions for audio and video elements | ![badge-strict-gjs][] ![badge-strict-gts][] | | |
225225
| [template-require-presentational-children](docs/rules/template-require-presentational-children.md) | require presentational elements to only contain presentational children | ![badge-strict-gjs][] ![badge-strict-gts][] | | |

docs/rules/template-require-input-label.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
# ember/template-require-input-label
22

3+
💼 This rule is enabled in the following [configs](https://github.com/ember-cli/eslint-plugin-ember#-configurations): `strict-gjs`, `strict-gts`.
4+
35
<!-- end auto-generated rule header -->
46

57
✅ The `extends: 'plugin:ember/strict-gjs'` and `extends: 'plugin:ember/strict-gts'` property in a configuration file enables this rule.

lib/rules/template-require-input-label.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,14 @@ module.exports = {
99
docs: {
1010
description: 'require label for form input elements',
1111
category: 'Accessibility',
12+
strictGjs: true,
13+
strictGts: true,
1214
url: 'https://github.com/ember-cli/eslint-plugin-ember/tree/master/docs/rules/template-require-input-label.md',
1315
},
1416
schema: [],
1517
messages: {
1618
requireLabel: 'Input elements should have an associated label',
1719
},
18-
strictGjs: true,
19-
strictGts: true,
2020
},
2121

2222
create(context) {

lib/strict-rules-gjs.js

Lines changed: 59 additions & 58 deletions
Original file line numberDiff line numberDiff line change
@@ -5,61 +5,62 @@
55
* definitions, execute "npm run update"
66
*/
77
module.exports = {
8-
'ember/template-deprecated-inline-view-helper': 'error',
9-
'ember/template-deprecated-render-helper': 'error',
10-
'ember/template-link-rel-noopener': 'error',
11-
'ember/template-no-abstract-roles': 'error',
12-
'ember/template-no-accesskey-attribute': 'error',
13-
'ember/template-no-action': 'error',
14-
'ember/template-no-ambiguous-glimmer-paths': 'error',
15-
'ember/template-no-args-paths': 'error',
16-
'ember/template-no-aria-hidden-body': 'error',
17-
'ember/template-no-attrs-in-components': 'error',
18-
'ember/template-no-attrs-splat': 'error',
19-
'ember/template-no-autofocus-attribute': 'error',
20-
'ember/template-no-block-params': 'error',
21-
'ember/template-no-debugger': 'error',
22-
'ember/template-no-down-event-binding': 'error',
23-
'ember/template-no-duplicate-attributes': 'error',
24-
'ember/template-no-duplicate-id': 'error',
25-
'ember/template-no-empty-headings': 'error',
26-
'ember/template-no-form-action': 'error',
27-
'ember/template-no-heading-inside-button': 'error',
28-
'ember/template-no-inline-event-handlers': 'error',
29-
'ember/template-no-input-block': 'error',
30-
'ember/template-no-input-tagname': 'error',
31-
'ember/template-no-invalid-interactive': 'error',
32-
'ember/template-no-invalid-role': 'error',
33-
'ember/template-no-link-to-positional-params': 'error',
34-
'ember/template-no-link-to-tagname': 'error',
35-
'ember/template-no-log': 'error',
36-
'ember/template-no-multiple-empty-lines': 'error',
37-
'ember/template-no-nested-interactive': 'error',
38-
'ember/template-no-nested-landmark': 'error',
39-
'ember/template-no-obsolete-elements': 'error',
40-
'ember/template-no-partial': 'error',
41-
'ember/template-no-passed-in-event-handlers': 'error',
42-
'ember/template-no-pointer-down-event-binding': 'error',
43-
'ember/template-no-positive-tabindex': 'error',
44-
'ember/template-no-redundant-fn': 'error',
45-
'ember/template-no-redundant-landmark-role': 'error',
46-
'ember/template-no-route-action': 'error',
47-
'ember/template-no-shadowed-elements': 'error',
48-
'ember/template-no-this-in-template-only-components': 'error',
49-
'ember/template-no-trailing-spaces': 'error',
50-
'ember/template-no-triple-curlies': 'error',
51-
'ember/template-no-unbound': 'error',
52-
'ember/template-no-unnecessary-concat': 'error',
53-
'ember/template-no-valueless-arguments': 'error',
54-
'ember/template-no-with': 'error',
55-
'ember/template-require-button-type': 'error',
56-
'ember/template-require-context-role': 'error',
57-
'ember/template-require-iframe-title': 'error',
58-
'ember/template-require-lang-attribute': 'error',
59-
'ember/template-require-media-caption': 'error',
60-
'ember/template-require-presentational-children': 'error',
61-
'ember/template-require-valid-alt-text': 'error',
62-
'ember/template-splat-attributes-only': 'error',
63-
'ember/template-style-concatenation': 'error',
64-
'ember/template-table-groups': 'error',
65-
};
8+
"ember/template-deprecated-inline-view-helper": "error",
9+
"ember/template-deprecated-render-helper": "error",
10+
"ember/template-link-rel-noopener": "error",
11+
"ember/template-no-abstract-roles": "error",
12+
"ember/template-no-accesskey-attribute": "error",
13+
"ember/template-no-action": "error",
14+
"ember/template-no-ambiguous-glimmer-paths": "error",
15+
"ember/template-no-args-paths": "error",
16+
"ember/template-no-aria-hidden-body": "error",
17+
"ember/template-no-attrs-in-components": "error",
18+
"ember/template-no-attrs-splat": "error",
19+
"ember/template-no-autofocus-attribute": "error",
20+
"ember/template-no-block-params": "error",
21+
"ember/template-no-debugger": "error",
22+
"ember/template-no-down-event-binding": "error",
23+
"ember/template-no-duplicate-attributes": "error",
24+
"ember/template-no-duplicate-id": "error",
25+
"ember/template-no-empty-headings": "error",
26+
"ember/template-no-form-action": "error",
27+
"ember/template-no-heading-inside-button": "error",
28+
"ember/template-no-inline-event-handlers": "error",
29+
"ember/template-no-input-block": "error",
30+
"ember/template-no-input-tagname": "error",
31+
"ember/template-no-invalid-interactive": "error",
32+
"ember/template-no-invalid-role": "error",
33+
"ember/template-no-link-to-positional-params": "error",
34+
"ember/template-no-link-to-tagname": "error",
35+
"ember/template-no-log": "error",
36+
"ember/template-no-multiple-empty-lines": "error",
37+
"ember/template-no-nested-interactive": "error",
38+
"ember/template-no-nested-landmark": "error",
39+
"ember/template-no-obsolete-elements": "error",
40+
"ember/template-no-partial": "error",
41+
"ember/template-no-passed-in-event-handlers": "error",
42+
"ember/template-no-pointer-down-event-binding": "error",
43+
"ember/template-no-positive-tabindex": "error",
44+
"ember/template-no-redundant-fn": "error",
45+
"ember/template-no-redundant-landmark-role": "error",
46+
"ember/template-no-route-action": "error",
47+
"ember/template-no-shadowed-elements": "error",
48+
"ember/template-no-this-in-template-only-components": "error",
49+
"ember/template-no-trailing-spaces": "error",
50+
"ember/template-no-triple-curlies": "error",
51+
"ember/template-no-unbound": "error",
52+
"ember/template-no-unnecessary-concat": "error",
53+
"ember/template-no-valueless-arguments": "error",
54+
"ember/template-no-with": "error",
55+
"ember/template-require-button-type": "error",
56+
"ember/template-require-context-role": "error",
57+
"ember/template-require-iframe-title": "error",
58+
"ember/template-require-input-label": "error",
59+
"ember/template-require-lang-attribute": "error",
60+
"ember/template-require-media-caption": "error",
61+
"ember/template-require-presentational-children": "error",
62+
"ember/template-require-valid-alt-text": "error",
63+
"ember/template-splat-attributes-only": "error",
64+
"ember/template-style-concatenation": "error",
65+
"ember/template-table-groups": "error"
66+
}

lib/strict-rules-gts.js

Lines changed: 59 additions & 58 deletions
Original file line numberDiff line numberDiff line change
@@ -5,61 +5,62 @@
55
* definitions, execute "npm run update"
66
*/
77
module.exports = {
8-
'ember/template-deprecated-inline-view-helper': 'error',
9-
'ember/template-deprecated-render-helper': 'error',
10-
'ember/template-link-rel-noopener': 'error',
11-
'ember/template-no-abstract-roles': 'error',
12-
'ember/template-no-accesskey-attribute': 'error',
13-
'ember/template-no-action': 'error',
14-
'ember/template-no-ambiguous-glimmer-paths': 'error',
15-
'ember/template-no-args-paths': 'error',
16-
'ember/template-no-aria-hidden-body': 'error',
17-
'ember/template-no-attrs-in-components': 'error',
18-
'ember/template-no-attrs-splat': 'error',
19-
'ember/template-no-autofocus-attribute': 'error',
20-
'ember/template-no-block-params': 'error',
21-
'ember/template-no-debugger': 'error',
22-
'ember/template-no-down-event-binding': 'error',
23-
'ember/template-no-duplicate-attributes': 'error',
24-
'ember/template-no-duplicate-id': 'error',
25-
'ember/template-no-empty-headings': 'error',
26-
'ember/template-no-form-action': 'error',
27-
'ember/template-no-heading-inside-button': 'error',
28-
'ember/template-no-inline-event-handlers': 'error',
29-
'ember/template-no-input-block': 'error',
30-
'ember/template-no-input-tagname': 'error',
31-
'ember/template-no-invalid-interactive': 'error',
32-
'ember/template-no-invalid-role': 'error',
33-
'ember/template-no-link-to-positional-params': 'error',
34-
'ember/template-no-link-to-tagname': 'error',
35-
'ember/template-no-log': 'error',
36-
'ember/template-no-multiple-empty-lines': 'error',
37-
'ember/template-no-nested-interactive': 'error',
38-
'ember/template-no-nested-landmark': 'error',
39-
'ember/template-no-obsolete-elements': 'error',
40-
'ember/template-no-partial': 'error',
41-
'ember/template-no-passed-in-event-handlers': 'error',
42-
'ember/template-no-pointer-down-event-binding': 'error',
43-
'ember/template-no-positive-tabindex': 'error',
44-
'ember/template-no-redundant-fn': 'error',
45-
'ember/template-no-redundant-landmark-role': 'error',
46-
'ember/template-no-route-action': 'error',
47-
'ember/template-no-shadowed-elements': 'error',
48-
'ember/template-no-this-in-template-only-components': 'error',
49-
'ember/template-no-trailing-spaces': 'error',
50-
'ember/template-no-triple-curlies': 'error',
51-
'ember/template-no-unbound': 'error',
52-
'ember/template-no-unnecessary-concat': 'error',
53-
'ember/template-no-valueless-arguments': 'error',
54-
'ember/template-no-with': 'error',
55-
'ember/template-require-button-type': 'error',
56-
'ember/template-require-context-role': 'error',
57-
'ember/template-require-iframe-title': 'error',
58-
'ember/template-require-lang-attribute': 'error',
59-
'ember/template-require-media-caption': 'error',
60-
'ember/template-require-presentational-children': 'error',
61-
'ember/template-require-valid-alt-text': 'error',
62-
'ember/template-splat-attributes-only': 'error',
63-
'ember/template-style-concatenation': 'error',
64-
'ember/template-table-groups': 'error',
65-
};
8+
"ember/template-deprecated-inline-view-helper": "error",
9+
"ember/template-deprecated-render-helper": "error",
10+
"ember/template-link-rel-noopener": "error",
11+
"ember/template-no-abstract-roles": "error",
12+
"ember/template-no-accesskey-attribute": "error",
13+
"ember/template-no-action": "error",
14+
"ember/template-no-ambiguous-glimmer-paths": "error",
15+
"ember/template-no-args-paths": "error",
16+
"ember/template-no-aria-hidden-body": "error",
17+
"ember/template-no-attrs-in-components": "error",
18+
"ember/template-no-attrs-splat": "error",
19+
"ember/template-no-autofocus-attribute": "error",
20+
"ember/template-no-block-params": "error",
21+
"ember/template-no-debugger": "error",
22+
"ember/template-no-down-event-binding": "error",
23+
"ember/template-no-duplicate-attributes": "error",
24+
"ember/template-no-duplicate-id": "error",
25+
"ember/template-no-empty-headings": "error",
26+
"ember/template-no-form-action": "error",
27+
"ember/template-no-heading-inside-button": "error",
28+
"ember/template-no-inline-event-handlers": "error",
29+
"ember/template-no-input-block": "error",
30+
"ember/template-no-input-tagname": "error",
31+
"ember/template-no-invalid-interactive": "error",
32+
"ember/template-no-invalid-role": "error",
33+
"ember/template-no-link-to-positional-params": "error",
34+
"ember/template-no-link-to-tagname": "error",
35+
"ember/template-no-log": "error",
36+
"ember/template-no-multiple-empty-lines": "error",
37+
"ember/template-no-nested-interactive": "error",
38+
"ember/template-no-nested-landmark": "error",
39+
"ember/template-no-obsolete-elements": "error",
40+
"ember/template-no-partial": "error",
41+
"ember/template-no-passed-in-event-handlers": "error",
42+
"ember/template-no-pointer-down-event-binding": "error",
43+
"ember/template-no-positive-tabindex": "error",
44+
"ember/template-no-redundant-fn": "error",
45+
"ember/template-no-redundant-landmark-role": "error",
46+
"ember/template-no-route-action": "error",
47+
"ember/template-no-shadowed-elements": "error",
48+
"ember/template-no-this-in-template-only-components": "error",
49+
"ember/template-no-trailing-spaces": "error",
50+
"ember/template-no-triple-curlies": "error",
51+
"ember/template-no-unbound": "error",
52+
"ember/template-no-unnecessary-concat": "error",
53+
"ember/template-no-valueless-arguments": "error",
54+
"ember/template-no-with": "error",
55+
"ember/template-require-button-type": "error",
56+
"ember/template-require-context-role": "error",
57+
"ember/template-require-iframe-title": "error",
58+
"ember/template-require-input-label": "error",
59+
"ember/template-require-lang-attribute": "error",
60+
"ember/template-require-media-caption": "error",
61+
"ember/template-require-presentational-children": "error",
62+
"ember/template-require-valid-alt-text": "error",
63+
"ember/template-splat-attributes-only": "error",
64+
"ember/template-style-concatenation": "error",
65+
"ember/template-table-groups": "error"
66+
}

0 commit comments

Comments
 (0)