Extract rule: template-no-action-on-submit-button

Author: NullVoxPopuli

README.md

@@ -196,6 +196,7 @@ rules in templates can be disabled with eslint directives with mustache or html
 | :----------------------------------------------------------------------------------------------------- | :-------------------------------------------------------------- | :- | :- | :- |
 | [template-builtin-component-arguments](docs/rules/template-builtin-component-arguments.md)             | disallow setting certain attributes on builtin components       |    |    |    |
 | [template-no-action-modifiers](docs/rules/template-no-action-modifiers.md)                             | disallow usage of {{action}} modifiers                          |    |    |    |
+| [template-no-action-on-submit-button](docs/rules/template-no-action-on-submit-button.md)               | disallow action attribute on submit buttons                     |    |    |    |
 | [template-no-arguments-for-html-elements](docs/rules/template-no-arguments-for-html-elements.md)       | disallow @arguments on HTML elements                            |    |    |    |
 | [template-no-array-prototype-extensions](docs/rules/template-no-array-prototype-extensions.md)         | disallow usage of Ember Array prototype extensions              |    |    |    |
 | [template-no-block-params-for-html-elements](docs/rules/template-no-block-params-for-html-elements.md) | disallow block params on HTML elements                          |    |    |    |

docs/rules/template-no-action-on-submit-button.md

@@ -0,0 +1,63 @@
+# ember/template-no-action-on-submit-button
+
+<!-- end auto-generated rule header -->
+
+Disallow `action` attribute on submit buttons.
+
+Using the `action` attribute on submit buttons is a common mistake. Instead, you should use the `{{on}}` modifier to handle click events, or handle form submission at the form level.
+
+## Rule Details
+
+This rule disallows using the `action` attribute on `<button>` elements (which default to type="submit") and `<input type="submit">` elements.
+
+## Examples
+
+### Incorrect ❌
+
+```gjs
+<template>
+  <button action="save">Save</button>
+</template>
+```
+
+```gjs
+<template>
+  <button type="submit" action="submit">Submit</button>
+</template>
+```
+
+```gjs
+<template>
+  <input type="submit" action="go" />
+</template>
+```
+
+### Correct ✅
+
+```gjs
+<template>
+  <button {{on "click" this.handleClick}}>Save</button>
+</template>
+```
+
+```gjs
+<template>
+  <button type="button" action="doSomething">Click</button>
+</template>
+```
+
+```gjs
+<template>
+  <form {{on "submit" this.handleSubmit}}>
+    <button type="submit">Submit</button>
+  </form>
+</template>
+```
+
+## Related Rules
+
+- [template-no-action-modifiers](./template-no-action-modifiers.md)
+
+## References
+
+- [eslint-plugin-ember template-no-invalid-interactive](https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/template-no-invalid-interactive.md)

lib/rules/template-no-action-on-submit-button.js

@@ -0,0 +1,126 @@
+function isInsideForm(node) {
+  let current = node.parent;
+  while (current) {
+    if (current.type === 'GlimmerElementNode' && current.tag === 'form') {
+      return true;
+    }
+    current = current.parent;
+  }
+  return false;
+}
+
+function isSubmitButton(node) {
+  for (const attr of node.attributes || []) {
+    if (
+      attr.name === 'type' &&
+      attr.value?.type === 'GlimmerTextNode' &&
+      attr.value.chars !== 'submit'
+    ) {
+      return false;
+    }
+  }
+  return true;
+}
+
+function hasClickHandlingModifier(node) {
+  for (const mod of node.modifiers || []) {
+    if (mod.path?.original === 'action') {
+      // {{action ...}} defaults to click event
+      const onPair = mod.hash?.pairs?.find((p) => p.key === 'on');
+      if (!onPair) {
+        return true;
+      }
+      const eventValue = onPair.value?.value ?? onPair.value?.chars;
+      if (eventValue === 'click') {
+        return true;
+      }
+    }
+    if (mod.path?.original === 'on') {
+      // {{on "event" handler}}
+      if (mod.params?.length > 0 && mod.params[0].value === 'click') {
+        return true;
+      }
+    }
+  }
+  return false;
+}
+
+/** @type {import('eslint').Rule.RuleModule} */
+module.exports = {
+  meta: {
+    type: 'problem',
+    docs: {
+      description: 'disallow action attribute on submit buttons',
+      category: 'Best Practices',
+      url: 'https://github.com/ember-cli/eslint-plugin-ember/tree/master/docs/rules/template-no-action-on-submit-button.md',
+    },
+    fixable: null,
+    schema: [],
+    messages: {
+      noActionOnSubmitButton:
+        'Do not use action attribute on submit buttons. Use on modifier instead or handle form submission.',
+    },
+    originallyFrom: {
+      name: 'ember-template-lint',
+      rule: 'lib/rules/no-action-on-submit-button.js',
+      docs: 'docs/rule/no-action-on-submit-button.md',
+      tests: 'test/unit/rules/no-action-on-submit-button-test.js',
+    },
+  },
+
+  create(context) {
+    return {
+      // eslint-disable-next-line complexity
+      GlimmerElementNode(node) {
+        if (node.tag !== 'button' && node.tag !== 'input') {
+          return;
+        }
+
+        let hasActionAttribute = false;
+        let isSubmitButtonExplicit = false;
+        let hasNonSubmitType = false;
+
+        for (const attr of node.attributes || []) {
+          if (attr.type === 'GlimmerAttrNode') {
+            if (attr.name === 'action') {
+              hasActionAttribute = true;
+            }
+            if (attr.name === 'type') {
+              const value = attr.value;
+              if (value.type === 'GlimmerTextNode' && value.chars === 'submit') {
+                isSubmitButtonExplicit = true;
+              } else if (value.type === 'GlimmerTextNode' && value.chars !== 'submit') {
+                hasNonSubmitType = true;
+              }
+            }
+          }
+        }
+
+        const isDefaultSubmitButton =
+          node.tag === 'button' && !hasNonSubmitType && !isSubmitButtonExplicit;
+
+        // Existing: check for action HTML attribute on submit buttons
+        if (hasActionAttribute && (isSubmitButtonExplicit || isDefaultSubmitButton)) {
+          context.report({
+            node,
+            messageId: 'noActionOnSubmitButton',
+          });
+          return;
+        }
+
+        // New: check for action/on click modifiers on submit buttons inside forms
+        if (
+          node.tag === 'button' &&
+          isSubmitButton(node) &&
+          isInsideForm(node) &&
+          hasClickHandlingModifier(node)
+        ) {
+          context.report({
+            node,
+            messageId: 'noActionOnSubmitButton',
+          });
+        }
+      },
+    };
+  },
+};