Extract rule: template-deprecated-inline-view-helper

Author: NullVoxPopuli

README.md

@@ -236,6 +236,7 @@ rules in templates can be disabled with eslint directives with mustache or html
 | [no-observers](docs/rules/no-observers.md)                                                       | disallow usage of observers                               | ✅  |    |    |
 | [no-old-shims](docs/rules/no-old-shims.md)                                                       | disallow usage of old shims for modules                   | ✅  | 🔧 |    |
 | [no-string-prototype-extensions](docs/rules/no-string-prototype-extensions.md)                   | disallow usage of `String` prototype extensions           | ✅  |    |    |
+| [template-deprecated-inline-view-helper](docs/rules/template-deprecated-inline-view-helper.md)   | disallow inline {{view}} helper                           |    |    |    |
 
 ### Ember Data
 

docs/rules/template-deprecated-inline-view-helper.md

@@ -0,0 +1,11 @@
+# ember/template-deprecated-inline-view-helper
+
+<!-- end auto-generated rule header -->
+
+## Examples
+
+See ember-template-lint documentation.
+
+## References
+
+- [ember-template-lint](https://github.com/ember-template-lint/ember-template-lint)

lib/rules/template-deprecated-inline-view-helper.js

@@ -0,0 +1,47 @@
+/** @type {import('eslint').Rule.RuleModule} */
+module.exports = {
+  meta: {
+    type: 'suggestion',
+    docs: {
+      description: 'disallow inline {{view}} helper',
+      category: 'Deprecations',
+      strictGjs: true,
+      strictGts: true,
+      url: 'https://github.com/ember-cli/eslint-plugin-ember/tree/master/docs/rules/template-deprecated-inline-view-helper.md',
+    },
+    fixable: null,
+    schema: [],
+    messages: {
+      deprecated:
+        'The inline form of `view` is deprecated. Please use `Ember.Component` instead. See http://emberjs.com/deprecations/v1.x/#toc_ember-view',
+    },
+  },
+
+  create(context) {
+    function checkForView(node) {
+      if (
+        node.path &&
+        node.path.type === 'GlimmerPathExpression' &&
+        node.path.original === 'view'
+      ) {
+        // Check if it has hash pairs (attributes), which indicates inline usage
+        if (node.hash && node.hash.pairs && node.hash.pairs.length > 0) {
+          context.report({
+            node,
+            messageId: 'deprecated',
+          });
+        }
+      }
+    }
+
+    return {
+      GlimmerMustacheStatement(node) {
+        checkForView(node);
+      },
+
+      GlimmerBlockStatement(node) {
+        checkForView(node);
+      },
+    };
+  },
+};

tests/lib/rules/template-deprecated-inline-view-helper.js

@@ -0,0 +1,18 @@
+const rule = require('../../../lib/rules/template-deprecated-inline-view-helper');
+const RuleTester = require('eslint').RuleTester;
+
+const ruleTester = new RuleTester({
+  parser: require.resolve('ember-eslint-parser'),
+  parserOptions: { ecmaVersion: 2022, sourceType: 'module' },
+});
+
+ruleTester.run('template-deprecated-inline-view-helper', rule, {
+  valid: ['<template><MyComponent /></template>', '<template>{{view}}</template>'],
+  invalid: [
+    {
+      code: '<template>{{view class="foo"}}</template>',
+      output: null,
+      errors: [{ messageId: 'deprecated' }],
+    },
+  ],
+});