Extract rule: template-no-inline-linkto

Author: NullVoxPopuli

README.md

@@ -199,6 +199,7 @@ rules in templates can be disabled with eslint directives with mustache or html
 | [template-no-capital-arguments](docs/rules/template-no-capital-arguments.md)                           | disallow capital arguments (use lowercase @arg instead of @Arg) |    |    |    |
 | [template-no-debugger](docs/rules/template-no-debugger.md)                                             | disallow {{debugger}} in templates                              |    |    |    |
 | [template-no-element-event-actions](docs/rules/template-no-element-event-actions.md)                   | disallow element event actions (use {{on}} modifier instead)    |    |    |    |
+| [template-no-inline-linkto](docs/rules/template-no-inline-linkto.md)                                   | disallow inline form of LinkTo component                        |    |    |    |
 | [template-no-log](docs/rules/template-no-log.md)                                                       | disallow {{log}} in templates                                   |    |    |    |
 
 ### Components

docs/rules/template-no-inline-linkto.md

@@ -0,0 +1,45 @@
+# ember/template-no-inline-linkto
+
+<!-- end auto-generated rule header -->
+
+Disallows inline form of the LinkTo component.
+
+## Rule Details
+
+The inline form of `<LinkTo>` (self-closing without content) should be avoided. Use the block form instead to provide link text.
+
+## Examples
+
+Examples of **incorrect** code for this rule:
+
+```gjs
+<template>
+  <LinkTo @route="index" />
+</template>
+```
+
+```gjs
+<template>
+  <LinkTo @route="about"></LinkTo>
+</template>
+```
+
+Examples of **correct** code for this rule:
+
+```gjs
+<template>
+  <LinkTo @route="index">Home</LinkTo>
+</template>
+```
+
+```gjs
+<template>
+  <LinkTo @route="about">
+    About Us
+  </LinkTo>
+</template>
+```
+
+## References
+
+- [eslint-plugin-ember template-no-inline-link-to](https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/template-no-inline-link-to.md)

lib/rules/template-no-inline-linkto.js

@@ -0,0 +1,31 @@
+/** @type {import('eslint').Rule.RuleModule} */
+module.exports = {
+  meta: {
+    type: 'suggestion',
+    docs: {
+      description: 'disallow inline form of LinkTo component',
+      category: 'Best Practices',
+      strictGjs: true,
+      strictGts: true,
+      url: 'https://github.com/ember-cli/eslint-plugin-ember/tree/master/docs/rules/template-no-inline-linkto.md',
+    },
+    fixable: null,
+    schema: [],
+    messages: {
+      noInlineLinkTo: 'Use block form of LinkTo component instead of inline form.',
+    },
+  },
+
+  create(context) {
+    return {
+      GlimmerElementNode(node) {
+        if (node.tag === 'LinkTo' && node.children && node.children.length === 0) {
+          context.report({
+            node,
+            messageId: 'noInlineLinkTo',
+          });
+        }
+      },
+    };
+  },
+};

tests/lib/rules/template-no-inline-linkto.js

@@ -0,0 +1,70 @@
+//------------------------------------------------------------------------------
+// Requirements
+//------------------------------------------------------------------------------
+
+const rule = require('../../../lib/rules/template-no-inline-linkto');
+const RuleTester = require('eslint').RuleTester;
+
+//------------------------------------------------------------------------------
+// Tests
+//------------------------------------------------------------------------------
+
+const ruleTester = new RuleTester({
+  parser: require.resolve('ember-eslint-parser'),
+  parserOptions: { ecmaVersion: 2022, sourceType: 'module' },
+});
+
+ruleTester.run('template-no-inline-linkto', rule, {
+  valid: [
+    `<template>
+      <LinkTo @route="index">Home</LinkTo>
+    </template>`,
+    `<template>
+      <LinkTo @route="about">
+        About
+      </LinkTo>
+    </template>`,
+    `<template>
+      <div></div>
+    </template>`,
+  ],
+
+  invalid: [
+    {
+      code: `<template>
+        <LinkTo @route="index" />
+      </template>`,
+      output: null,
+      errors: [
+        {
+          message: 'Use block form of LinkTo component instead of inline form.',
+          type: 'GlimmerElementNode',
+        },
+      ],
+    },
+    {
+      code: `<template>
+        <LinkTo @route="about" />
+      </template>`,
+      output: null,
+      errors: [
+        {
+          message: 'Use block form of LinkTo component instead of inline form.',
+          type: 'GlimmerElementNode',
+        },
+      ],
+    },
+    {
+      code: `<template>
+        <LinkTo @route="contact"></LinkTo>
+      </template>`,
+      output: null,
+      errors: [
+        {
+          message: 'Use block form of LinkTo component instead of inline form.',
+          type: 'GlimmerElementNode',
+        },
+      ],
+    },
+  ],
+});