Skip to content

Commit a6cd56a

Browse files
wagenetclaude
andcommitted
Address PR review feedback
- Remove template-no-deprecated from recommended config snapshot - Revert unrelated semicolon change in recommended-rules.js - Delete docs/arg-deprecation-future-work.md (not part of this PR) - Replace box-drawing characters in test comments with plain ASCII - Revert rule-setup.js filter change (no .ts files in tests/lib/rules/) Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
1 parent 726ec0b commit a6cd56a

5 files changed

Lines changed: 4 additions & 86 deletions

File tree

docs/arg-deprecation-future-work.md

Lines changed: 0 additions & 79 deletions
This file was deleted.

lib/recommended-rules.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,4 +75,4 @@ module.exports = {
7575
"ember/routes-segments-snake-case": "error",
7676
"ember/use-brace-expansion": "error",
7777
"ember/use-ember-data-rfc-395-imports": "error"
78-
};
78+
}

tests/__snapshots__/recommended.js.snap

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ exports[`recommended rules > gjs config has the right list 1`] = `
88

99
exports[`recommended rules > gts config has the right list 1`] = `
1010
[
11-
"template-no-deprecated",
1211
"template-no-let-reference",
1312
]
1413
`;

tests/lib/rules/template-no-deprecated.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ const RuleTester = require('eslint').RuleTester;
66

77
const FIXTURES_DIR = path.join(__dirname, '../rules-preprocessor/template-no-deprecated');
88

9-
// ─── Block 1: No TypeScript project rule is a no-op ───────────────────────
9+
// Block 1: No TypeScript project -- rule is a no-op
1010
// When parserServices.program is absent, the rule returns {} and never reports.
1111

1212
const ruleTester = new RuleTester({
@@ -37,7 +37,7 @@ ruleTester.run('template-no-deprecated', rule, {
3737
invalid: [],
3838
});
3939

40-
// ─── Block 2: TypeScript project full deprecation checking ─────────────────
40+
// Block 2: TypeScript project -- full deprecation checking
4141

4242
const PREPROCESSOR_DIR = path.join(__dirname, '../rules-preprocessor');
4343

tests/rule-setup.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,7 @@ describe('rules setup is correct', function () {
3232
const files = readdirSync(filePath);
3333

3434
expect(RULE_NAMES).toEqual(
35-
files
36-
.filter((file) => !file.startsWith('.') && file.endsWith('.js'))
37-
.map((file) => file.replace('.js', ''))
35+
files.filter((file) => !file.startsWith('.')).map((file) => file.replace('.js', ''))
3836
);
3937
});
4038

0 commit comments

Comments
 (0)