Fix linting issues in template rules - address CI failures

Co-authored-by: NullVoxPopuli <[email protected]>

Author: Copilot

docs/rules/template-deprecated-render-helper.md

@@ -9,11 +9,13 @@ Disallows the {{render}} helper which is deprecated.
 ## Examples
 
 Incorrect:
+
 ```gjs
 <template>{{render "user"}}</template>
 ```
 
 Correct:
+
 ```gjs
 <template><User /></template>
 ```

docs/rules/template-no-forbidden-elements.md

@@ -2,6 +2,10 @@
 
 <!-- end auto-generated rule header -->
 
+## Config
+
+This rule takes an array of element names to forbid.
+
 ## Examples
 
 See ember-template-lint documentation.

lib/rules/template-deprecated-render-helper.js

@@ -13,7 +13,7 @@ module.exports = {
     schema: [],
     messages: {
       deprecated:
-        'The `{{render}}` helper is deprecated in favor of using components. See https://emberjs.com/deprecations/v2.x/#toc_code-render-code-helper',
+        'The render helper is deprecated in favor of using components. See https://emberjs.com/deprecations/v2.x/#toc_code-render-code-helper',
     },
   },
 

lib/rules/template-link-rel-noopener.js

@@ -18,11 +18,17 @@ module.exports = {
   create(context) {
     return {
       GlimmerElementNode(node) {
-        if (node.tag !== 'a') return;
-        
+        if (node.tag !== 'a') {
+          return;
+        }
+
         const targetAttr = node.attributes?.find((a) => a.name === 'target');
-        if (!targetAttr?.value || targetAttr.value.type !== 'GlimmerTextNode') return;
-        if (targetAttr.value.chars !== '_blank') return;
+        if (!targetAttr?.value || targetAttr.value.type !== 'GlimmerTextNode') {
+          return;
+        }
+        if (targetAttr.value.chars !== '_blank') {
+          return;
+        }
 
         const relAttr = node.attributes?.find((a) => a.name === 'rel');
         const hasProperRel =

lib/rules/template-no-abstract-roles.js

@@ -27,7 +27,8 @@ module.exports = {
     fixable: null,
     schema: [],
     messages: {
-      abstractRole: '{{role}} is an abstract role, and is not a valid value for the role attribute.',
+      abstractRole:
+        '{{role}} is an abstract role, and is not a valid value for the role attribute.',
     },
   },
 

lib/rules/template-no-action.js

@@ -1,3 +1,22 @@
+function isActionHelper(node) {
+  if (!node.path || node.path.type !== 'GlimmerPathExpression') {
+    return false;
+  }
+
+  // Check if it's the action helper (not this.action or @action)
+  const path = node.path;
+  if (path.original === 'action') {
+    // Check head.type to avoid deprecated data/this properties
+    const head = path.head;
+    if (head && (head.type === 'AtHead' || head.type === 'ThisHead')) {
+      return false;
+    }
+    return true;
+  }
+
+  return false;
+}
+
 /** @type {import('eslint').Rule.RuleModule} */
 module.exports = {
   meta: {
@@ -12,31 +31,13 @@ module.exports = {
     fixable: null,
     schema: [],
     messages: {
-      subExpression: 'Do not use `action` as (action ...). Instead, use the `on` modifier and `fn` helper.',
-      mustache: 'Do not use `action` as {{action ...}}. Instead, use the `on` modifier and `fn` helper.',
+      subExpression:
+        'Do not use `action` as (action ...). Instead, use the `on` modifier and `fn` helper.',
+      mustache: 'Do not use `action` in templates. Instead, use the `on` modifier and `fn` helper.',
     },
   },
 
   create(context) {
-    function isActionHelper(node) {
-      if (!node.path || node.path.type !== 'GlimmerPathExpression') {
-        return false;
-      }
-
-      // Check if it's the action helper (not this.action or @action)
-      const path = node.path;
-      if (path.original === 'action') {
-        // Check head.type to avoid deprecated data/this properties
-        const head = path.head;
-        if (head && (head.type === 'AtHead' || head.type === 'ThisHead')) {
-          return false;
-        }
-        return true;
-      }
-
-      return false;
-    }
-
     return {
       GlimmerSubExpression(node) {
         if (isActionHelper(node)) {

lib/rules/template-no-duplicate-attributes.js

@@ -40,13 +40,13 @@ module.exports = {
               const text = sourceCode.getText();
               const attrStart = attr.range[0];
               const attrEnd = attr.range[1];
-              
+
               // Look for whitespace before the attribute
               let removeStart = attrStart;
               while (removeStart > 0 && /\s/.test(text[removeStart - 1])) {
                 removeStart--;
               }
-              
+
               return fixer.removeRange([removeStart, attrEnd]);
             },
           });

lib/rules/template-no-input-tagname.js

@@ -14,10 +14,12 @@ module.exports = {
   },
   create(context) {
     function check(node) {
-      if (!node.path) return;
+      if (!node.path) {
+        return;
+      }
       const attrs = node.hash?.pairs || [];
       const hasTagName = attrs.some((a) => a.key === 'tagName');
-      
+
       if (node.path.original === 'input' && hasTagName) {
         context.report({ node, messageId: 'unexpected' });
       } else if (

lib/rules/template-no-obsolete-elements.js

@@ -1,4 +1,33 @@
-const OBSOLETE = ['acronym', 'applet', 'basefont', 'bgsound', 'big', 'blink', 'center', 'dir', 'font', 'frame', 'frameset', 'isindex', 'keygen', 'listing', 'marquee', 'menuitem', 'multicol', 'nextid', 'nobr', 'noembed', 'noframes', 'plaintext', 's', 'spacer', 'strike', 'tt', 'u', 'xmp'];
+const OBSOLETE = [
+  'acronym',
+  'applet',
+  'basefont',
+  'bgsound',
+  'big',
+  'blink',
+  'center',
+  'dir',
+  'font',
+  'frame',
+  'frameset',
+  'isindex',
+  'keygen',
+  'listing',
+  'marquee',
+  'menuitem',
+  'multicol',
+  'nextid',
+  'nobr',
+  'noembed',
+  'noframes',
+  'plaintext',
+  's',
+  'spacer',
+  'strike',
+  'tt',
+  'u',
+  'xmp',
+];
 /** @type {import('eslint').Rule.RuleModule} */
 module.exports = {
   meta: {

lib/rules/template-no-quoteless-attributes.js

@@ -19,10 +19,10 @@ module.exports = {
     return {
       GlimmerAttrNode(node) {
         // Check if attribute has text value without quotes
-        if (node.value?.type === 'GlimmerTextNode' && !node.value.chars.match(/^["']/)) {
+        if (node.value?.type === 'GlimmerTextNode' && !/^["']/.test(node.value.chars)) {
           const sourceCode = context.sourceCode;
           const attrText = sourceCode.getText(node);
-          
+
           // If value looks unquoted (no = or =value without quotes)
           if (/=\s*[^"'{]/.test(attrText)) {
             const type = node.name?.startsWith('@') ? 'Argument' : 'Attribute';