Skip to content

Commit 9ab0e0b

Browse files
Fix CI: prettier formatting, eslint-doc-generator, and README update
- Fix prettier formatting in rule file - Run eslint-doc-generator to update README with new rule entry - Update doc header format to match eslint-doc-generator output Co-authored-by: NullVoxPopuli <[email protected]>
1 parent 5a1e6cb commit 9ab0e0b

3 files changed

Lines changed: 16 additions & 23 deletions

File tree

README.md

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -316,15 +316,16 @@ rules in templates can be disabled with eslint directives with mustache or html
316316

317317
### Ember Object
318318

319-
| Name                                 | Description | 💼 | 🔧 | 💡 |
320-
| :----------------------------------------------------------------------------------------- | :----------------------------------------------------------------------------- | :- | :- | :- |
321-
| [avoid-leaking-state-in-ember-objects](docs/rules/avoid-leaking-state-in-ember-objects.md) | disallow state leakage || | |
322-
| [no-get](docs/rules/no-get.md) | require using ES5 getters instead of Ember's `get` / `getProperties` functions || 🔧 | |
323-
| [no-get-with-default](docs/rules/no-get-with-default.md) | disallow usage of the Ember's `getWithDefault` function || 🔧 | |
324-
| [no-proxies](docs/rules/no-proxies.md) | disallow using array or object proxies | | | |
325-
| [no-try-invoke](docs/rules/no-try-invoke.md) | disallow usage of the Ember's `tryInvoke` util || | |
326-
| [require-super-in-lifecycle-hooks](docs/rules/require-super-in-lifecycle-hooks.md) | require super to be called in lifecycle hooks || 🔧 | |
327-
| [use-ember-get-and-set](docs/rules/use-ember-get-and-set.md) | enforce usage of `Ember.get` and `Ember.set` | | 🔧 | |
319+
| Name                                 | Description | 💼 | 🔧 | 💡 |
320+
| :----------------------------------------------------------------------------------------- | :------------------------------------------------------------------------------------- | :- | :- | :- |
321+
| [avoid-leaking-state-in-ember-objects](docs/rules/avoid-leaking-state-in-ember-objects.md) | disallow state leakage || | |
322+
| [no-get](docs/rules/no-get.md) | require using ES5 getters instead of Ember's `get` / `getProperties` functions || 🔧 | |
323+
| [no-get-with-default](docs/rules/no-get-with-default.md) | disallow usage of the Ember's `getWithDefault` function || 🔧 | |
324+
| [no-modifier-argument-destructuring](docs/rules/no-modifier-argument-destructuring.md) | disallow destructuring of modifier arguments to avoid consuming tracked data too early | | | |
325+
| [no-proxies](docs/rules/no-proxies.md) | disallow using array or object proxies | | | |
326+
| [no-try-invoke](docs/rules/no-try-invoke.md) | disallow usage of the Ember's `tryInvoke` util || | |
327+
| [require-super-in-lifecycle-hooks](docs/rules/require-super-in-lifecycle-hooks.md) | require super to be called in lifecycle hooks || 🔧 | |
328+
| [use-ember-get-and-set](docs/rules/use-ember-get-and-set.md) | enforce usage of `Ember.get` and `Ember.set` | | 🔧 | |
328329

329330
### Ember Octane
330331

docs/rules/no-modifier-argument-destructuring.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1-
# no-modifier-argument-destructuring
1+
# ember/no-modifier-argument-destructuring
2+
3+
<!-- end auto-generated rule header -->
24

35
Disallow destructuring of `modifier` arguments to avoid consuming tracked data too early.
46

lib/rules/no-modifier-argument-destructuring.js

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,7 @@ module.exports = {
3131
return {
3232
ImportDeclaration(node) {
3333
if (node.source.value === 'ember-modifier') {
34-
modifierImportedName ??= getImportIdentifier(
35-
node,
36-
'ember-modifier',
37-
'modifier',
38-
);
34+
modifierImportedName ??= getImportIdentifier(node, 'ember-modifier', 'modifier');
3935
}
4036
},
4137

@@ -44,10 +40,7 @@ module.exports = {
4440
return;
4541
}
4642

47-
if (
48-
node.callee.type !== 'Identifier' ||
49-
node.callee.name !== modifierImportedName
50-
) {
43+
if (node.callee.type !== 'Identifier' || node.callee.name !== modifierImportedName) {
5144
return;
5245
}
5346

@@ -57,10 +50,7 @@ module.exports = {
5750
}
5851

5952
// Support arrow functions and function expressions
60-
if (
61-
callback.type !== 'ArrowFunctionExpression' &&
62-
callback.type !== 'FunctionExpression'
63-
) {
53+
if (callback.type !== 'ArrowFunctionExpression' && callback.type !== 'FunctionExpression') {
6454
return;
6555
}
6656

0 commit comments

Comments
 (0)