Merge pull request #2549 from johanrd/issue/1218-test-file-false-positive

[BUGFIX]: `no-test-import-export` false positive on non-test files ending in -test

Author: NullVoxPopuli

lib/rules/no-test-import-export.js

@@ -31,6 +31,7 @@ module.exports = {
     const noExports = function (node) {
       if (
         !emberUtils.isTestFile(context.getFilename()) ||
+        !isInTestDirectory(context.getFilename()) ||
         isTestHelperFilename(context.getFilename())
       ) {
         return;
@@ -67,6 +68,15 @@ module.exports = {
   },
 };
 
+function isInTestDirectory(filename) {
+  const filenameParts = path.normalize(filename).split(path.sep);
+  const testDirIndex = filenameParts.findIndex((part) => part === 'tests' || part === 'test');
+  // tests/ or test/ must be a top-level directory (index 0) or directly under
+  // a project name (index 1, e.g. my-app/tests/). Deeper nesting like
+  // app/components/tests/ is not a real test directory.
+  return testDirIndex >= 0 && testDirIndex <= 1;
+}
+
 function isTestHelperFilename(filename) {
   const filenameParts = path.normalize(filename).split(path.sep);
   for (let i = 0; i < filenameParts.length - 1; ++i) {

tests/lib/rules/no-test-import-export.js

@@ -58,6 +58,17 @@ ruleTester.run('no-test-import-export', rule, {
     // Package imports ending in -test should not be flagged
     "import { expectTypeOf } from '@glint/type-test';",
     "import something from 'some-package-test';",
+
+    // Files ending in -test outside tests/ directory should not be treated as test files (#1218)
+    {
+      filename: 'app/components/student-test.js',
+      code: 'export function setup() {}',
+    },
+    // A tests/ folder inside app/ is not a real test directory
+    {
+      filename: 'app/components/tests/foo-test.js',
+      code: 'export function setup() {}',
+    },
   ],
   invalid: [
     {