Merge pull request #2528 from johanrd/review/no-action-on-submit-button

Skip reporting for <form method="dialog"> submit buttons

Author: NullVoxPopuli

lib/rules/template-no-action-on-submit-button.js

@@ -2,6 +2,17 @@ function isInsideForm(node) {
   let current = node.parent;
   while (current) {
     if (current.type === 'GlimmerElementNode' && current.tag === 'form') {
+      // <form method="dialog"> closes the dialog on submit without navigating,
+      // so click handlers on submit buttons are intentional and correct.
+      // See https://github.com/ember-template-lint/ember-template-lint/issues/2989
+      const methodAttr = current.attributes?.find((a) => a.name === 'method');
+      if (
+        methodAttr &&
+        methodAttr.value?.type === 'GlimmerTextNode' &&
+        methodAttr.value.chars.toLowerCase() === 'dialog'
+      ) {
+        return false;
+      }
       return true;
     }
     current = current.parent;

tests/lib/rules/template-no-action-on-submit-button.js

@@ -28,6 +28,11 @@ ruleTester.run('template-no-action-on-submit-button', rule, {
     '<template><form><div type="submit"></div></form></template>',
     '<template><form><div type="submit" {{action this.handleClick}}></div></form></template>',
     '<template><form><div type="submit" {{on "click" this.handleClick}}></div></form></template>',
+    // <form method="dialog"> — click handlers are intentional (closes dialog)
+    // https://github.com/ember-template-lint/ember-template-lint/issues/2989
+    '<template><form method="dialog"><button type="submit" {{on "click" this.handleClick}} /></form></template>',
+    '<template><form method="dialog"><button {{action this.handleClick}} /></form></template>',
+    '<template><form method="DIALOG"><button type="submit" {{on "click" this.handleClick}} /></form></template>',
     // Outside a form — valid
     '<template><button {{action this.handleClick}} /></template>',
     '<template><button {{action this.handleClick on="click"}}/></template>',
@@ -110,6 +115,9 @@ hbsRuleTester.run('template-no-action-on-submit-button (hbs)', rule, {
     '<form><div type="submit"></div></form>',
     '<form><div type="submit" {{action this.handleClick}}></div></form>',
     '<form><div type="submit" {{on "click" this.handleClick}}></div></form>',
+    // <form method="dialog"> — click handlers are intentional
+    '<form method="dialog"><button type="submit" {{on "click" this.handleClick}} /></form>',
+    '<form method="dialog"><button {{action this.handleClick}} /></form>',
     // Outside a form — valid
     '<button {{action this.handleClick}} />',
     '<button {{action this.handleClick on="click"}}/>',