Fix no-tracked-properties-from-args crash on method calls

nodeToDependentKey returned non-string values for call expressions
like this.array.indexOf(1). Use isThisGetCall to only extract the
dependent key from this.get('property') calls.

Fixes #2281

Author: johanrd

lib/utils/property-getter.js

@@ -83,12 +83,12 @@ function isSimpleThisExpression(node) {
  */
 function nodeToDependentKey(nodeWithThisExpression, context) {
   if (types.isCallExpression(nodeWithThisExpression)) {
-    if (nodeWithThisExpression.arguments[0]) {
+    if (isThisGetCall(nodeWithThisExpression)) {
       // Looks like: this.get('property')
       return nodeWithThisExpression.arguments[0].value;
     }
 
-    // Looks like: this.someMethod()
+    // Looks like: this.someMethod() or this.foo.bar(1)
     return undefined;
   }
 

tests/lib/rules/no-tracked-properties-from-args.js

@@ -81,6 +81,14 @@ ruleTester.run('no-tracked-properties-from-args', rule, {
         someProperty = this.someMethod();
       }
     `,
+    // Should not crash on method calls with non-string arguments
+    `
+      import { tracked } from '@glimmer/tracking';
+
+      class Test {
+        @tracked test = this.array.indexOf(1);
+      }
+    `,
   ],
   invalid: [
     {