Only export isEmberSourceVersionAtLeast from ember-source-version utility

Co-authored-by: NullVoxPopuli <[email protected]>

Author: Copilot

lib/utils/ember-source-version.js

@@ -59,7 +59,5 @@ function isEmberSourceVersionAtLeast(major, minor, projectRoot) {
 }
 
 module.exports = {
-  getEmberSourceVersion,
-  isVersionAtLeast,
   isEmberSourceVersionAtLeast,
 };

tests/lib/utils/ember-source-version-test.js

@@ -3,72 +3,10 @@
 const fs = require('node:fs');
 const os = require('node:os');
 const path = require('node:path');
-const {
-  getEmberSourceVersion,
-  isVersionAtLeast,
-  isEmberSourceVersionAtLeast,
-} = require('../../../lib/utils/ember-source-version');
+const { isEmberSourceVersionAtLeast } = require('../../../lib/utils/ember-source-version');
 
 describe('ember-source-version', () => {
-  describe('isVersionAtLeast', () => {
-    it('returns true when major version is greater', () => {
-      expect(isVersionAtLeast('7.0.0', 6, 8)).toBe(true);
-    });
-
-    it('returns true when major matches and minor is greater', () => {
-      expect(isVersionAtLeast('6.10.0', 6, 8)).toBe(true);
-    });
-
-    it('returns true when major and minor match exactly', () => {
-      expect(isVersionAtLeast('6.8.0', 6, 8)).toBe(true);
-    });
-
-    it('returns true when major and minor match with patch version', () => {
-      expect(isVersionAtLeast('6.8.3', 6, 8)).toBe(true);
-    });
-
-    it('returns false when major matches but minor is less', () => {
-      expect(isVersionAtLeast('6.7.0', 6, 8)).toBe(false);
-    });
-
-    it('returns false when major is less', () => {
-      expect(isVersionAtLeast('5.12.0', 6, 8)).toBe(false);
-    });
-
-    it('returns false for null', () => {
-      expect(isVersionAtLeast(null, 6, 8)).toBe(false);
-    });
-
-    it('returns false for undefined', () => {
-      expect(isVersionAtLeast(undefined, 6, 8)).toBe(false);
-    });
-
-    it('returns false for empty string', () => {
-      expect(isVersionAtLeast('', 6, 8)).toBe(false);
-    });
-
-    it('returns false for non-string input', () => {
-      expect(isVersionAtLeast(123, 6, 8)).toBe(false);
-    });
-
-    it('returns false for invalid version string', () => {
-      expect(isVersionAtLeast('invalid', 6, 8)).toBe(false);
-    });
-
-    it('handles pre-release versions', () => {
-      expect(isVersionAtLeast('6.8.0-beta.1', 6, 8)).toBe(true);
-    });
-
-    it('handles two-part version strings', () => {
-      expect(isVersionAtLeast('6.8', 6, 8)).toBe(true);
-    });
-
-    it('checks against 0.0 minimum', () => {
-      expect(isVersionAtLeast('0.0.1', 0, 0)).toBe(true);
-    });
-  });
-
-  describe('getEmberSourceVersion', () => {
+  describe('isEmberSourceVersionAtLeast', () => {
     let tmpDir;
 
     beforeEach(() => {
@@ -79,80 +17,67 @@ describe('ember-source-version', () => {
       fs.rmSync(tmpDir, { recursive: true });
     });
 
-    it('returns null when ember-source is not installed', () => {
-      expect(getEmberSourceVersion(tmpDir)).toBeNull();
-    });
-
-    it('returns the version when ember-source is installed', () => {
+    it('returns true when installed version meets the requirement', () => {
       const emberSourceDir = path.join(tmpDir, 'node_modules', 'ember-source');
       fs.mkdirSync(emberSourceDir, { recursive: true });
       fs.writeFileSync(
         path.join(emberSourceDir, 'package.json'),
         JSON.stringify({ name: 'ember-source', version: '6.8.0' })
       );
 
-      expect(getEmberSourceVersion(tmpDir)).toBe('6.8.0');
+      expect(isEmberSourceVersionAtLeast(6, 8, tmpDir)).toBe(true);
     });
 
-    it('returns null when package.json has no version field', () => {
+    it('returns true when installed version exceeds the requirement', () => {
       const emberSourceDir = path.join(tmpDir, 'node_modules', 'ember-source');
       fs.mkdirSync(emberSourceDir, { recursive: true });
       fs.writeFileSync(
         path.join(emberSourceDir, 'package.json'),
-        JSON.stringify({ name: 'ember-source' })
+        JSON.stringify({ name: 'ember-source', version: '7.0.0' })
       );
 
-      expect(getEmberSourceVersion(tmpDir)).toBeNull();
+      expect(isEmberSourceVersionAtLeast(6, 8, tmpDir)).toBe(true);
     });
 
-    it('returns null when package.json is malformed', () => {
+    it('returns true when major version is greater', () => {
       const emberSourceDir = path.join(tmpDir, 'node_modules', 'ember-source');
       fs.mkdirSync(emberSourceDir, { recursive: true });
-      fs.writeFileSync(path.join(emberSourceDir, 'package.json'), 'not json');
+      fs.writeFileSync(
+        path.join(emberSourceDir, 'package.json'),
+        JSON.stringify({ name: 'ember-source', version: '7.0.0' })
+      );
 
-      expect(getEmberSourceVersion(tmpDir)).toBeNull();
+      expect(isEmberSourceVersionAtLeast(6, 8, tmpDir)).toBe(true);
     });
 
-    it('handles pre-release versions', () => {
+    it('returns true when major matches and minor is greater', () => {
       const emberSourceDir = path.join(tmpDir, 'node_modules', 'ember-source');
       fs.mkdirSync(emberSourceDir, { recursive: true });
       fs.writeFileSync(
         path.join(emberSourceDir, 'package.json'),
-        JSON.stringify({ name: 'ember-source', version: '7.0.0-beta.1' })
+        JSON.stringify({ name: 'ember-source', version: '6.10.0' })
       );
 
-      expect(getEmberSourceVersion(tmpDir)).toBe('7.0.0-beta.1');
-    });
-  });
-
-  describe('isEmberSourceVersionAtLeast', () => {
-    let tmpDir;
-
-    beforeEach(() => {
-      tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'eslint-plugin-ember-'));
-    });
-
-    afterEach(() => {
-      fs.rmSync(tmpDir, { recursive: true });
+      expect(isEmberSourceVersionAtLeast(6, 8, tmpDir)).toBe(true);
     });
 
-    it('returns true when installed version meets the requirement', () => {
+    it('returns true with patch version', () => {
       const emberSourceDir = path.join(tmpDir, 'node_modules', 'ember-source');
       fs.mkdirSync(emberSourceDir, { recursive: true });
       fs.writeFileSync(
         path.join(emberSourceDir, 'package.json'),
-        JSON.stringify({ name: 'ember-source', version: '6.8.0' })
+        JSON.stringify({ name: 'ember-source', version: '6.8.3' })
       );
 
       expect(isEmberSourceVersionAtLeast(6, 8, tmpDir)).toBe(true);
     });
 
-    it('returns true when installed version exceeds the requirement', () => {
+    it('returns true with pre-release version that meets requirement', () => {
       const emberSourceDir = path.join(tmpDir, 'node_modules', 'ember-source');
       fs.mkdirSync(emberSourceDir, { recursive: true });
       fs.writeFileSync(
         path.join(emberSourceDir, 'package.json'),
-        JSON.stringify({ name: 'ember-source', version: '7.0.0' })
+        JSON.stringify({ name: 'ember-source', version: '6.8.0-beta.1' })
       );
 
       expect(isEmberSourceVersionAtLeast(6, 8, tmpDir)).toBe(true);
@@ -169,8 +94,38 @@ describe('ember-source-version', () => {
       expect(isEmberSourceVersionAtLeast(6, 8, tmpDir)).toBe(false);
     });
 
+    it('returns false when major is less', () => {
+      const emberSourceDir = path.join(tmpDir, 'node_modules', 'ember-source');
+      fs.mkdirSync(emberSourceDir, { recursive: true });
+      fs.writeFileSync(
+        path.join(emberSourceDir, 'package.json'),
+        JSON.stringify({ name: 'ember-source', version: '5.12.0' })
+      );
+
+      expect(isEmberSourceVersionAtLeast(6, 8, tmpDir)).toBe(false);
+    });
+
     it('returns false when ember-source is not installed', () => {
       expect(isEmberSourceVersionAtLeast(6, 8, tmpDir)).toBe(false);
     });
+
+    it('returns false when package.json has no version field', () => {
+      const emberSourceDir = path.join(tmpDir, 'node_modules', 'ember-source');
+      fs.mkdirSync(emberSourceDir, { recursive: true });
+      fs.writeFileSync(
+        path.join(emberSourceDir, 'package.json'),
+        JSON.stringify({ name: 'ember-source' })
+      );
+
+      expect(isEmberSourceVersionAtLeast(6, 8, tmpDir)).toBe(false);
+    });
+
+    it('returns false when package.json is malformed', () => {
+      const emberSourceDir = path.join(tmpDir, 'node_modules', 'ember-source');
+      fs.mkdirSync(emberSourceDir, { recursive: true });
+      fs.writeFileSync(path.join(emberSourceDir, 'package.json'), 'not json');
+
+      expect(isEmberSourceVersionAtLeast(6, 8, tmpDir)).toBe(false);
+    });
   });
 });