Extract rule: template-no-form-action

Author: NullVoxPopuli

README.md

@@ -266,6 +266,7 @@ rules in templates can be disabled with eslint directives with mustache or html
 | [no-string-prototype-extensions](docs/rules/no-string-prototype-extensions.md)                   | disallow usage of `String` prototype extensions           | ✅  |    |    |
 | [template-no-action](docs/rules/template-no-action.md)                                           | disallow {{action}} helper                                |    |    |    |
 | [template-no-attrs-in-components](docs/rules/template-no-attrs-in-components.md)                 | disallow attrs in component templates                     |    |    |    |
+| [template-no-form-action](docs/rules/template-no-form-action.md)                                 | disallow usage of action attribute on form elements       |    |    |    |
 
 ### Ember Data
 

docs/rules/template-no-form-action.md

@@ -0,0 +1,68 @@
+# ember/template-no-form-action
+
+<!-- end auto-generated rule header -->
+
+Disallows the use of the `action` attribute on form elements.
+
+In modern Ember applications, form submissions should be handled using the `{{on}}` modifier with the `"submit"` event instead of the `action` attribute. This provides better control and follows modern Ember patterns.
+
+## Rule Details
+
+This rule disallows the use of the `action` attribute on `<form>` elements.
+
+## Examples
+
+Examples of **incorrect** code for this rule:
+
+```gjs
+<template>
+  <form action="/submit">
+    <input type="text" />
+  </form>
+</template>
+```
+
+```gjs
+<template>
+  <form action="">
+    <button>Submit</button>
+  </form>
+</template>
+```
+
+Examples of **correct** code for this rule:
+
+```gjs
+<template>
+  <form {{on "submit" this.handleSubmit}}>
+    <input type="text" />
+  </form>
+</template>
+```
+
+```gjs
+<template>
+  <form>
+    <button type="submit">Submit</button>
+  </form>
+</template>
+```
+
+## Migration
+
+Replace:
+
+```gjs
+<form action="/submit">
+```
+
+With:
+
+```gjs
+<form {{on "submit" this.handleSubmit}}>
+```
+
+## References
+
+- [eslint-plugin-ember template-no-form-action](https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/template-no-form-action.md)
+- [Ember.js Guides - Event Handling](https://guides.emberjs.com/release/components/component-state-and-actions/)

lib/rules/template-no-form-action.js

@@ -0,0 +1,37 @@
+/** @type {import('eslint').Rule.RuleModule} */
+module.exports = {
+  meta: {
+    type: 'problem',
+    docs: {
+      description: 'disallow usage of action attribute on form elements',
+      category: 'Deprecations',
+      strictGjs: true,
+      strictGts: true,
+      url: 'https://github.com/ember-cli/eslint-plugin-ember/tree/master/docs/rules/template-no-form-action.md',
+    },
+    fixable: null,
+    schema: [],
+    messages: {
+      unexpected:
+        'Do not use the action attribute on <form> elements. Use the (on) modifier with the "submit" event instead.',
+    },
+  },
+
+  create(context) {
+    return {
+      GlimmerElementNode(node) {
+        if (node.tag !== 'form') {
+          return;
+        }
+
+        const actionAttr = node.attributes?.find((a) => a.name === 'action');
+        if (actionAttr) {
+          context.report({
+            node: actionAttr,
+            messageId: 'unexpected',
+          });
+        }
+      },
+    };
+  },
+};

tests/lib/rules/template-no-form-action.js

@@ -0,0 +1,66 @@
+//------------------------------------------------------------------------------
+// Requirements
+//------------------------------------------------------------------------------
+
+const rule = require('../../../lib/rules/template-no-form-action');
+const RuleTester = require('eslint').RuleTester;
+
+//------------------------------------------------------------------------------
+// Tests
+//------------------------------------------------------------------------------
+
+const ruleTester = new RuleTester({
+  parser: require.resolve('ember-eslint-parser'),
+  parserOptions: { ecmaVersion: 2022, sourceType: 'module' },
+});
+
+ruleTester.run('template-no-form-action', rule, {
+  valid: [
+    `<template>
+      <form {{on "submit" this.handleSubmit}}>
+        <input type="text" />
+      </form>
+    </template>`,
+    `<template>
+      <form>
+        <button type="submit">Submit</button>
+      </form>
+    </template>`,
+    `<template>
+      <div action="some-action">Not a form</div>
+    </template>`,
+  ],
+
+  invalid: [
+    {
+      code: `<template>
+        <form action="/submit">
+          <input type="text" />
+        </form>
+      </template>`,
+      output: null,
+      errors: [
+        {
+          message:
+            'Do not use the action attribute on <form> elements. Use the (on) modifier with the "submit" event instead.',
+          type: 'GlimmerAttrNode',
+        },
+      ],
+    },
+    {
+      code: `<template>
+        <form action="">
+          <button>Submit</button>
+        </form>
+      </template>`,
+      output: null,
+      errors: [
+        {
+          message:
+            'Do not use the action attribute on <form> elements. Use the (on) modifier with the "submit" event instead.',
+          type: 'GlimmerAttrNode',
+        },
+      ],
+    },
+  ],
+});