fix: sourceCode fallback + name-based scope-ref compare + soften size assertion (Copilot review)

Author: johanrd

lib/rules/template-no-empty-headings.js

@@ -97,7 +97,9 @@ module.exports = {
     },
   },
   create(context) {
-    const sourceCode = context.sourceCode;
+    // `context.sourceCode` is the ESLint >= 8.40 shape; `context.getSourceCode()`
+    // covers older versions. Keep both for cross-version compatibility.
+    const sourceCode = context.sourceCode || context.getSourceCode();
     return {
       GlimmerElementNode(node) {
         if (isHeadingElement(node)) {

lib/rules/template-no-invalid-interactive.js

@@ -67,7 +67,9 @@ module.exports = {
   },
 
   create(context) {
-    const sourceCode = context.sourceCode;
+    // `context.sourceCode` is the ESLint >= 8.40 shape; `context.getSourceCode()`
+    // covers older versions. Keep both for cross-version compatibility.
+    const sourceCode = context.sourceCode || context.getSourceCode();
     const options = context.options[0] || {};
     const additionalInteractiveTags = new Set(options.additionalInteractiveTags || []);
     const ignoredTags = new Set(options.ignoredTags || []);

lib/utils/is-native-element.js

@@ -60,7 +60,11 @@ function isNativeElement(node, sourceCode) {
   }
   const scope = sourceCode.getScope(node.parent);
   const firstPart = node.parts && node.parts[0];
-  if (firstPart && scope.references.some((ref) => ref.identifier === firstPart)) {
+  // Compare by identifier name rather than AST node object identity — object
+  // identity isn't guaranteed across parser versions (ember-eslint-parser can
+  // produce distinct node objects for the same token depending on how the
+  // scope manager walks the tree), but the resolved `.name` is stable.
+  if (firstPart && scope.references.some((ref) => ref.identifier?.name === firstPart?.name)) {
     return false;
   }
   return true;

tests/lib/utils/is-native-element-test.js

@@ -81,9 +81,12 @@ describe('isNativeElement — list-only behavior (no sourceCode)', () => {
 
 describe('ELEMENT_TAGS', () => {
   it('includes all HTML, SVG, and MathML tag names', () => {
-    // Sanity check — if this ever drops below a reasonable size, one of the
-    // underlying packages has changed contract.
-    expect(ELEMENT_TAGS.size).toBeGreaterThan(200);
+    // Contract check — the set must be non-empty and must contain at least
+    // one representative tag from each of the three source packages. An exact
+    // size assertion would be brittle (the underlying packages add/remove tags
+    // across minor releases without changing their contract), so we assert the
+    // shape instead.
+    expect(ELEMENT_TAGS.size).toBeGreaterThan(0);
     expect(ELEMENT_TAGS.has('div')).toBe(true);
     expect(ELEMENT_TAGS.has('circle')).toBe(true);
     expect(ELEMENT_TAGS.has('mfrac')).toBe(true);