lint:fix

Author: NullVoxPopuli

README.md

@@ -40,17 +40,17 @@ module.exports = {
           context.report({
             node: targetAttr,
             messageId: 'missingRel',
-            fix: !relAttr
-              ? (fixer) => {
+            fix: relAttr
+              ? undefined
+              : (fixer) => {
                   const sourceCode = context.sourceCode;
                   const openTag = sourceCode.getText(node).match(/^<a[^>]*/)[0];
                   const insertPos = node.range[0] + openTag.length;
                   return fixer.insertTextBeforeRange(
                     [insertPos, insertPos],
                     ' rel="noopener noreferrer"'
                   );
-                }
-              : undefined,
+                },
           });
         }
       },

lib/rules/template-link-rel-noopener.js

@@ -15,6 +15,11 @@ module.exports = {
       noAutofocus:
         'Avoid using autofocus attribute. Autofocusing elements can cause usability issues for sighted and non-sighted users.',
     },
+    originallyFrom: {
+      rule: 'ember-template-lint/lib/rules/no-autofocus-attribute',
+      docs: 'ember-template-lint/docs/rules/no-autofocus-attribute.md',
+      tests: 'ember-template-lint/tests/lib/rules/no-autofocus-attribute.js',
+    },
   },
 
   create(context) {

lib/rules/template-no-autofocus-attribute.js

@@ -30,24 +30,24 @@ module.exports = {
 
     function isLocal(name) {
       for (const scope of localScopes) {
-        if (scope.has(name)) return true;
+        if (scope.has(name)) {return true;}
       }
       return false;
     }
 
     function isDynamicPath(path) {
-      if (!path || path.type !== 'GlimmerPathExpression') return false;
-      if (path.head?.type === 'AtHead') return true;
-      if (path.head?.type === 'ThisHead') return true;
-      if (path.original && path.original.includes('.')) return true;
-      if (path.original && isLocal(path.original)) return true;
+      if (!path || path.type !== 'GlimmerPathExpression') {return false;}
+      if (path.head?.type === 'AtHead') {return true;}
+      if (path.head?.type === 'ThisHead') {return true;}
+      if (path.original && path.original.includes('.')) {return true;}
+      if (path.original && isLocal(path.original)) {return true;}
       return false;
     }
 
     function isInAttrPosition(node) {
       let p = node.parent;
       while (p) {
-        if (p.type === 'GlimmerAttrNode') return true;
+        if (p.type === 'GlimmerAttrNode') {return true;}
         if (p.type === 'GlimmerConcatStatement') {
           p = p.parent;
           continue;

lib/rules/template-no-dynamic-subexpression-invocations.js

@@ -42,7 +42,7 @@ module.exports = {
       },
 
       'GlimmerElementNode:exit'(node) {
-        if (splattributesStack.length > 0 && splattributesStack[splattributesStack.length - 1] === node) {
+        if (splattributesStack.length > 0 && splattributesStack.at(-1) === node) {
           splattributesStack.pop();
         }
       },

lib/rules/template-no-nested-splattributes.js

@@ -142,7 +142,7 @@ module.exports = {
 
     function isLocal(name) {
       for (const scope of blockParamScope) {
-        if (scope.has(name)) return true;
+        if (scope.has(name)) {return true;}
       }
       return false;
     }
@@ -166,7 +166,7 @@ module.exports = {
         }
 
         const tag = node.tag;
-        if (!tag) return;
+        if (!tag) {return;}
 
         const firstChar = tag.charAt(0);
         const startsWithUpperCase =

lib/rules/template-no-shadowed-elements.js

@@ -40,7 +40,7 @@ module.exports = {
     }
 
     function isCustomComponent(tag) {
-      if (!tag) return false;
+      if (!tag) {return false;}
       // PascalCase or dotted path → custom component
       return /^[A-Z]/.test(tag) || tag.includes('.');
     }

lib/rules/template-require-aria-activedescendant-tabindex.js

@@ -46,10 +46,10 @@ module.exports = {
               } else {
                 // Check for duplicate titles
                 const existingIdx = knownTitles.findIndex(([val]) => val === value);
-                if (existingIdx !== -1) {
-                  context.report({ node, messageId: 'missingTitle' });
-                } else {
+                if (existingIdx === -1) {
                   knownTitles.push([value, node]);
+                } else {
+                  context.report({ node, messageId: 'missingTitle' });
                 }
               }
               break;
@@ -73,8 +73,9 @@ module.exports = {
               }
               break;
             }
-            default:
+            default: {
               break;
+            }
           }
         }
       },