Skip to content

Commit 6cd538d

Browse files
Merge pull request #2544 from johanrd/issue/1488-no-empty-glimmer-declare-class
[BUGFIX]: `no-empty-glimmer-component-classes` false positive on `declare class`
2 parents f77f9ad + caae2ed commit 6cd538d

2 files changed

Lines changed: 10 additions & 1 deletion

File tree

lib/rules/no-empty-glimmer-component-classes.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ module.exports = {
3030
create(context) {
3131
return {
3232
ClassDeclaration(node) {
33-
if (!isGlimmerComponent(context, node)) {
33+
if (node.declare || !isGlimmerComponent(context, node)) {
3434
return;
3535
}
3636

tests/lib/rules/no-empty-glimmer-component-classes.js

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,15 @@ ruleTester.run('no-empty-glimmer-component-classes', rule, {
7979
`,
8080
parser: require.resolve('@typescript-eslint/parser'),
8181
},
82+
// TypeScript declare class should not be flagged
83+
{
84+
code: `
85+
import Component from '@glimmer/component';
86+
87+
declare class MyComponent extends Component<Sig> {}
88+
`,
89+
parser: require.resolve('@typescript-eslint/parser'),
90+
},
8291
],
8392
invalid: [
8493
{

0 commit comments

Comments
 (0)