Fix code review issues: attribute-splat logic, remove LinkTo conflict, simplify index check

Co-authored-by: NullVoxPopuli <[email protected]>

Author: Copilot

docs/rules/template-no-builtin-form-components.md

@@ -8,7 +8,7 @@ Disallows usage of built-in form components.
 
 ## Rule Details
 
-Built-in Ember components like `<Input>`, `<Textarea>`, and `<LinkTo>` should be replaced with native HTML elements for better performance and simpler code.
+Built-in Ember components like `<Input>` and `<Textarea>` should be replaced with native HTML elements for better performance and simpler code.
 
 ## Examples
 

docs/rules/template-no-index-component-invocation.md

@@ -16,13 +16,13 @@ Examples of **incorrect** code for this rule:
 
 ```gjs
 <template>
-  <MyComponent/index />
+  <MyComponent::Index />
 </template>
 ```
 
 ```gjs
 <template>
-  <Foo/index />
+  <Foo::Index />
 </template>
 ```
 

lib/rules/template-no-attribute-splat-on-html-element.js

@@ -20,14 +20,16 @@ module.exports = {
   create(context) {
     return {
       GlimmerElementNode(node) {
-        // Check if it's an HTML element (lowercase tag)
-        if (node.tag && node.tag[0] === node.tag[0].toLowerCase() && node.attributes) {
-          for (const attr of node.attributes) {
-            if (attr.name === '...attributes') {
-              context.report({
-                node: attr,
-                messageId: 'noAttributeSplat',
-              });
+        // Check if it's an HTML element (starts with lowercase letter)
+        if (node.tag && node.tag.length > 0 && node.tag[0] === node.tag[0].toLowerCase()) {
+          if (node.attributes) {
+            for (const attr of node.attributes) {
+              if (attr.name === '...attributes') {
+                context.report({
+                  node: attr,
+                  messageId: 'noAttributeSplat',
+                });
+              }
             }
           }
         }

lib/rules/template-no-builtin-form-components.js

@@ -18,7 +18,7 @@ module.exports = {
   },
 
   create(context) {
-    const BUILTIN_FORM_COMPONENTS = new Set(['Input', 'Textarea', 'LinkTo']);
+    const BUILTIN_FORM_COMPONENTS = new Set(['Input', 'Textarea']);
 
     return {
       GlimmerElementNode(node) {

lib/rules/template-no-index-component-invocation.js

@@ -21,8 +21,8 @@ module.exports = {
     return {
       GlimmerElementNode(node) {
         if (node.tag && typeof node.tag === 'string') {
-          // Check if tag ends with ::Index (case-insensitive to catch Index, index, INDEX)
-          if (node.tag.endsWith('::Index') || /::index$/i.test(node.tag)) {
+          // Check if tag ends with ::Index (case-insensitive)
+          if (/::index$/i.test(node.tag)) {
             context.report({
               node,
               messageId: 'noIndexInvocation',

tests/lib/rules/template-no-builtin-form-components.js

@@ -52,17 +52,5 @@ ruleTester.run('template-no-builtin-form-components', rule, {
         },
       ],
     },
-    {
-      code: `<template>
-        <LinkTo @route="index">Home</LinkTo>
-      </template>`,
-      output: null,
-      errors: [
-        {
-          message: 'Do not use built-in form components. Use native HTML elements instead.',
-          type: 'GlimmerElementNode',
-        },
-      ],
-    },
   ],
 });