Sync with ember-template-lint

Author: NullVoxPopuli

lib/rules/template-no-unknown-arguments-for-builtin-components.js

@@ -337,14 +337,58 @@ function getErrorMessage(tagName, argumentName) {
   return `"${argumentName}" is unknown argument for <${tagName} /> component.`;
 }
 
+function checkConflicts(nodeMeta, node, seen, context) {
+  if (!nodeMeta.conflicts) {
+    return;
+  }
+  for (const conflictList of nodeMeta.conflicts) {
+    if (conflictList.every((item) => seen.includes(item))) {
+      for (const argName of conflictList) {
+        const attr = node.attributes.find(({ name }) => `@${argName}` === name);
+        if (attr) {
+          const conflictsWith = conflictList
+            .filter((el) => `@${el}` !== attr.name)
+            .map((el) => `"@${el}"`)
+            .join(', ');
+          context.report({
+            node: attr,
+            messageId: 'conflictArgument',
+            data: {
+              message: `"${attr.name}" conflicts with ${conflictsWith}, only one should exist.`,
+            },
+          });
+        }
+      }
+    }
+  }
+}
+
+function checkRequired(nodeMeta, node, seen, context) {
+  if (!nodeMeta.required) {
+    return;
+  }
+  for (const requiredItems of nodeMeta.required) {
+    const variants = Array.isArray(requiredItems) ? requiredItems : [requiredItems];
+    if (!variants.some((el) => seen.includes(el))) {
+      const argNames = variants.map((el) => `"@${el}"`).join(' or ');
+      context.report({
+        node,
+        messageId: 'requiredArgument',
+        data: {
+          message: `Argument${variants.length > 1 ? 's' : ''} ${argNames} is required for <${node.tag} /> component.`,
+        },
+      });
+    }
+  }
+}
+
 /** @type {import('eslint').Rule.RuleModule} */
 module.exports = {
   meta: {
     type: 'problem',
     docs: {
       description: 'disallow unknown arguments for built-in components',
       category: 'Possible Errors',
-      recommended: false,
       url: 'https://github.com/ember-cli/eslint-plugin-ember/tree/master/docs/rules/template-no-unknown-arguments-for-builtin-components.md',
       templateMode: 'both',
     },
@@ -416,46 +460,8 @@ module.exports = {
           });
         }
 
-        // Check conflicts
-        if (nodeMeta.conflicts) {
-          for (const conflictList of nodeMeta.conflicts) {
-            if (conflictList.every((item) => seen.includes(item))) {
-              for (const argName of conflictList) {
-                const attr = node.attributes.find(({ name }) => `@${argName}` === name);
-                if (attr) {
-                  const conflictsWith = conflictList
-                    .filter((el) => `@${el}` !== attr.name)
-                    .map((el) => `"@${el}"`)
-                    .join(', ');
-                  context.report({
-                    node: attr,
-                    messageId: 'conflictArgument',
-                    data: {
-                      message: `"${attr.name}" conflicts with ${conflictsWith}, only one should exist.`,
-                    },
-                  });
-                }
-              }
-            }
-          }
-        }
-
-        // Check required arguments
-        if (nodeMeta.required) {
-          for (const requiredItems of nodeMeta.required) {
-            const variants = Array.isArray(requiredItems) ? requiredItems : [requiredItems];
-            if (!variants.some((el) => seen.includes(el))) {
-              const argNames = variants.map((el) => `"@${el}"`).join(' or ');
-              context.report({
-                node,
-                messageId: 'requiredArgument',
-                data: {
-                  message: `Argument${variants.length > 1 ? 's' : ''} ${argNames} is required for <${node.tag} /> component.`,
-                },
-              });
-            }
-          }
-        }
+        checkConflicts(nodeMeta, node, seen, context);
+        checkRequired(nodeMeta, node, seen, context);
       },
     };
   },