Skip to content

Commit 5619538

Browse files
committed
cleanup redundant upstream comments
1 parent eb5b7d1 commit 5619538

11 files changed

Lines changed: 1 addition & 14 deletions

lib/rules/template-link-rel-noopener.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ module.exports = {
4242
fix(fixer) {
4343
if (relAttr && relAttr.value?.type === 'GlimmerTextNode') {
4444
// Strip existing noopener/noreferrer tokens, then re-add in canonical order
45-
// (matches ember-template-lint behavior)
4645
const oldValue = relAttr.value.chars.trim().replaceAll(/\s+/g, ' ');
4746
const filtered = oldValue
4847
.split(' ')

lib/rules/template-no-curly-component-invocation.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,6 @@ module.exports = {
126126

127127
/**
128128
* Build a fix function for block statement curly→angle bracket conversion.
129-
* Matches ember-template-lint's fixForBlockNode behavior.
130129
*/
131130
function buildBlockFix(node, angleBracketName) {
132131
return function fix(fixer) {

lib/rules/template-require-context-role.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ function hasAriaHiddenTrue(node) {
100100
* layer. Returns { ariaHidden, role } where:
101101
* - `ariaHidden` is true if aria-hidden="true" was seen on any traversed
102102
* element (including transparent wrappers) up to and including the first
103-
* non-transparent parent — matches upstream's semantics.
103+
* non-transparent parent.
104104
* - `role` is the role of the first non-transparent parent: a role string,
105105
* null (element with no role), or undefined (no non-transparent parent).
106106
*/

tests/lib/rules/template-no-heading-inside-button.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ ruleTester.run('template-no-heading-inside-button', rule, {
1212
'<template><h1>Title</h1></template>',
1313
'<template><div><h2>Heading</h2></div></template>',
1414

15-
// Test cases ported from ember-template-lint
1615
'<template><button>Show More</button></template>',
1716
'<template><button><span>thumbs-up emoji</span>Show More</button></template>',
1817
'<template><button><div>Show More</div></button></template>',
@@ -32,7 +31,6 @@ ruleTester.run('template-no-heading-inside-button', rule, {
3231
errors: [{ messageId: 'noHeading' }],
3332
},
3433

35-
// Test cases ported from ember-template-lint
3634
{
3735
code: '<template><button><h1>Page Title</h1></button></template>',
3836
output: null,

tests/lib/rules/template-no-inline-styles.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ const ruleTester = new RuleTester({
88
ruleTester.run('template-no-inline-styles', rule, {
99
valid: [
1010
'<template><div class="foo"></div></template>',
11-
// Test cases ported from ember-template-lint
1211
'<template><div></div></template>',
1312
'<template><span></span></template>',
1413
'<template><ul class="dummy"></ul></template>',

tests/lib/rules/template-no-input-tagname.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ const ruleTester = new RuleTester({
99
ruleTester.run('template-no-input-tagname', rule, {
1010
valid: [
1111
'<template>{{input value=this.foo}}</template>',
12-
// Test cases ported from ember-template-lint
1312
'<template>{{input type="text"}}</template>',
1413
'<template>{{component "input" type="text"}}</template>',
1514
'<template>{{yield (component "input" type="text")}}</template>',
@@ -42,7 +41,6 @@ ruleTester.run('template-no-input-tagname', rule, {
4241
errors: [{ messageId: 'unexpected' }],
4342
},
4443

45-
// Test cases ported from ember-template-lint
4644
{
4745
code: '<template>{{input tagName="foo"}}</template>',
4846
output: null,

tests/lib/rules/template-no-invalid-interactive.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ ruleTester.run('template-no-invalid-interactive', rule, {
3535
output: null,
3636
},
3737

38-
// Test cases ported from ember-template-lint
3938
'<template><button {{action "foo"}}></button></template>',
4039
'<template><canvas {{on "mousedown"}}></canvas></template>',
4140
'<template><div role="button" {{action "foo"}}></div></template>',
@@ -120,7 +119,6 @@ ruleTester.run('template-no-invalid-interactive', rule, {
120119
],
121120
},
122121

123-
// Test cases ported from ember-template-lint
124122
{
125123
code: '<template><div {{on "click" this.actionName}}>...</div></template>',
126124
output: null,

tests/lib/rules/template-no-invalid-link-text.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ const ruleTester = new RuleTester({
99
ruleTester.run('template-no-invalid-link-text', rule, {
1010
valid: [
1111
// Link with component child — content is opaque, can't validate.
12-
// Mirrors upstream no-invalid-link-text.js L53-56 ("do not flag when link contains additional dynamic (non-text) children").
1312
{ filename: 'test.gjs', code: '<template><a href="/x"><MyComponent /></a></template>' },
1413
{ filename: 'test.gjs', code: '<template><a href="/x">prefix <MyComponent /></a></template>' },
1514

tests/lib/rules/template-no-model-argument-in-route-templates.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,6 @@ ruleTester.run('template-no-model-argument-in-route-templates', rule, {
7272
output: '<template>{{this.model.foo}}</template>',
7373
errors: [{ messageId: 'noModelArgumentInRouteTemplates' }],
7474
},
75-
// Unknown path defaults to lint (matches upstream).
7675
{
7776
code: '<template>{{@model.foo}}</template>',
7877
output: '<template>{{this.model.foo}}</template>',

tests/lib/rules/template-quotes.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ const validHbs = [
2828
code: '<input type=\'checkbox\'> {{hello "test" x="test"}}',
2929
options: [{ curlies: 'double', html: 'single' }],
3030
},
31-
// `false` as the root config disables the rule (matches upstream).
3231
{
3332
code: "{{component \"test\"}} {{hello x='test'}} <input type='checkbox'>",
3433
options: [false],

0 commit comments

Comments
 (0)