Extract rule: template-require-has-block-helper

Author: NullVoxPopuli

README.md

@@ -253,6 +253,7 @@ rules in templates can be disabled with eslint directives with mustache or html
 | [template-no-obsolete-elements](docs/rules/template-no-obsolete-elements.md)                                       | disallow obsolete HTML elements                                              |    |    |    |
 | [template-no-outlet-outside-routes](docs/rules/template-no-outlet-outside-routes.md)                               | disallow {{outlet}} outside of route templates                               |    |    |    |
 | [template-no-page-title-component](docs/rules/template-no-page-title-component.md)                                 | disallow usage of ember-page-title component                                 |    |    |    |
+| [template-require-has-block-helper](docs/rules/template-require-has-block-helper.md)                               | require (has-block) helper usage instead of hasBlock property                |    |    |    |
 | [template-require-iframe-src-attribute](docs/rules/template-require-iframe-src-attribute.md)                       | require iframe elements to have src attribute                                |    | 🔧 |    |
 | [template-require-splattributes](docs/rules/template-require-splattributes.md)                                     | require splattributes usage in component templates                           |    |    |    |
 | [template-require-strict-mode](docs/rules/template-require-strict-mode.md)                                         | require templates to be in strict mode                                       |    |    |    |

docs/rules/template-require-has-block-helper.md

@@ -0,0 +1,54 @@
+# ember/template-require-has-block-helper
+
+> **HBS Only**: This rule applies to classic `.hbs` template files only (loose mode). It is not relevant for `gjs`/`gts` files (strict mode), where these patterns cannot occur.
+
+<!-- end auto-generated rule header -->
+
+Requires usage of the `(has-block)` helper instead of the `hasBlock` property.
+
+## Rule Details
+
+The `(has-block)` helper is the preferred way to check if a block was provided to a component.
+
+## Examples
+
+Examples of **incorrect** code for this rule:
+
+```hbs
+{{#if hasBlock}}
+  {{yield}}
+{{/if}}
+```
+
+```hbs
+{{#if this.hasBlock}}
+  {{yield}}
+{{/if}}
+```
+
+Examples of **correct** code for this rule:
+
+```hbs
+{{#if (has-block)}}
+  {{yield}}
+{{/if}}
+```
+
+```hbs
+{{#if (has-block 'inverse')}}
+  {{yield to='inverse'}}
+{{/if}}
+```
+
+## Migration
+
+- `{{hasBlock}}`-> `{{has-block}}
+- `{{hasBlockParams}}`-> `{{has-block-params}}
+- `{{#if hasBlock}} {{/if}}`-> `{{#if (has-block)}} {{/if}}`
+- `{{#if (hasBlock "inverse")}} {{/if}}`-> `{{#if (has-block "inverse")}} {{/if}}`
+- `{{#if hasBlockParams}} {{/if}}`-> `{{#if (has-block-params)}} {{/if}}`
+- `{{#if (hasBlockParams "inverse")}} {{/if}}`-> `{{#if (has-block-params "inverse")}} {{/if}}`
+
+## References
+
+- [eslint-plugin-ember template-require-has-block-helper](https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/template-require-has-block-helper.md)

lib/rules/template-require-has-block-helper.js

@@ -0,0 +1,41 @@
+/** @type {import('eslint').Rule.RuleModule} */
+module.exports = {
+  meta: {
+    type: 'suggestion',
+    docs: {
+      description: 'require (has-block) helper usage instead of hasBlock property',
+      category: 'Best Practices',
+      url: 'https://github.com/ember-cli/eslint-plugin-ember/tree/master/docs/rules/template-require-has-block-helper.md',
+      templateMode: 'loose',
+    },
+    fixable: null,
+    schema: [],
+    messages: {
+      useHasBlockHelper: 'Use (has-block) helper instead of hasBlock property.',
+    },
+    originallyFrom: {
+      name: 'ember-template-lint',
+      rule: 'lib/rules/require-has-block-helper.js',
+      docs: 'docs/rule/require-has-block-helper.md',
+      tests: 'test/unit/rules/require-has-block-helper-test.js',
+    },
+  },
+
+  create(context) {
+    return {
+      GlimmerPathExpression(node) {
+        if (
+          node.original === 'hasBlock' ||
+          node.original === 'this.hasBlock' ||
+          node.original === 'hasBlockParams' ||
+          node.original === 'this.hasBlockParams'
+        ) {
+          context.report({
+            node,
+            messageId: 'useHasBlockHelper',
+          });
+        }
+      },
+    };
+  },
+};