PR Feedback

Author: NullVoxPopuli

lib/rules/template-no-bare-strings.js

@@ -175,24 +175,30 @@ module.exports = {
   },
 
   create(context) {
+    const filename = context.filename ?? context.getFilename();
+    const isStrictMode = filename.endsWith('.gjs') || filename.endsWith('.gts');
+
     const rawConfig = context.options[0];
     let config;
 
+    // In strict mode (gjs/gts), Input/Textarea could be custom components —
+    // prefer false negatives over false positives, matching ember-template-lint.
+    const defaultElementAttributes = isStrictMode
+      ? DEFAULT_ELEMENT_ATTRIBUTES
+      : mergeObjects(DEFAULT_ELEMENT_ATTRIBUTES, BUILTIN_COMPONENT_ATTRIBUTES);
+
     if (Array.isArray(rawConfig)) {
       config = {
         allowlist: sanitizeConfigArray([...rawConfig, ...DEFAULT_ALLOWLIST]),
         globalAttributes: [...DEFAULT_GLOBAL_ATTRIBUTES],
-        elementAttributes: mergeObjects(DEFAULT_ELEMENT_ATTRIBUTES, BUILTIN_COMPONENT_ATTRIBUTES),
+        elementAttributes: defaultElementAttributes,
         ignoredElements: [...IGNORED_ELEMENTS],
       };
     } else if (rawConfig && typeof rawConfig === 'object') {
       config = {
         allowlist: sanitizeConfigArray([...(rawConfig.allowlist || []), ...DEFAULT_ALLOWLIST]),
         globalAttributes: [...(rawConfig.globalAttributes || []), ...DEFAULT_GLOBAL_ATTRIBUTES],
-        elementAttributes: mergeObjects(
-          rawConfig.elementAttributes,
-          mergeObjects(DEFAULT_ELEMENT_ATTRIBUTES, BUILTIN_COMPONENT_ATTRIBUTES)
-        ),
+        elementAttributes: mergeObjects(rawConfig.elementAttributes, defaultElementAttributes),
         ignoredElements: [
           ...sanitizeConfigArray(rawConfig.ignoredElements || []),
           ...IGNORED_ELEMENTS,
@@ -202,7 +208,7 @@ module.exports = {
       config = {
         allowlist: [...DEFAULT_ALLOWLIST],
         globalAttributes: [...DEFAULT_GLOBAL_ATTRIBUTES],
-        elementAttributes: mergeObjects(DEFAULT_ELEMENT_ATTRIBUTES, BUILTIN_COMPONENT_ATTRIBUTES),
+        elementAttributes: defaultElementAttributes,
         ignoredElements: [...IGNORED_ELEMENTS],
       };
     }

tests/lib/rules/template-no-bare-strings.js

@@ -37,6 +37,24 @@ ruleTester.run('template-no-bare-strings', rule, {
     '<template><pre> fdff sf sf <div> aaa </div> f </pre></template>',
     '<template><textarea> this is an input</textarea></template>',
     '<template><div placeholder="wat?"></div></template>',
+    // In GJS/GTS (strict mode), Input/Textarea could be custom components —
+    // not checked to avoid false positives, matching ember-template-lint behavior.
+    {
+      filename: 'template.gjs',
+      code: '<template><Input placeholder="This is a placeholder" /></template>',
+    },
+    {
+      filename: 'template.gjs',
+      code: '<template><Textarea placeholder="This is a placeholder" /></template>',
+    },
+    {
+      filename: 'template.gjs',
+      code: '<template><Input @placeholder="This is a placeholder" /></template>',
+    },
+    {
+      filename: 'template.gts',
+      code: '<template><Textarea @placeholder="This is a placeholder" /></template>',
+    },
     `<template><foo-bar>
 </foo-bar></template>`,
     '<template><div data-test-foo-bar></div></template>',