Sync with template-lint

Author: NullVoxPopuli

docs/rules/template-no-valueless-arguments.md

@@ -13,13 +13,13 @@ This rule **forbids** the following:
 ```
 
 ```gjs
-<template><SomeComponent @valuelessByAccident {{@canBeAModifier}} /></template>
+<template><SomeComponent @valuelessByAccident{{@canBeAModifier}} /></template>
 ```
 
 This rule **allows** the following:
 
 ```gjs
-<template><Editor @defaultText='' /></template>
+<template><Editor @defaultText="" /></template>
 ```
 
 ## Migration

lib/rules/template-no-valueless-arguments.js

@@ -1,4 +1,8 @@
 /** @type {import('eslint').Rule.RuleModule} */
+function isNamedArgument(attrName) {
+  return attrName.startsWith('@');
+}
+
 module.exports = {
   meta: {
     type: 'problem',
@@ -18,16 +22,16 @@ module.exports = {
     },
   },
   create(context) {
+    const sourceCode = context.sourceCode || context.getSourceCode();
+
     return {
       GlimmerAttrNode(node) {
-        // Check if it's a named argument (@foo) with no value
-        if (node.name?.startsWith('@')) {
-          const sourceCode = context.sourceCode || context.getSourceCode();
-          const text = sourceCode.getText(node);
-          // Truly valueless if no '=' in the source text
-          if (!text.includes('=')) {
-            context.report({ node, messageId: 'valueless' });
-          }
+        if (!isNamedArgument(node.name)) {
+          return;
+        }
+
+        if (!sourceCode.getText(node).includes('=')) {
+          context.report({ node, messageId: 'valueless' });
         }
       },
     };

tests/lib/rules/template-no-valueless-arguments.js

@@ -1,39 +1,49 @@
 const rule = require('../../../lib/rules/template-no-valueless-arguments');
 const RuleTester = require('eslint').RuleTester;
 
-const ruleTester = new RuleTester({
+const validHbs = [
+  '<SomeComponent @emptyString="" data-test-some-component />',
+  '<button type="submit" disabled {{on "click" this.submit}}></button>',
+];
+
+const invalidHbs = [
+  {
+    code: '<SomeComponent @valueless />',
+    output: null,
+    errors: [{ messageId: 'valueless' }],
+  },
+  {
+    code: '<SomeComponent @valuelessByAccident{{this.canBeAModifier}} />',
+    output: null,
+    errors: [{ messageId: 'valueless' }],
+  },
+  {
+    code: '<SomeComponent @valuelessByAccident{{@canBeAModifier}} />',
+    output: null,
+    errors: [{ messageId: 'valueless' }],
+  },
+];
+
+function wrapTemplate(entry) {
+  if (typeof entry === 'string') {
+    return `<template>${entry}</template>`;
+  }
+
+  return {
+    ...entry,
+    code: `<template>${entry.code}</template>`,
+    output: entry.output ? `<template>${entry.output}</template>` : entry.output,
+  };
+}
+
+const gjsRuleTester = new RuleTester({
   parser: require.resolve('ember-eslint-parser'),
   parserOptions: { ecmaVersion: 2022, sourceType: 'module' },
 });
-ruleTester.run('template-no-valueless-arguments', rule, {
-  valid: [
-    '<template><Foo @bar={{true}} /></template>',
-    '<template><SomeComponent @emptyString="" data-test-some-component /></template>',
-    '<template><button type="submit" disabled {{on "click" this.submit}}></button></template>',
-  ],
-  invalid: [
-    {
-      code: '<template><Foo @bar /></template>',
-      output: null,
-      errors: [{ messageId: 'valueless' }],
-    },
 
-    {
-      code: '<template><SomeComponent @valueless /></template>',
-      output: null,
-      errors: [{ messageId: 'valueless' }],
-    },
-    {
-      code: '<template><SomeComponent @valuelessByAccident{{this.canBeAModifier}} /></template>',
-      output: null,
-      errors: [{ messageId: 'valueless' }],
-    },
-    {
-      code: '<template><SomeComponent @valuelessByAccident{{@canBeAModifier}} /></template>',
-      output: null,
-      errors: [{ messageId: 'valueless' }],
-    },
-  ],
+gjsRuleTester.run('template-no-valueless-arguments', rule, {
+  valid: validHbs.map(wrapTemplate),
+  invalid: invalidHbs.map(wrapTemplate),
 });
 
 const hbsRuleTester = new RuleTester({
@@ -45,25 +55,6 @@ const hbsRuleTester = new RuleTester({
 });
 
 hbsRuleTester.run('template-no-valueless-arguments', rule, {
-  valid: [
-    '<SomeComponent @emptyString="" data-test-some-component />',
-    '<button type="submit" disabled {{on "click" this.submit}}></button>',
-  ],
-  invalid: [
-    {
-      code: '<SomeComponent @valueless />',
-      output: null,
-      errors: [{ message: 'Named arguments should have an explicitly assigned value.' }],
-    },
-    {
-      code: '<SomeComponent @valuelessByAccident{{this.canBeAModifier}} />',
-      output: null,
-      errors: [{ message: 'Named arguments should have an explicitly assigned value.' }],
-    },
-    {
-      code: '<SomeComponent @valuelessByAccident{{@canBeAModifier}} />',
-      output: null,
-      errors: [{ message: 'Named arguments should have an explicitly assigned value.' }],
-    },
-  ],
+  valid: validHbs,
+  invalid: invalidHbs,
 });