Merge branch 'master' of github.com:johanrd/eslint-plugin-ember into day_fix/template-require-form-method

* 'master' of github.com:johanrd/eslint-plugin-ember: (23 commits)
  Fix template-no-duplicate-landmark-elements false positive on dynamic aria-label
  Fix template-no-log false positive on JS scope bindings in GJS/GTS
  Fix template-no-unbound false positive in GJS/GTS
  Review feedback: Set, inline sourceCode, document namespace-import limitation
  Fix template-no-inline-linkto false positive in GJS/GTS
  Fix template-no-input-block false positive in GJS/GTS
  Fix prettier formatting
  Fix template-require-input-label: import-aware <Input>/<Textarea> detection in strict mode
  Fix template-no-input-tagname: cover angle-bracket <Input @TagName=...> with import tracking in strict mode
  Fix template-require-has-block-helper: skip JS scope bindings
  Fix template-no-implicit-this: callee detection, block param scoping, JS scope, bare {{this}}
  Fix template-no-class-bindings false positive in GJS/GTS
  Fix template-deprecated-inline-view-helper false positive in GJS/GTS
  Fix template-deprecated-render-helper false positive in GJS/GTS
  fix(template-no-invalid-interactive): align interactive element detection with upstream
  fix(template-no-curly-component-invocation): preserve this./@ prefixes, local names, and JS scope bindings
  Fix template-no-invalid-link-title: track @ember/routing LinkTo import in GJS/GTS
  Fix template-no-outlet-outside-routes false positive on JS scope bindings in GJS/GTS
  Fix template-no-empty-headings: detect this./@/dot-path component children
  Fix template-no-multiple-empty-lines: handle trailing empty lines
  ...

Author: johanrd

docs/rules/template-no-dynamic-subexpression-invocations.md

@@ -26,12 +26,6 @@ This rule disallows invoking helpers dynamically using `this` or `@` properties.
 </template>
 ```
 
-```gjs
-<template>
-  {{this.formatter this.data}}
-</template>
-```
-
 ### Correct ✅
 
 ```gjs
@@ -52,6 +46,13 @@ This rule disallows invoking helpers dynamically using `this` or `@` properties.
 </template>
 ```
 
+```gjs
+{{! Body-position dynamic helpers are allowed }}
+<template>
+  {{this.formatter this.data}}
+</template>
+```
+
 ## Related Rules
 
 - [template-no-implicit-this](./template-no-implicit-this.md)

docs/rules/template-no-inline-linkto.md

@@ -62,6 +62,19 @@ Examples of **correct** code for this rule:
 </template>
 ```
 
+```gjs
+// User-authored `<LinkTo>` (not from `@ember/routing`) is not flagged in
+// strict mode, even when childless.
+import LinkTo from './my-link-to-component';
+<template>
+  <LinkTo />
+</template>
+```
+
+## Strict-mode behavior
+
+In `.gjs`/`.gts` strict mode, `<LinkTo>` only refers to Ember's router link when explicitly imported from `@ember/routing` (this also covers renamed imports such as `import { LinkTo as Link } from '@ember/routing'`). Without that import, `<LinkTo>` is treated as a user-authored component and the rule does not fire. The curly `{{link-to ...}}` form is unreachable in strict mode (`link-to` cannot be a JS identifier) and the autofix is skipped there.
+
 ## References
 
 - [eslint-plugin-ember template-no-inline-link-to](https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/template-no-inline-link-to.md)

docs/rules/template-no-unbound.md

@@ -1,7 +1,5 @@
 # ember/template-no-unbound
 
-> **HBS Only**: This rule applies to classic `.hbs` template files only (loose mode). It is not relevant for `gjs`/`gts` files (strict mode), where these patterns cannot occur.
-
 <!-- end auto-generated rule header -->
 
 `{{unbound}}` is a legacy hold over from the days in which Ember's template engine was less performant. Its use today

lib/rules/template-deprecated-inline-view-helper.js

@@ -23,6 +23,11 @@ module.exports = {
   },
 
   create(context) {
+    const isStrictMode = context.filename.endsWith('.gjs') || context.filename.endsWith('.gts');
+    if (isStrictMode) {
+      return {};
+    }
+
     const sourceCode = context.sourceCode;
 
     // Track block param names to avoid false positives on locals like:

lib/rules/template-deprecated-render-helper.js

@@ -23,6 +23,11 @@ module.exports = {
   },
 
   create(context) {
+    const isStrictMode = context.filename.endsWith('.gjs') || context.filename.endsWith('.gts');
+    if (isStrictMode) {
+      return {};
+    }
+
     const sourceCode = context.sourceCode;
 
     function buildFix(node) {

lib/rules/template-no-chained-this.js

@@ -57,9 +57,20 @@ module.exports = {
           node,
           messageId: 'noChainedThis',
           fix(fixer) {
+            const fixes = [];
+
             // Replace the tag name after '<'
             const openStart = node.range[0] + 1;
-            return fixer.replaceTextRange([openStart, openStart + node.tag.length], fixedTag);
+            fixes.push(fixer.replaceTextRange([openStart, openStart + node.tag.length], fixedTag));
+
+            // For non-self-closing elements, also fix the closing tag </tag>
+            if (!node.selfClosing) {
+              const closingEnd = node.range[1] - 1; // before '>'
+              const closingStart = closingEnd - node.tag.length; // start of tag name in </tag>
+              fixes.push(fixer.replaceTextRange([closingStart, closingEnd], fixedTag));
+            }
+
+            return fixes;
           },
         });
       },

lib/rules/template-no-class-bindings.js

@@ -23,6 +23,11 @@ module.exports = {
   },
 
   create(context) {
+    const isStrictMode = context.filename.endsWith('.gjs') || context.filename.endsWith('.gts');
+    if (isStrictMode) {
+      return {};
+    }
+
     const FORBIDDEN_ATTR_NAMES = new Set([
       'classBinding',
       '@classBinding',

lib/rules/template-no-curly-component-invocation.js

@@ -38,7 +38,12 @@ const BUILT_INS = new Set([
 
 const ALWAYS_CURLY = new Set(['yield']);
 
-function transformTagName(name) {
+function transformTagName(name, isLocal) {
+  // Preserve this.*, @*, and local variable names as-is
+  if (name.startsWith('@') || name.startsWith('this.') || isLocal) {
+    return name;
+  }
+
   // Convert kebab-case to PascalCase for angle bracket syntax
   const parts = name.split('/');
   return parts
@@ -159,6 +164,34 @@ module.exports = {
       return blockParamStack.some((params) => params.includes(name));
     }
 
+    /**
+     * Returns true if the mustache/block node's path head resolves to a
+     * JavaScript scope binding (import, const, function param, etc.) —
+     * i.e. the template reference is an explicit GJS/GTS binding, not an
+     * implicit resolver lookup. Such references should not be flagged as
+     * ambiguous curly invocations. Walks `scope.variables` up the chain by
+     * name, which handles Glimmer built-in names that don't appear in
+     * `scope.references`.
+     */
+    function isJsScopeBinding(node) {
+      const name = node.path?.original?.split('.')[0];
+      if (!sourceCode || !name) {
+        return false;
+      }
+      try {
+        let scope = sourceCode.getScope(node);
+        while (scope) {
+          if (scope.variables.some((v) => v.name === name)) {
+            return true;
+          }
+          scope = scope.upper;
+        }
+      } catch {
+        // sourceCode.getScope may not be available in .hbs-only mode; ignore.
+      }
+      return false;
+    }
+
     function reportMustache(node, pathOriginal) {
       const angleBracketName = transformTagName(pathOriginal);
       context.report({
@@ -167,13 +200,19 @@ module.exports = {
       });
     }
 
-    function checkMustacheWithNamedArgs(node, pathOriginal, explicitThis) {
+    function checkMustacheWithNamedArgs(node, pathOriginal, explicitThis, local) {
       // {{foo.bar bar=baz}} - multi-part path (not this./@ prefix) with named args
       if (!explicitThis && pathOriginal.includes('.')) {
         reportMustache(node, pathOriginal);
         return;
       }
 
+      // Explicit JS scope binding or block param — user already imported/scoped
+      // the value by that exact name; converting to angle-bracket would break.
+      if (local) {
+        return;
+      }
+
       if (config.allow.includes(pathOriginal)) {
         return;
       }
@@ -266,12 +305,12 @@ module.exports = {
 
         const explicitThis = isExplicitThisPath(pathOriginal);
         const firstPart = pathOriginal.split('.')[0];
-        const local = isLocalVar(firstPart);
+        const local = isLocalVar(firstPart) || isJsScopeBinding(node);
 
         const hasNamedArguments = node.hash && node.hash.pairs && node.hash.pairs.length > 0;
 
         if (hasNamedArguments) {
-          checkMustacheWithNamedArgs(node, pathOriginal, explicitThis);
+          checkMustacheWithNamedArgs(node, pathOriginal, explicitThis, local);
         } else {
           checkMustacheWithoutNamedArgs(node, pathOriginal, explicitThis, local);
         }
@@ -311,7 +350,17 @@ module.exports = {
           return;
         }
 
-        const angleBracketName = transformTagName(pathOriginal);
+        const firstPart = pathOriginal.split('.')[0];
+        const local = isLocalVar(firstPart) || isJsScopeBinding(node);
+
+        // Explicit JS scope binding: the user imported this exact identifier.
+        // Converting {{#fooBar}}...{{/fooBar}} to <FooBar>...</FooBar> would
+        // reference a different (unbound) name. Skip the report entirely.
+        if (local && !isLocalVar(firstPart)) {
+          return;
+        }
+
+        const angleBracketName = transformTagName(pathOriginal, local);
         context.report({
           node,
           message: `You are using the component {{#${pathOriginal}}} with curly component syntax. You should use <${angleBracketName}> instead. If it is actually a helper you must manually add it to the 'no-curly-component-invocation' rule configuration, e.g. \`'no-curly-component-invocation': { allow: ['${pathOriginal}'] }\`.`,

lib/rules/template-no-duplicate-landmark-elements.js

@@ -157,6 +157,15 @@ module.exports = {
           isInsideSectioningElement()
         );
         if (landmarkRole) {
+          // Dynamic aria-label / aria-labelledby — can't statically determine whether
+          // this landmark duplicates a sibling, so skip registering it entirely.
+          const labelAttr =
+            node.attributes?.find((attr) => attr.name === 'aria-label') ||
+            node.attributes?.find((attr) => attr.name === 'aria-labelledby');
+          if (labelAttr && labelAttr.value?.type !== 'GlimmerTextNode') {
+            return;
+          }
+
           const landmarks = currentLandmarks();
           if (!landmarks.has(landmarkRole)) {
             landmarks.set(landmarkRole, []);

lib/rules/template-no-dynamic-subexpression-invocations.js

@@ -138,17 +138,6 @@ module.exports = {
               node,
               messageId: 'noDynamicSubexpressionInvocations',
             });
-            return;
-          }
-
-          if (!inAttr && hasArgs) {
-            // In body context, only flag this.* paths (not @args)
-            if (node.path.head?.type === 'ThisHead') {
-              context.report({
-                node,
-                messageId: 'noDynamicSubexpressionInvocations',
-              });
-            }
           }
         }
       },