Add closing tag line validation matching ember-template-lint

Author: johanrd

lib/rules/template-attribute-indentation.js

@@ -461,14 +461,20 @@ module.exports = {
       }
     }
 
-    function validateClosingTag(node) {
+    function validateClosingTag(node, lastChildEndLine) {
       // `</tag>` is `2 + tag.length + 1` chars: `</` + tag + `>`
       const actualColumnStartLocation = 3 + node.tag.length;
       const actualColumn = node.loc.end.column - actualColumnStartLocation;
       const expectedColumn = node.loc.start.column;
-
-      if (actualColumn !== expectedColumn) {
-        const actualLine = node.loc.end.line;
+      const actualLine = node.loc.end.line;
+
+      // Closing tag must not appear before the last child ends (line check),
+      // and must be column-aligned with the opening tag.
+      // Note: Glimmer AST may not include trailing whitespace TextNodes, so the
+      // closing tag can be on a LATER line than lastChildEndLine (whitespace gap).
+      // The original ember-template-lint's strict line equality works because
+      // Handlebars AST includes trailing TextNodes that span to the closing tag line.
+      if (actualLine < lastChildEndLine || actualColumn !== expectedColumn) {
         context.report({
           node,
           messageId: 'incorrectClosingTag',
@@ -477,7 +483,7 @@ module.exports = {
             tagName: node.tag,
             actualLine,
             actualColumn,
-            expectedLine: actualLine,
+            expectedLine: lastChildEndLine,
             expectedColumn,
           },
         });
@@ -528,7 +534,12 @@ module.exports = {
             }
 
             if (node.children.length > 0) {
-              validateClosingTag(node);
+              const lastChild = node.children.at(-1);
+              const expectedStartLine =
+                lastChild.type === 'GlimmerBlockStatement'
+                  ? lastChild.loc.end.line + 1
+                  : lastChild.loc.end.line;
+              validateClosingTag(node, expectedStartLine);
             }
           }
         }

tests/lib/rules/template-attribute-indentation.js

@@ -1034,5 +1034,12 @@ hbsRuleTester.run('template-attribute-indentation (closing tag)', rule, {
       options: [{ 'process-elements': true }],
       errors: [{ messageId: 'incorrectClosingTag' }],
     },
+    // Closing tag on same line as opening tag attributes (too early)
+    {
+      code: ['<div', '  class="foo"', '>content</div>'].join('\n'),
+      output: null,
+      options: [{ 'process-elements': true }],
+      errors: [{ messageId: 'incorrectClosingTag' }],
+    },
   ],
 });