Update with fixer

Author: NullVoxPopuli

README.md

@@ -292,7 +292,7 @@ rules in templates can be disabled with eslint directives with mustache or html
 | [no-old-shims](docs/rules/no-old-shims.md)                                                       | disallow usage of old shims for modules                   | ✅  | 🔧 |    |
 | [no-string-prototype-extensions](docs/rules/no-string-prototype-extensions.md)                   | disallow usage of `String` prototype extensions           | ✅  |    |    |
 | [template-deprecated-inline-view-helper](docs/rules/template-deprecated-inline-view-helper.md)   | disallow inline {{view}} helper                           |    | 🔧 |    |
-| [template-deprecated-render-helper](docs/rules/template-deprecated-render-helper.md)             | disallow {{render}} helper                                |    |    |    |
+| [template-deprecated-render-helper](docs/rules/template-deprecated-render-helper.md)             | disallow {{render}} helper                                |    | 🔧 |    |
 | [template-no-action](docs/rules/template-no-action.md)                                           | disallow {{action}} helper                                |    |    |    |
 | [template-no-attrs-in-components](docs/rules/template-no-attrs-in-components.md)                 | disallow attrs in component templates                     |    |    |    |
 | [template-no-link-to-positional-params](docs/rules/template-no-link-to-positional-params.md)     | disallow positional params in LinkTo component            |    |    |    |

docs/rules/template-deprecated-render-helper.md

@@ -1,5 +1,7 @@
 # ember/template-deprecated-render-helper
 
+🔧 This rule is automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/latest/user-guide/command-line-interface#--fix).
+
 > **HBS Only**: This rule applies to classic `.hbs` template files only (loose mode). It is not relevant for `gjs`/`gts` files (strict mode), where these patterns cannot occur.
 
 <!-- end auto-generated rule header -->

lib/rules/template-deprecated-render-helper.js

@@ -8,7 +8,7 @@ module.exports = {
       url: 'https://github.com/ember-cli/eslint-plugin-ember/tree/master/docs/rules/template-deprecated-render-helper.md',
       templateMode: 'loose',
     },
-    fixable: null,
+    fixable: 'code',
     schema: [],
     messages: {
       deprecated:
@@ -23,6 +23,29 @@ module.exports = {
   },
 
   create(context) {
+    const sourceCode = context.sourceCode;
+
+    function buildFix(node) {
+      const first = node.params[0];
+      if (!first || first.type !== 'GlimmerStringLiteral') {
+        return null;
+      }
+      const templateName = first.value;
+
+      if (node.params.length === 1) {
+        // {{render 'name'}} → {{name}}
+        return (fixer) => fixer.replaceText(node, `{{${templateName}}}`);
+      }
+
+      if (node.params.length === 2) {
+        // {{render 'name' model}} → {{name model=model}}
+        const model = sourceCode.getText(node.params[1]);
+        return (fixer) => fixer.replaceText(node, `{{${templateName} model=${model}}}`);
+      }
+
+      return null;
+    }
+
     function checkForRender(node) {
       if (
         node.path &&
@@ -32,6 +55,7 @@ module.exports = {
         context.report({
           node,
           messageId: 'deprecated',
+          fix: buildFix(node),
         });
       }
     }

tests/lib/rules/template-deprecated-render-helper.js

@@ -23,18 +23,17 @@ ruleTester.run('template-deprecated-render-helper', rule, {
   invalid: [
     {
       code: '<template>{{render "user"}}</template>',
-      output: null,
+      output: '<template>{{user}}</template>',
       errors: [{ messageId: 'deprecated' }],
     },
-
     {
       code: "<template>{{render 'ken-griffey'}}</template>",
-      output: null,
+      output: '<template>{{ken-griffey}}</template>',
       errors: [{ messageId: 'deprecated' }],
     },
     {
       code: "<template>{{render 'baseball-player' pitcher}}</template>",
-      output: null,
+      output: '<template>{{baseball-player model=pitcher}}</template>',
       errors: [{ messageId: 'deprecated' }],
     },
   ],
@@ -63,23 +62,13 @@ hbsRuleTester.run('template-deprecated-render-helper', rule, {
   invalid: [
     {
       code: "{{render 'ken-griffey'}}",
-      output: null,
-      errors: [
-        {
-          message:
-            'The render helper is deprecated in favor of using components. See https://emberjs.com/deprecations/v2.x/#toc_code-render-code-helper',
-        },
-      ],
+      output: '{{ken-griffey}}',
+      errors: [{ messageId: 'deprecated' }],
     },
     {
       code: "{{render 'baseball-player' pitcher}}",
-      output: null,
-      errors: [
-        {
-          message:
-            'The render helper is deprecated in favor of using components. See https://emberjs.com/deprecations/v2.x/#toc_code-render-code-helper',
-        },
-      ],
+      output: '{{baseball-player model=pitcher}}',
+      errors: [{ messageId: 'deprecated' }],
     },
   ],
 });