Add 2 rules: splat-attributes-only, no-attrs-in-components (34/127)

Co-authored-by: NullVoxPopuli <[email protected]>

Author: Copilot

lib/rules/template-no-attrs-in-components.js

@@ -0,0 +1,27 @@
+/** @type {import('eslint').Rule.RuleModule} */
+module.exports = {
+  meta: {
+    type: 'suggestion',
+    docs: {
+      description: 'disallow attrs in component templates',
+      category: 'Deprecations',
+      recommendedGjs: true,
+      recommendedGts: true,
+      url: 'https://github.com/ember-cli/eslint-plugin-ember/tree/master/docs/rules/template-no-attrs-in-components.md',
+    },
+    schema: [],
+    messages: {
+      noAttrs: 'Component templates should not contain `attrs`.',
+    },
+  },
+  create(context) {
+    return {
+      GlimmerPathExpression(node) {
+        // Check if the path starts with "attrs"
+        if (node.original?.startsWith('attrs.') || node.original === 'attrs') {
+          context.report({ node, messageId: 'noAttrs' });
+        }
+      },
+    };
+  },
+};

lib/rules/template-splat-attributes-only.js

@@ -0,0 +1,26 @@
+/** @type {import('eslint').Rule.RuleModule} */
+module.exports = {
+  meta: {
+    type: 'problem',
+    docs: {
+      description: 'disallow ...spread other than ...attributes',
+      category: 'Best Practices',
+      recommendedGjs: true,
+      recommendedGts: true,
+      url: 'https://github.com/ember-cli/eslint-plugin-ember/tree/master/docs/rules/template-splat-attributes-only.md',
+    },
+    schema: [],
+    messages: {
+      onlyAttributes: 'Only `...attributes` can be applied to elements',
+    },
+  },
+  create(context) {
+    return {
+      GlimmerAttrNode(node) {
+        if (node.name?.startsWith('...') && node.name !== '...attributes') {
+          context.report({ node, messageId: 'onlyAttributes' });
+        }
+      },
+    };
+  },
+};

tests/lib/rules/template-no-attrs-in-components.js

@@ -0,0 +1,23 @@
+const rule = require('../../../lib/rules/template-no-attrs-in-components');
+const RuleTester = require('eslint').RuleTester;
+
+const ruleTester = new RuleTester({
+  parser: require.resolve('ember-eslint-parser'),
+  parserOptions: { ecmaVersion: 2022, sourceType: 'module' },
+});
+
+ruleTester.run('template-no-attrs-in-components', rule, {
+  valid: ['<template>{{@value}}</template>', '<template>{{this.value}}</template>'],
+  invalid: [
+    {
+      code: '<template>{{attrs.value}}</template>',
+      output: null,
+      errors: [{ messageId: 'noAttrs' }],
+    },
+    {
+      code: '<template>{{attrs}}</template>',
+      output: null,
+      errors: [{ messageId: 'noAttrs' }],
+    },
+  ],
+});

tests/lib/rules/template-splat-attributes-only.js

@@ -0,0 +1,21 @@
+const rule = require('../../../lib/rules/template-splat-attributes-only');
+const RuleTester = require('eslint').RuleTester;
+
+const ruleTester = new RuleTester({
+  parser: require.resolve('ember-eslint-parser'),
+  parserOptions: { ecmaVersion: 2022, sourceType: 'module' },
+});
+
+ruleTester.run('template-splat-attributes-only', rule, {
+  valid: [
+    '<template><div ...attributes></div></template>',
+    '<template><MyComponent ...attributes /></template>',
+  ],
+  invalid: [
+    {
+      code: '<template><div ...props></div></template>',
+      output: null,
+      errors: [{ messageId: 'onlyAttributes' }],
+    },
+  ],
+});