Extract rule: template-no-builtin-form-components

Author: NullVoxPopuli

README.md

@@ -185,6 +185,7 @@ rules in templates can be disabled with eslint directives with mustache or html
 | Name                                                                                       | Description                                               | 💼 | 🔧 | 💡 |
 | :----------------------------------------------------------------------------------------- | :-------------------------------------------------------- | :- | :- | :- |
 | [template-builtin-component-arguments](docs/rules/template-builtin-component-arguments.md) | disallow setting certain attributes on builtin components |    |    |    |
+| [template-no-builtin-form-components](docs/rules/template-no-builtin-form-components.md)   | disallow usage of built-in form components                |    |    |    |
 | [template-no-debugger](docs/rules/template-no-debugger.md)                                 | disallow {{debugger}} in templates                        |    |    |    |
 | [template-no-log](docs/rules/template-no-log.md)                                           | disallow {{log}} in templates                             |    |    |    |
 

docs/rules/template-no-builtin-form-components.md

@@ -0,0 +1,43 @@
+# ember/template-no-builtin-form-components
+
+<!-- end auto-generated rule header -->
+
+Disallows usage of built-in form components.
+
+## Rule Details
+
+Built-in Ember components like `<Input>` and `<Textarea>` should be replaced with native HTML elements for better performance and simpler code.
+
+## Examples
+
+Examples of **incorrect** code for this rule:
+
+```gjs
+<template>
+  <Input @type="text" />
+</template>
+```
+
+```gjs
+<template>
+  <Textarea @value={{this.text}} />
+</template>
+```
+
+Examples of **correct** code for this rule:
+
+```gjs
+<template>
+  <input type="text" />
+</template>
+```
+
+```gjs
+<template>
+  <textarea></textarea>
+</template>
+```
+
+## References
+
+- [eslint-plugin-ember no-builtin-form-components](https://github.com/eslint-plugin-ember/eslint-plugin-ember/blob/master/docs/rule/no-builtin-form-components.md)

lib/rules/template-no-builtin-form-components.js

@@ -0,0 +1,34 @@
+/** @type {import('eslint').Rule.RuleModule} */
+module.exports = {
+  meta: {
+    type: 'suggestion',
+    docs: {
+      description: 'disallow usage of built-in form components',
+      category: 'Best Practices',
+      strictGjs: true,
+      strictGts: true,
+      url: 'https://github.com/ember-cli/eslint-plugin-ember/tree/master/docs/rules/template-no-builtin-form-components.md',
+    },
+    fixable: null,
+    schema: [],
+    messages: {
+      noBuiltinFormComponent:
+        'Do not use built-in form components. Use native HTML elements instead.',
+    },
+  },
+
+  create(context) {
+    const BUILTIN_FORM_COMPONENTS = new Set(['Input', 'Textarea']);
+
+    return {
+      GlimmerElementNode(node) {
+        if (BUILTIN_FORM_COMPONENTS.has(node.tag)) {
+          context.report({
+            node,
+            messageId: 'noBuiltinFormComponent',
+          });
+        }
+      },
+    };
+  },
+};

tests/lib/rules/template-no-builtin-form-components.js

@@ -0,0 +1,56 @@
+//------------------------------------------------------------------------------
+// Requirements
+//------------------------------------------------------------------------------
+
+const rule = require('../../../lib/rules/template-no-builtin-form-components');
+const RuleTester = require('eslint').RuleTester;
+
+//------------------------------------------------------------------------------
+// Tests
+//------------------------------------------------------------------------------
+
+const ruleTester = new RuleTester({
+  parser: require.resolve('ember-eslint-parser'),
+  parserOptions: { ecmaVersion: 2022, sourceType: 'module' },
+});
+
+ruleTester.run('template-no-builtin-form-components', rule, {
+  valid: [
+    `<template>
+      <input type="text" />
+    </template>`,
+    `<template>
+      <textarea></textarea>
+    </template>`,
+    `<template>
+      <a href="/home">Home</a>
+    </template>`,
+  ],
+
+  invalid: [
+    {
+      code: `<template>
+        <Input @type="text" />
+      </template>`,
+      output: null,
+      errors: [
+        {
+          message: 'Do not use built-in form components. Use native HTML elements instead.',
+          type: 'GlimmerElementNode',
+        },
+      ],
+    },
+    {
+      code: `<template>
+        <Textarea @value={{this.text}} />
+      </template>`,
+      output: null,
+      errors: [
+        {
+          message: 'Do not use built-in form components. Use native HTML elements instead.',
+          type: 'GlimmerElementNode',
+        },
+      ],
+    },
+  ],
+});