Sync with template-lint

Author: NullVoxPopuli

docs/rules/template-no-unbound.md

@@ -13,12 +13,16 @@ It is also a poor practice to use it for rendering only the initial value of a p
 
 This rule **forbids** the following:
 
-```hbs
-{{unbound aVar}}
+```gjs
+<template>
+  {{unbound aVar}}
+</template>
 ```
 
-```hbs
-{{some-component foo=(unbound aVar)}}
+```gjs
+<template>
+  {{some-component foo=(unbound aVar)}}
+</template>
 ```
 
 ## References

lib/rules/template-no-unbound.js

@@ -9,7 +9,7 @@ module.exports = {
       templateMode: 'loose',
     },
     schema: [],
-    messages: { unexpected: 'Unexpected unbound helper usage.' },
+    messages: { unexpected: 'Unexpected {{unboundHelper}} usage.' },
     originallyFrom: {
       name: 'ember-template-lint',
       rule: 'lib/rules/no-unbound.js',
@@ -20,7 +20,11 @@ module.exports = {
   create(context) {
     function check(node) {
       if (node.path?.type === 'GlimmerPathExpression' && node.path.original === 'unbound') {
-        context.report({ node, messageId: 'unexpected' });
+        context.report({
+          node,
+          messageId: 'unexpected',
+          data: { unboundHelper: '{{unbound}}' },
+        });
       }
     }
     return {

tests/lib/rules/template-no-unbound.js

@@ -1,29 +1,42 @@
 const rule = require('../../../lib/rules/template-no-unbound');
 const RuleTester = require('eslint').RuleTester;
 
-const ruleTester = new RuleTester({
+const validHbs = ['{{foo}}', '{{button}}'];
+
+const invalidHbs = [
+  {
+    code: '{{unbound foo}}',
+    output: null,
+    errors: [{ message: 'Unexpected {{unbound}} usage.' }],
+  },
+  {
+    code: '{{my-thing foo=(unbound foo)}}',
+    output: null,
+    errors: [{ message: 'Unexpected {{unbound}} usage.' }],
+  },
+];
+
+function wrapTemplate(entry) {
+  if (typeof entry === 'string') {
+    return `<template>${entry}</template>`;
+  }
+
+  return {
+    ...entry,
+    code: `<template>${entry.code}</template>`,
+    output: entry.output ? `<template>${entry.output}</template>` : entry.output,
+    errors: entry.errors.map(() => ({ messageId: 'unexpected' })),
+  };
+}
+
+const gjsRuleTester = new RuleTester({
   parser: require.resolve('ember-eslint-parser'),
   parserOptions: { ecmaVersion: 2022, sourceType: 'module' },
 });
-ruleTester.run('template-no-unbound', rule, {
-  valid: [
-    '<template>{{this.value}}</template>',
-    '<template>{{foo}}</template>',
-    '<template>{{button}}</template>',
-  ],
-  invalid: [
-    {
-      code: '<template>{{unbound foo}}</template>',
-      output: null,
-      errors: [{ messageId: 'unexpected' }],
-    },
-
-    {
-      code: '<template>{{my-thing foo=(unbound foo)}}</template>',
-      output: null,
-      errors: [{ messageId: 'unexpected' }],
-    },
-  ],
+
+gjsRuleTester.run('template-no-unbound', rule, {
+  valid: validHbs.map(wrapTemplate),
+  invalid: invalidHbs.map(wrapTemplate),
 });
 
 const hbsRuleTester = new RuleTester({
@@ -35,17 +48,6 @@ const hbsRuleTester = new RuleTester({
 });
 
 hbsRuleTester.run('template-no-unbound', rule, {
-  valid: ['{{foo}}', '{{button}}'],
-  invalid: [
-    {
-      code: '{{unbound foo}}',
-      output: null,
-      errors: [{ message: 'Unexpected unbound helper usage.' }],
-    },
-    {
-      code: '{{my-thing foo=(unbound foo)}}',
-      output: null,
-      errors: [{ message: 'Unexpected unbound helper usage.' }],
-    },
-  ],
+  valid: validHbs,
+  invalid: invalidHbs,
 });