Merge pull request #2538 from johanrd/issue/1116-leaking-state-ts-as-expression

[BUGFIX legacy]: `avoid-leaking-state-in-ember-objects` false positives with TypeScript type assertions

Author: NullVoxPopuli

lib/rules/avoid-leaking-state-in-ember-objects.js

@@ -28,6 +28,11 @@ function isAllowedLogicalExpression(value) {
 }
 
 function isAllowed(value) {
+  // Unwrap TypeScript type assertions: `x as Type` or `x satisfies Type`
+  if (value && (value.type === 'TSAsExpression' || value.type === 'TSSatisfiesExpression')) {
+    return isAllowed(value.expression);
+  }
+
   return (
     ember.isFunctionExpression(value) ||
     types.isLiteral(value) ||

tests/lib/rules/avoid-leaking-state-in-ember-objects.js

@@ -57,6 +57,16 @@ eslintTester.run('avoid-leaking-state-in-ember-objects', rule, {
     'import EmberObject from "@ember/object"; export default class MyNativeClassComponentWithAMixin extends EmberObject.extend(MyMixin) { someArrayField = []; }',
     { code: 'export default Foo.extend({ someProp: [] });', options: [['someProp']] }, // With options.
     { code: 'export default Foo.extend({ someProp: [], actions: {} });', options: [['someProp']] }, // With options and known Ember property.
+
+    // TypeScript type assertions should be unwrapped
+    {
+      code: 'export default Foo.extend({ someProp: undefined as string | undefined });',
+      parser: require.resolve('@typescript-eslint/parser'),
+    },
+    {
+      code: 'export default Foo.extend({ someProp: inject() as unknown as Store });',
+      parser: require.resolve('@typescript-eslint/parser'),
+    },
   ],
   invalid: [
     {