fix(template-no-attrs-in-components): also flag this.attrs.*

In the Glimmer AST, `this.attrs.foo` has parts[0] === 'attrs' (this is
the receiver, not a part), so switching from original.startsWith('attrs.')
to parts[0] === 'attrs' matches upstream and correctly flags both bare
attrs.* and this.attrs.* — both are pre-Octane @ember/component patterns.

Author: johanrd

lib/rules/template-no-attrs-in-components.js

@@ -29,13 +29,10 @@ module.exports = {
     }
     return {
       GlimmerPathExpression(node) {
-        const original = node.original;
-        if (typeof original !== 'string') {
-          return;
-        }
-        // Flag bare `attrs` or `attrs.<something>` (pre-Octane args-leakage).
-        // Do NOT flag `this.attrs.*` — that is a different (non-existent) API.
-        if (original === 'attrs' || original.startsWith('attrs.')) {
+        // Flag `attrs.*` and `this.attrs.*` — both are pre-Octane args-leakage
+        // patterns from @ember/component. In the Glimmer AST, `this.attrs.foo`
+        // has parts[0] === 'attrs' (this is the receiver, not a part).
+        if (node.parts && node.parts[0] === 'attrs') {
           context.report({ node, messageId: 'noAttrs' });
         }
       },

tests/lib/rules/template-no-attrs-in-components.js

@@ -17,9 +17,7 @@ ruleTester.run('template-no-attrs-in-components', rule, {
       filename: 'app/templates/application.hbs',
       code: '<template>{{this.value}}</template>',
     },
-    // `this.attrs.*` is not a real Ember API, but it is NOT what this rule
-    // targets — only bare `attrs.*` is flagged. So outside of a component
-    // template, `this.attrs.*` should not be flagged.
+    // `this.attrs.*` outside a component template — not flagged (path gate).
     {
       filename: 'app/templates/application.hbs',
       code: '<template>{{this.attrs.foo}}</template>',
@@ -38,11 +36,6 @@ ruleTester.run('template-no-attrs-in-components', rule, {
       filename: 'app/templates/components/foo.hbs',
       code: '<template>{{this.value}}</template>',
     },
-    // This rule does NOT flag `this.attrs.*`; only bare `attrs.*`.
-    {
-      filename: 'app/templates/components/foo.hbs',
-      code: '<template>{{this.attrs.foo}}</template>',
-    },
     // Pod-style components path matches the gate, but no `attrs` usage.
     {
       filename: 'app/components/foo/template.hbs',
@@ -90,5 +83,12 @@ ruleTester.run('template-no-attrs-in-components', rule, {
       output: null,
       errors: [{ messageId: 'noAttrs' }],
     },
+    // `this.attrs.*` inside a component template — flagged (real @ember/component API).
+    {
+      filename: 'app/templates/components/foo.hbs',
+      code: '<template>{{this.attrs.foo}}</template>',
+      output: null,
+      errors: [{ messageId: 'noAttrs' }],
+    },
   ],
 });