Fix template-no-obsolete-elements: track element-level block params

The rule suppressed obsolete-element reports when the tag name shadows a
block param from a GlimmerBlockStatement (e.g. {{#let (...) as |marquee|}}).
It did not track element-level block params (<Comp as |marquee|>), so
inside an angle-bracket component the shadowing was ignored and the tag
was falsely reported. Push element block params on enter and pop on exit,
mirroring the existing GlimmerBlockStatement handling.

Author: johanrd

lib/rules/template-no-obsolete-elements.js

@@ -64,12 +64,22 @@ module.exports = {
         }
       },
       GlimmerElementNode(node) {
-        if (blockParamsInScope.includes(node.tag)) {
-          return;
-        }
-        if (obsolete.has(node.tag)) {
+        // Check the element's own tag before pushing its block params, so an
+        // element's own params don't shadow its own tag name (e.g.
+        // `<marquee as |marquee|>` should still flag the outer <marquee>).
+        if (!blockParamsInScope.includes(node.tag) && obsolete.has(node.tag)) {
           context.report({ node, messageId: 'obsolete', data: { element: node.tag } });
         }
+        // Element-level block params (e.g. `<Comp as |param|>`) are scoped to
+        // the children, so push them after the obsolete check. Pop on exit.
+        const elementParams = node.blockParams || [];
+        blockParamsInScope.push(...elementParams);
+      },
+      'GlimmerElementNode:exit'(node) {
+        const elementParams = node.blockParams || [];
+        for (let i = 0; i < elementParams.length; i++) {
+          blockParamsInScope.pop();
+        }
       },
     };
   },

tests/lib/rules/template-no-obsolete-elements.js

@@ -11,13 +11,22 @@ ruleTester.run('template-no-obsolete-elements', rule, {
     `<template>{{#let (component 'whatever-here') as |plaintext|}}
       <plaintext />
     {{/let}}</template>`,
+    // Element-level block params (<Comp as |...|>) are now tracked
+    '<template><Comp as |plaintext|><plaintext /></Comp></template>',
+    '<template><Outer as |marquee|><marquee /></Outer></template>',
   ],
   invalid: [
     {
       code: '<template><marquee></marquee></template>',
       output: null,
       errors: [{ messageId: 'obsolete' }],
     },
+    // Element's own block params must not shadow its own tag name.
+    {
+      code: '<template><marquee as |marquee|></marquee></template>',
+      output: null,
+      errors: [{ messageId: 'obsolete', data: { element: 'marquee' } }],
+    },
   ],
 });