eslint-plugin-ember/lib/rules/template-valid-input-attributes.js at a48260c9197a60a5ba833623783301a7880a146d · ember-cli/eslint-plugin-ember · GitHub

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
'use strict';

// Logic adapted from html-validate (MIT), Copyright 2017 David Sveningsson.

const RESTRICTED = new Map([
  ['accept', new Set(['file'])],
  ['alt', new Set(['image'])],
  ['capture', new Set(['file'])],
  ['checked', new Set(['checkbox', 'radio'])],
  ['dirname', new Set(['text', 'search'])],
  ['height', new Set(['image'])],
  [
    'list',
    new Set([
      'text',
      'search',
      'url',
      'tel',
      'email',
      'date',
      'month',
      'week',
      'time',
      'datetime-local',
      'number',
      'range',
      'color',
    ]),
  ],
  ['max', new Set(['date', 'month', 'week', 'time', 'datetime-local', 'number', 'range'])],
  ['maxlength', new Set(['text', 'search', 'url', 'tel', 'email', 'password'])],
  ['min', new Set(['date', 'month', 'week', 'time', 'datetime-local', 'number', 'range'])],
  ['minlength', new Set(['text', 'search', 'url', 'tel', 'email', 'password'])],
  ['multiple', new Set(['email', 'file'])],
  ['pattern', new Set(['text', 'search', 'url', 'tel', 'email', 'password'])],
  ['placeholder', new Set(['text', 'search', 'url', 'tel', 'email', 'password', 'number'])],
  [
    'readonly',
    new Set([
      'text',
      'search',
      'url',
      'tel',
      'email',
      'password',
      'date',
      'month',
      'week',
      'time',
      'datetime-local',
      'number',
    ]),
  ],
  [
    'required',
    new Set([
      'text',
      'search',
      'url',
      'tel',
      'email',
      'password',
      'date',
      'month',
      'week',
      'time',
      'datetime-local',
      'number',
      'checkbox',
      'radio',
      'file',
    ]),
  ],
  ['size', new Set(['text', 'search', 'url', 'tel', 'email', 'password'])],
  ['src', new Set(['image'])],
  ['step', new Set(['date', 'month', 'week', 'time', 'datetime-local', 'number', 'range'])],
  ['width', new Set(['image'])],
]);

// Input types defined by the HTML spec. Per the spec, an <input> element with a
// missing, empty, or unknown `type` attribute falls back to the Text state, so
// we normalize to 'text' before validating attribute compatibility.
// https://html.spec.whatwg.org/multipage/input.html#attr-input-type
const KNOWN_INPUT_TYPES = new Set([
  'hidden',
  'text',
  'search',
  'tel',
  'url',
  'email',
  'password',
  'date',
  'month',
  'week',
  'time',
  'datetime-local',
  'number',
  'range',
  'color',
  'checkbox',
  'radio',
  'file',
  'submit',
  'image',
  'reset',
  'button',
]);

/** @type {import('eslint').Rule.RuleModule} */
module.exports = {
  meta: {
    type: 'problem',
    docs: {
      description: 'disallow input attributes that are incompatible with the declared type',
      category: 'Possible Errors',
      url: 'https://github.com/ember-cli/eslint-plugin-ember/tree/master/docs/rules/template-valid-input-attributes.md',
      templateMode: 'both',
    },
    fixable: null,
    schema: [],
    messages: {
      incompatible: 'Attribute `{{attr}}` is not allowed on `<input type="{{type}}">`',
    },
  },

  create(context) {
    return {
      GlimmerElementNode(node) {
        if (node.tag !== 'input') {
          return;
        }
        // Per HTML §4.10.5, an <input> with missing, valueless, empty, or
        // unknown `type` falls back to the Text state. Only a DYNAMIC type
        // (mustache/concat) is opaque to static analysis — skip those.
        const typeAttr = node.attributes?.find((a) => a.name === 'type');
        let normalized;
        if (!typeAttr || !typeAttr.value) {
          // Missing attribute OR valueless `<input type />` — Text state.
          normalized = '';
        } else if (typeAttr.value.type === 'GlimmerTextNode') {
          normalized = typeAttr.value.chars.trim().toLowerCase();
        } else if (
          typeAttr.value.type === 'GlimmerMustacheStatement' &&
          typeAttr.value.path?.type === 'GlimmerStringLiteral'
        ) {
          normalized = typeAttr.value.path.value.trim().toLowerCase();
        } else {
          // Dynamic value — can't statically determine; skip.
          return;
        }
        const type = KNOWN_INPUT_TYPES.has(normalized) ? normalized : 'text';

        for (const attr of node.attributes || []) {
          const validTypes = RESTRICTED.get(attr.name);
          if (!validTypes) {
            continue;
          }
          if (validTypes.has(type)) {
            continue;
          }
          context.report({
            node: attr,
            messageId: 'incompatible',
            data: { attr: attr.name, type },
          });
        }
      },
    };
  },
};