-
-
Notifications
You must be signed in to change notification settings - Fork 212
Expand file tree
/
Copy pathtemplate-no-invalid-aria-attributes.js
More file actions
281 lines (269 loc) · 12.1 KB
/
template-no-invalid-aria-attributes.js
File metadata and controls
281 lines (269 loc) · 12.1 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
//------------------------------------------------------------------------------
// Requirements
//------------------------------------------------------------------------------
const rule = require('../../../lib/rules/template-no-invalid-aria-attributes');
const RuleTester = require('eslint').RuleTester;
const ruleTester = new RuleTester({
parser: require.resolve('ember-eslint-parser'),
parserOptions: { ecmaVersion: 2022, sourceType: 'module' },
});
ruleTester.run('template-no-invalid-aria-attributes', rule, {
valid: [
'<template><div aria-label="Label">Content</div></template>',
'<template><div aria-hidden="true">Content</div></template>',
'<template><div aria-describedby="id">Content</div></template>',
'<template><h1 aria-hidden="true">Valid Heading</h1></template>',
'<template><h1 aria-hidden={{true}}>Second valid Heading</h1></template>',
'<template><input type="email" aria-required="true" /></template>',
'<template><input type="text" aria-labelledby="label1 label2" /></template>',
'<template><div role="checkbox" aria-checked="true" onclick="handleCheckbox()" tabindex="0"></div></template>',
'<template><button aria-haspopup="true"></button></template>',
'<template><button aria-haspopup="dialog"></button></template>',
'<template><div role="slider" aria-valuenow="50" aria-valuemax="100" aria-valuemin="0" /></template>',
'<template><div role="heading" aria-level={{2}}></div></template>',
'<template><input type="text" id="name" aria-invalid="grammar" /></template>',
'<template><div role="region" aria-live="polite" aria-relevant="additions text">Valid live region</div></template>',
'<template><div aria-label="{{@foo.bar}} baz"></div></template>',
'<template><CustomComponent @ariaRequired={{this.ariaRequired}} aria-errormessage="errorId" /></template>',
'<template><button type="submit" aria-disabled={{this.isDisabled}}>Submit</button></template>',
'<template><div role="textbox" aria-sort={{if this.hasCustomSort "other" "ascending"}}></div></template>',
// Boolean-type attributes with allowundefined: true per aria-query — the
// string "undefined" is spec-valid (WAI-ARIA 1.2 value tables for these
// attrs list true/false/undefined). All 4 share the same code path.
'<template><div role="combobox" aria-expanded="undefined"></div></template>',
'<template><div aria-hidden="undefined"></div></template>',
'<template><div aria-grabbed="undefined" draggable="true"></div></template>',
'<template><div role="option" aria-selected="undefined"></div></template>',
// Token-type aria-orientation lists "undefined" in its values array;
// passes the natural token check (no special-casing needed).
'<template><div role="slider" aria-orientation="undefined"></div></template>',
'<template><div role="slider" aria-orientation="horizontal"></div></template>',
// aria-pressed is tristate WITHOUT allowundefined — string "undefined"
// is NOT accepted. Explicit valid values still work.
'<template><button aria-pressed="true">Toggle</button></template>',
'<template><button aria-pressed="false">Toggle</button></template>',
'<template><button aria-pressed="mixed">Toggle</button></template>',
'<template><button aria-label={{if @isNew (t "actions.add") (t "actions.edit")}}></button></template>',
],
invalid: [
{
code: '<template><div aria-fake="value">Content</div></template>',
output: null,
errors: [{ messageId: 'noInvalidAriaAttribute', data: { attribute: 'aria-fake' } }],
},
{
code: '<template><div aria-invalid-attr="value">Content</div></template>',
output: null,
errors: [{ messageId: 'noInvalidAriaAttribute', data: { attribute: 'aria-invalid-attr' } }],
},
{
code: '<template><input aria-text="inaccessible text" /></template>',
output: null,
errors: [{ messageId: 'noInvalidAriaAttribute' }],
},
{
code: '<template><div role="slider" aria-valuenow={{this.foo}} aria-valuemax={{this.bar}} aria-value-min={{this.baz}} /></template>',
output: null,
errors: [{ messageId: 'noInvalidAriaAttribute' }],
},
{
code: '<template><h1 aria--hidden="true">Broken heading</h1></template>',
output: null,
errors: [{ messageId: 'noInvalidAriaAttribute' }],
},
{
code: '<template><CustomComponent role="region" aria-alert="polite" /></template>',
output: null,
errors: [{ messageId: 'noInvalidAriaAttribute' }],
},
{
code: '<template><span role="checkbox" aria-checked="bad-value" tabindex="0" aria-label="Forget me"></span></template>',
output: null,
errors: [{ messageId: 'invalidAriaAttributeValue' }],
},
{
code: '<template><button type="submit" disabled="true" aria-disabled="123">Submit</button></template>',
output: null,
errors: [{ messageId: 'invalidAriaAttributeValue' }],
},
{
code: '<template><input type="text" disabled="true" aria-errormessage="false" /></template>',
output: null,
errors: [{ messageId: 'invalidAriaAttributeValue' }],
},
{
code: '<template><button type="submit" aria-describedby="blah false">Continue at your own risk</button></template>',
output: null,
errors: [{ messageId: 'invalidAriaAttributeValue' }],
},
{
code: '<template><div role="heading" aria-level="bogus">Inaccessible heading</div></template>',
output: null,
errors: [{ messageId: 'invalidAriaAttributeValue' }],
},
{
code: '<template><div role="heading" aria-level="true">Another inaccessible heading</div></template>',
output: null,
errors: [{ messageId: 'invalidAriaAttributeValue' }],
},
{
code: '<template><div role="slider" aria-valuenow=(2*2) aria-valuemax="100" aria-valuemin="30">Broken slider</div></template>',
output: null,
errors: [{ messageId: 'invalidAriaAttributeValue' }],
},
{
code: '<template><div role="region" aria-live="no-such-value">Inaccessible live region</div></template>',
output: null,
errors: [{ messageId: 'invalidAriaAttributeValue' }],
},
{
code: '<template><div role="region" aria-live="polite" aria-relevant="additions errors">Inaccessible live region</div></template>',
output: null,
errors: [{ messageId: 'invalidAriaAttributeValue' }],
},
{
code: '<template><input type="text" aria-required="undefined" /></template>',
output: null,
errors: [{ messageId: 'invalidAriaAttributeValue' }],
},
{
code: '<template><div aria-label="true"></div></template>',
output: null,
errors: [{ messageId: 'invalidAriaAttributeValue' }],
},
{
code: '<template><div role="slider" aria-orientation="sideways"></div></template>',
output: null,
errors: [{ messageId: 'invalidAriaAttributeValue' }],
},
// aria-pressed is tristate WITHOUT allowundefined — string "undefined"
// is spec-invalid here (aria-query doesn't mark it allowundefined).
{
code: '<template><button aria-pressed="undefined">Toggle</button></template>',
output: null,
errors: [{ messageId: 'invalidAriaAttributeValue' }],
},
],
});
const hbsRuleTester = new RuleTester({
parser: require.resolve('ember-eslint-parser/hbs'),
parserOptions: {
ecmaVersion: 2022,
sourceType: 'module',
},
});
hbsRuleTester.run('template-no-invalid-aria-attributes', rule, {
valid: [
'<h1 aria-hidden="true">Valid Heading</h1>',
'<h1 aria-hidden={{true}}>Second valid Heading</h1>',
'<input type="email" aria-required="true" />',
'<input type="text" aria-labelledby="label1 label2" />',
'<div role="checkbox" aria-checked="true" onclick="handleCheckbox()" tabindex="0"></div>',
'<button aria-haspopup="true"></button>',
'<button aria-haspopup="dialog"></button>',
'<div role="slider" aria-valuenow="50" aria-valuemax="100" aria-valuemin="0" />',
'<div role="heading" aria-level={{2}}></div>',
'<input type="text" id="name" aria-invalid="grammar" />',
'<div role="region" aria-live="polite" aria-relevant="additions text">Valid live region</div>',
'<div aria-label="{{@foo.bar}} baz"></div>',
'<CustomComponent @ariaRequired={{this.ariaRequired}} aria-errormessage="errorId" />',
'<button type="submit" aria-disabled={{this.isDisabled}}>Submit</button>',
'<div role="textbox" aria-sort={{if this.hasCustomSort "other" "ascending"}}></div>',
// Boolean-type attrs with allowundefined (spec-valid "undefined" literal):
'<div role="combobox" aria-expanded="undefined"></div>',
'<div aria-hidden="undefined"></div>',
'<div aria-grabbed="undefined" draggable="true"></div>',
'<div role="option" aria-selected="undefined"></div>',
// Token-type aria-orientation — "undefined" passes via values list:
'<div role="slider" aria-orientation="undefined"></div>',
'<div role="slider" aria-orientation="horizontal"></div>',
// aria-pressed is tristate WITHOUT allowundefined; valid values:
'<button aria-pressed="true">Toggle</button>',
'<button aria-pressed="false">Toggle</button>',
'<button aria-pressed="mixed">Toggle</button>',
'<button aria-label={{if @isNew (t "actions.add") (t "actions.edit")}}></button>',
],
invalid: [
{
code: '<input aria-text="inaccessible text" />',
output: null,
errors: [{ message: 'Invalid ARIA attribute: aria-text' }],
},
{
code: '<div role="slider" aria-valuenow={{this.foo}} aria-valuemax={{this.bar}} aria-value-min={{this.baz}} />',
output: null,
errors: [{ message: 'Invalid ARIA attribute: aria-value-min' }],
},
{
code: '<h1 aria--hidden="true">Broken heading</h1>',
output: null,
errors: [{ message: 'Invalid ARIA attribute: aria--hidden' }],
},
{
code: '<CustomComponent role="region" aria-alert="polite" />',
output: null,
errors: [{ message: 'Invalid ARIA attribute: aria-alert' }],
},
{
code: '<span role="checkbox" aria-checked="bad-value" tabindex="0" aria-label="Forget me"></span>',
output: null,
errors: [{ messageId: 'invalidAriaAttributeValue' }],
},
{
code: '<button type="submit" disabled="true" aria-disabled="123">Submit</button>',
output: null,
errors: [{ messageId: 'invalidAriaAttributeValue' }],
},
{
code: '<input type="text" disabled="true" aria-errormessage="false" />',
output: null,
errors: [{ messageId: 'invalidAriaAttributeValue' }],
},
{
code: '<button type="submit" aria-describedby="blah false">Continue at your own risk</button>',
output: null,
errors: [{ messageId: 'invalidAriaAttributeValue' }],
},
{
code: '<div role="heading" aria-level="bogus">Inaccessible heading</div>',
output: null,
errors: [{ messageId: 'invalidAriaAttributeValue' }],
},
{
code: '<div role="heading" aria-level="true">Another inaccessible heading</div>',
output: null,
errors: [{ messageId: 'invalidAriaAttributeValue' }],
},
{
code: '<div role="slider" aria-valuenow=(2*2) aria-valuemax="100" aria-valuemin="30">Broken slider</div>',
output: null,
errors: [{ messageId: 'invalidAriaAttributeValue' }],
},
{
code: '<div role="region" aria-live="no-such-value">Inaccessible live region</div>',
output: null,
errors: [{ messageId: 'invalidAriaAttributeValue' }],
},
{
code: '<div role="region" aria-live="polite" aria-relevant="additions errors">Inaccessible live region</div>',
output: null,
errors: [{ messageId: 'invalidAriaAttributeValue' }],
},
{
code: '<input type="text" aria-required="undefined" />',
output: null,
errors: [{ messageId: 'invalidAriaAttributeValue' }],
},
{
code: '<div role="slider" aria-orientation="sideways"></div>',
output: null,
errors: [{ messageId: 'invalidAriaAttributeValue' }],
},
// aria-pressed has no allowundefined — "undefined" is spec-invalid here.
{
code: '<button aria-pressed="undefined">Toggle</button>',
output: null,
errors: [{ messageId: 'invalidAriaAttributeValue' }],
},
],
});