From a5b810e405fff9ea65b07416e612285f1a91ea83 Mon Sep 17 00:00:00 2001 From: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com> Date: Sat, 18 Apr 2026 19:02:09 -0400 Subject: [PATCH] Set allow-failure on every try scenario The CI's try-scenarios job has `continue-on-error: ${{ matrix.allow-failure }}`, but @embroider/try's list command passes scenario objects through verbatim (apart from normalizing env). Because none of the scenarios defined an allow-failure key, the expression evaluated to '' and GitHub Actions rejected it as a non-boolean, preventing the job from being created at all. The overall run was marked failed even though every other job passed. Define allow-failure on each scenario: true for the bleeding-edge ember-beta and ember-alpha scenarios, false everywhere else. Co-Authored-By: Claude Opus 4.7 (1M context) --- test-app/.try.mjs | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/test-app/.try.mjs b/test-app/.try.mjs index eb24328..7acc66f 100644 --- a/test-app/.try.mjs +++ b/test-app/.try.mjs @@ -35,6 +35,7 @@ export default { scenarios: [ { name: 'min-supported', + 'allow-failure': false, npm: { devDependencies: { 'ember-source': '~4.2.0', @@ -49,6 +50,7 @@ export default { }, { name: 'ember-lts-4.12', + 'allow-failure': false, npm: { devDependencies: { 'ember-source': '~4.12.0', @@ -63,6 +65,7 @@ export default { }, { name: 'ember-lts-5.12', + 'allow-failure': false, npm: { devDependencies: { 'ember-source': '~5.12.0', @@ -76,6 +79,7 @@ export default { }, { name: `ember-lts-6.4`, + 'allow-failure': false, npm: { devDependencies: { 'ember-source': `npm:ember-source@~6.4.0`, @@ -84,6 +88,7 @@ export default { }, { name: `ember-latest`, + 'allow-failure': false, npm: { devDependencies: { 'ember-source': `npm:ember-source@latest`, @@ -92,6 +97,7 @@ export default { }, { name: `ember-beta`, + 'allow-failure': true, npm: { devDependencies: { 'ember-source': `npm:ember-source@beta`, @@ -100,6 +106,7 @@ export default { }, { name: `ember-alpha`, + 'allow-failure': true, npm: { devDependencies: { 'ember-source': `npm:ember-source@alpha`,