Skip to content

Commit dc673d9

Browse files
authored
Merge pull request #307 from ember-cli/nvp/turn-off-fail-fast
Turn off fail-fast: true
2 parents 8eb20b1 + 3ceb771 commit dc673d9

1 file changed

Lines changed: 16 additions & 18 deletions

File tree

.github/workflows/ci.yml

Lines changed: 16 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
with:
1818
fetch-depth: 1
1919
- uses: wyvox/action-setup-pnpm@v3
20-
- run: pnpm build
20+
- run: pnpm build
2121
- name: Lint
2222
run: pnpm lint
2323

@@ -37,7 +37,7 @@ jobs:
3737
with:
3838
fetch-depth: 1
3939
- uses: wyvox/action-setup-pnpm@v3
40-
- run: pnpm build
40+
- run: pnpm build
4141
- name: Test
4242
run: pnpm test:ember --launch ${{ matrix.browser }}
4343
working-directory: test-app
@@ -59,14 +59,14 @@ jobs:
5959
fetch-depth: 1
6060
- uses: wyvox/action-setup-pnpm@v3
6161
with:
62-
pnpm-args: '--no-lockfile'
63-
- run: pnpm build
62+
pnpm-args: "--no-lockfile"
63+
- run: pnpm build
6464
- name: Test
6565
run: pnpm test:ember --launch ${{ matrix.browser }}
6666
working-directory: test-app
6767

6868
typecheck:
69-
name: '${{ matrix.typescript-scenario }}'
69+
name: "${{ matrix.typescript-scenario }}"
7070
runs-on: ubuntu-latest
7171
timeout-minutes: 2
7272
continue-on-error: true
@@ -85,28 +85,27 @@ jobs:
8585
- uses: wyvox/action-setup-pnpm@v3
8686
- run: pnpm build
8787
- run: pnpm i -f # just in case
88-
- name: 'test-types : ${{ matrix.typescript-scenario }}'
88+
- name: "test-types : ${{ matrix.typescript-scenario }}"
8989
working-directory: ./test-types
90-
run: 'pnpm add --save-dev ${{ matrix.typescript-scenario}}'
90+
run: "pnpm add --save-dev ${{ matrix.typescript-scenario}}"
9191

92-
- name: 'docs : ${{ matrix.typescript-scenario }}'
92+
- name: "docs : ${{ matrix.typescript-scenario }}"
9393
working-directory: ./docs
94-
run: 'pnpm add --save-dev ${{ matrix.typescript-scenario}}'
94+
run: "pnpm add --save-dev ${{ matrix.typescript-scenario}}"
9595

96-
- name: 'test-types'
96+
- name: "test-types"
9797
working-directory: ./test-types
9898
run: |
9999
pnpm tsc -v
100100
pnpm tsc --noEmit
101101
102-
- name: 'Glint in the docs app'
102+
- name: "Glint in the docs app"
103103
working-directory: ./docs
104104
run: |
105105
pnpm tsc -v
106106
pnpm glint --version
107107
pnpm glint
108108
109-
110109
try-scenarios:
111110
name: Tests - ${{ matrix.ember-try-scenario }}
112111
runs-on: ubuntu-latest
@@ -115,17 +114,16 @@ jobs:
115114
needs: test
116115

117116
strategy:
118-
fail-fast: true
117+
fail-fast: false
119118
matrix:
120-
ember-try-scenario:
121-
[
119+
ember-try-scenario: [
122120
minimum-supported-4-2,
123121
ember-lts-4.4,
124122
ember-lts-4.12,
125123
ember-lts-5.12,
126124
ember-release,
127125
ember-beta
128-
ember-canary
126+
ember-canary,
129127
]
130128
allow-failure: [false]
131129
include:
@@ -137,7 +135,7 @@ jobs:
137135
with:
138136
fetch-depth: 1
139137
- uses: wyvox/action-setup-pnpm@v3
140-
- run: pnpm build
138+
- run: pnpm build
141139
- name: Test
142140
env:
143141
EMBER_TRY_SCENARIO: ${{ matrix.ember-try-scenario }}
@@ -154,7 +152,7 @@ jobs:
154152
with:
155153
fetch-depth: 1
156154
- uses: wyvox/action-setup-pnpm@v3
157-
- run: pnpm build
155+
- run: pnpm build
158156

159157
- name: Test
160158
run: pnpm test:ember

0 commit comments

Comments
 (0)