Skip to content

Commit b6dbcab

Browse files
authored
Merge pull request #309 from ember-cli/nvp/update-typescript
Update TypeScript
2 parents 1535c21 + 32adf6f commit b6dbcab

8 files changed

Lines changed: 1323 additions & 2425 deletions

File tree

.github/workflows/ci.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -74,10 +74,10 @@ jobs:
7474
fail-fast: false
7575
matrix:
7676
typescript-scenario:
77-
- typescript@5.0
78-
- typescript@5.1
79-
- typescript@5.2
80-
- typescript@5.3
77+
- typescript@5.7
78+
- typescript@5.8
79+
- typescript@5.9
80+
- typescript@6.0
8181
- typescript@next
8282

8383
steps:

addon/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,13 +71,13 @@
7171
"@babel/eslint-parser": "^7.23.3",
7272
"@babel/plugin-proposal-class-properties": "^7.18.6",
7373
"@babel/plugin-proposal-decorators": "^7.23.6",
74+
"@ember/library-tsconfig": "^2.0.0",
7475
"@embroider/addon-dev": "^4.1.3",
7576
"@glint/core": "^1.5.2",
7677
"@glint/environment-ember-loose": "^1.5.2",
7778
"@glint/environment-ember-template-imports": "^1.5.2",
7879
"@glint/template": "^1.5.2",
7980
"@rollup/plugin-babel": "^6.0.4",
80-
"@tsconfig/ember": "^3.0.3",
8181
"@types/rsvp": "^4.0.8",
8282
"@typescript-eslint/eslint-plugin": "^6.15.0",
8383
"@typescript-eslint/parser": "^6.15.0",
@@ -94,7 +94,7 @@
9494
"npm-run-all": "^4.1.5",
9595
"prettier": "^3.1.1",
9696
"rollup": "^4.9.1",
97-
"typescript": "^5.3.3"
97+
"typescript": "^6.0.2"
9898
},
9999
"engines": {
100100
"node": "16.* || >= 18"

addon/tsconfig.json

Lines changed: 2 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"extends": "@tsconfig/ember/tsconfig.json",
2+
"extends": "@ember/library-tsconfig",
33
"include": [
44
"src/**/*",
55
"unpublished-development-types/**/*"
@@ -8,35 +8,7 @@
88
"environment": ["ember-loose", "ember-template-imports"]
99
},
1010
"compilerOptions": {
11-
12-
/**
13-
https://www.typescriptlang.org/tsconfig#allowImportingTsExtensions
14-
15-
We want our tooling to know how to resolve our custom files so the appropriate plugins
16-
can do the proper transformations on those files.
17-
*/
18-
"allowImportingTsExtensions": true,
19-
"allowJs": true,
2011
"declarationDir": "declarations",
21-
22-
/**
23-
https://www.typescriptlang.org/tsconfig#rootDir
24-
"Default: The longest common path of all non-declaration input files."
25-
26-
Because we want our declarations' structure to match our rollup output,
27-
we need this "rootDir" to match the "srcDir" in the rollup.config.mjs.
28-
29-
This way, we can have simpler `package.json#exports` that matches
30-
imports to files on disk
31-
*/
32-
"rootDir": "./src",
33-
34-
/**
35-
https://www.typescriptlang.org/tsconfig#verbatimModuleSyntax
36-
37-
We don't want to include types dependencies in our compiled output, so tell TypeScript
38-
to enforce using `import type` instead of `import` for Types.
39-
*/
40-
"verbatimModuleSyntax": true
12+
"rootDir": "./src"
4113
}
4214
}

docs/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
},
3232
"devDependencies": {
3333
"@babel/eslint-parser": "^7.23.3",
34+
"@ember/app-tsconfig": "^2.0.0",
3435
"@ember/optional-features": "^2.0.0",
3536
"@ember/string": "^3.1.1",
3637
"@ember/test-helpers": "^3.2.1",
@@ -40,7 +41,6 @@
4041
"@glint/environment-ember-loose": "^1.5.2",
4142
"@glint/environment-ember-template-imports": "^1.5.2",
4243
"@glint/template": "^1.5.2",
43-
"@tsconfig/ember": "^3.0.3",
4444
"@types/qunit": "^2.19.9",
4545
"@types/rsvp": "^4.0.8",
4646
"@typescript-eslint/eslint-plugin": "^6.16.0",
@@ -63,7 +63,7 @@
6363
"ember-maybe-import-regenerator": "^1.0.0",
6464
"ember-qunit": "^8.0.2",
6565
"ember-resolver": "^11.0.1",
66-
"ember-source": "~5.5.0",
66+
"ember-source": "~6.12.0",
6767
"ember-source-channel-url": "^3.0.0",
6868
"ember-template-imports": "^4.0.0",
6969
"ember-template-lint": "^6.1.0",
@@ -81,7 +81,7 @@
8181
"qunit": "^2.16.0",
8282
"sass": "^1.43.3",
8383
"standard-version": "^9.3.2",
84-
"typescript": "^5.3.3",
84+
"typescript": "^6.0.2",
8585
"webpack": "^5.0.0"
8686
},
8787
"engines": {

docs/tsconfig.json

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,7 @@
11
{
2-
"extends": "@tsconfig/ember/tsconfig.json",
2+
"extends": "@ember/app-tsconfig",
33
"compilerOptions": {
4-
// The combination of `baseUrl` with `paths` allows Ember's classic package
5-
// layout, which is not resolvable with the Node resolution algorithm, to
6-
// work with TypeScript.
7-
"baseUrl": ".",
84
"allowJs": true,
9-
// older glimmer doesn't have correct imports
10-
// needs "import type"
11-
"verbatimModuleSyntax": false,
125
"paths": {
136
"docs/tests/*": ["tests/*"],
147
"docs/*": ["app/*"],

0 commit comments

Comments
 (0)