Skip to content

Commit a5b810e

Browse files
NullVoxPopuliclaude
andcommitted
Set allow-failure on every try scenario
The CI's try-scenarios job has `continue-on-error: ${{ matrix.allow-failure }}`, but @embroider/try's list command passes scenario objects through verbatim (apart from normalizing env). Because none of the scenarios defined an allow-failure key, the expression evaluated to '' and GitHub Actions rejected it as a non-boolean, preventing the job from being created at all. The overall run was marked failed even though every other job passed. Define allow-failure on each scenario: true for the bleeding-edge ember-beta and ember-alpha scenarios, false everywhere else. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
1 parent ee22a86 commit a5b810e

1 file changed

Lines changed: 7 additions & 0 deletions

File tree

test-app/.try.mjs

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ export default {
3535
scenarios: [
3636
{
3737
name: 'min-supported',
38+
'allow-failure': false,
3839
npm: {
3940
devDependencies: {
4041
'ember-source': '~4.2.0',
@@ -49,6 +50,7 @@ export default {
4950
},
5051
{
5152
name: 'ember-lts-4.12',
53+
'allow-failure': false,
5254
npm: {
5355
devDependencies: {
5456
'ember-source': '~4.12.0',
@@ -63,6 +65,7 @@ export default {
6365
},
6466
{
6567
name: 'ember-lts-5.12',
68+
'allow-failure': false,
6669
npm: {
6770
devDependencies: {
6871
'ember-source': '~5.12.0',
@@ -76,6 +79,7 @@ export default {
7679
},
7780
{
7881
name: `ember-lts-6.4`,
82+
'allow-failure': false,
7983
npm: {
8084
devDependencies: {
8185
'ember-source': `npm:ember-source@~6.4.0`,
@@ -84,6 +88,7 @@ export default {
8488
},
8589
{
8690
name: `ember-latest`,
91+
'allow-failure': false,
8792
npm: {
8893
devDependencies: {
8994
'ember-source': `npm:ember-source@latest`,
@@ -92,6 +97,7 @@ export default {
9297
},
9398
{
9499
name: `ember-beta`,
100+
'allow-failure': true,
95101
npm: {
96102
devDependencies: {
97103
'ember-source': `npm:ember-source@beta`,
@@ -100,6 +106,7 @@ export default {
100106
},
101107
{
102108
name: `ember-alpha`,
109+
'allow-failure': true,
103110
npm: {
104111
devDependencies: {
105112
'ember-source': `npm:ember-source@alpha`,

0 commit comments

Comments
 (0)