Skip to content

Commit 51a3468

Browse files
Merge pull request #274 from ember-cli/package-json-sorting-lint
Package json sorting lint
2 parents eed8a0d + 849058a commit 51a3468

7 files changed

Lines changed: 156 additions & 914 deletions

File tree

addon/.eslintrc.js

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,5 +30,21 @@ module.exports = {
3030
plugins: ['node'],
3131
extends: ['plugin:node/recommended'],
3232
},
33+
{
34+
files: ['package.json'],
35+
plugins: ['jsonc'],
36+
parser: 'jsonc-eslint-parser',
37+
extends: ['plugin:jsonc/recommended-with-json', 'plugin:jsonc/prettier'],
38+
rules: {
39+
'jsonc/sort-keys': [
40+
'error',
41+
{
42+
pathPattern:
43+
'^(?:scripts|devDependencies|peerDependencies|optionalDependencies)$',
44+
order: { type: 'asc' },
45+
},
46+
],
47+
},
48+
},
3349
],
3450
};

addon/package.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,8 @@
3030
"lint:hbs:fix": "ember-template-lint . --fix",
3131
"lint:js": "eslint . --cache",
3232
"lint:js:fix": "eslint . --fix",
33-
"start": "rollup --config --watch",
34-
"prepublishOnly": "rollup --config"
33+
"prepublishOnly": "rollup --config",
34+
"start": "rollup --config --watch"
3535
},
3636
"dependencies": {
3737
"@embroider/addon-shim": "^1.8.7"
@@ -52,6 +52,7 @@
5252
"eslint": "^8.56.0",
5353
"eslint-config-prettier": "^9.1.0",
5454
"eslint-plugin-ember": "^11.12.0",
55+
"eslint-plugin-jsonc": "^2.11.2",
5556
"eslint-plugin-node": "^11.1.0",
5657
"eslint-plugin-prettier": "^5.1.2",
5758
"npm-run-all": "^4.1.5",

docs/.eslintrc.js

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,5 +38,21 @@ module.exports = {
3838
files: ['tests/**/*-test.{js,ts}'],
3939
extends: ['plugin:qunit/recommended'],
4040
},
41+
{
42+
files: ['package.json'],
43+
plugins: ['jsonc'],
44+
parser: 'jsonc-eslint-parser',
45+
extends: ['plugin:jsonc/recommended-with-json', 'plugin:jsonc/prettier'],
46+
rules: {
47+
'jsonc/sort-keys': [
48+
'error',
49+
{
50+
pathPattern:
51+
'^(?:scripts|devDependencies|peerDependencies|optionalDependencies)$',
52+
order: { type: 'asc' },
53+
},
54+
],
55+
},
56+
},
4157
],
4258
};

docs/package.json

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,18 +13,18 @@
1313
"repository": "https://github.com/ember-cli/ember-page-title",
1414
"scripts": {
1515
"build": "ember build --environment=production",
16+
"format:hbs": "prettier **/*.hbs --write --parser=glimmer",
17+
"format:js": "prettier **/*.js --write",
1618
"lint": "npm-run-all --aggregate-output --continue-on-error --parallel \"lint:!(fix)\"",
1719
"lint:fix": "npm-run-all --aggregate-output --continue-on-error --parallel lint:*:fix",
1820
"lint:hbs": "ember-template-lint .",
1921
"lint:hbs:fix": "ember-template-lint . --fix",
2022
"lint:js": "eslint . --cache",
2123
"lint:js:fix": "eslint . --fix",
24+
"release": "standard-version",
2225
"start": "ember serve",
2326
"test": "npm-run-all lint test:*",
24-
"test:ember": "ember test",
25-
"format:hbs": "prettier **/*.hbs --write --parser=glimmer",
26-
"format:js": "prettier **/*.js --write",
27-
"release": "standard-version"
27+
"test:ember": "ember test"
2828
},
2929
"devDependencies": {
3030
"@babel/eslint-parser": "^7.23.3",
@@ -61,6 +61,7 @@
6161
"eslint": "^8.56.0",
6262
"eslint-config-prettier": "^9.1.0",
6363
"eslint-plugin-ember": "^11.12.0",
64+
"eslint-plugin-jsonc": "^2.11.2",
6465
"eslint-plugin-node": "^11.1.0",
6566
"eslint-plugin-prettier": "^5.1.2",
6667
"eslint-plugin-qunit": "^8.0.1",

0 commit comments

Comments
 (0)