Deal with qunit lint changes

Author: NullVoxPopuli

test-app/tests/acceptance/posts-test.js

@@ -8,92 +8,82 @@ module('Acceptance: title', function (hooks) {
   setupApplicationTest(hooks);
 
   test('the default configuration works', async function (assert) {
-    assert.expect(1);
     await visit('/posts');
 
-    assert.equal(getPageTitle(), 'Posts | My App');
+    assert.strictEqual(getPageTitle(), 'Posts | My App');
   });
 
   test('the replace attribute works', async function (assert) {
-    assert.expect(1);
     await visit('/about');
 
-    assert.equal(getPageTitle(), 'About My App');
+    assert.strictEqual(getPageTitle(), 'About My App');
   });
 
   test('custom separators work', async function (assert) {
-    assert.expect(1);
     await visit('/about/authors');
 
-    assert.equal(getPageTitle(), 'Authors > About My App');
+    assert.strictEqual(getPageTitle(), 'Authors > About My App');
   });
 
   test('custom separators are inherited', async function (assert) {
-    assert.expect(1);
     await visit('/about/authors/profile');
 
-    assert.equal(getPageTitle(), 'Profile > Authors > About My App');
+    assert.strictEqual(getPageTitle(), 'Profile > Authors > About My App');
   });
 
   test('multiple components in a row work', async function (assert) {
-    assert.expect(1);
     await visit('/posts/rails-is-omakase');
 
-    assert.equal(getPageTitle(), 'Rails is Omakase | Posts | My App');
+    assert.strictEqual(getPageTitle(), 'Rails is Omakase | Posts | My App');
   });
 
   test('the prepend=false declaration works', async function (assert) {
-    assert.expect(1);
     await visit('/authors/tomster');
 
-    assert.equal(getPageTitle(), 'My App | Authors < Tomster');
+    assert.strictEqual(getPageTitle(), 'My App | Authors < Tomster');
   });
 
   test('replace nested in prepends work', async function (assert) {
-    assert.expect(1);
     await visit('/hollywood');
 
-    assert.equal(getPageTitle(), 'Hollywood ★ Stars everywhere');
+    assert.strictEqual(getPageTitle(), 'Hollywood ★ Stars everywhere');
   });
 
   test('multitoken titles work', async function (assert) {
-    assert.expect(1);
     await visit('/feeds/tomster');
 
-    assert.equal(getPageTitle(), 'Tomster (@tomster)');
+    assert.strictEqual(getPageTitle(), 'Tomster (@tomster)');
   });
 
   test('loading substates are not shown', async function (assert) {
-    assert.expect(3);
     await visit('/feeds/tomster');
-    assert.equal(getPageTitle(), 'Tomster (@tomster)');
+    assert.strictEqual(getPageTitle(), 'Tomster (@tomster)');
 
     await click('#zoey');
     await waitUntil(() => {
       return find('div[data-test-substate-loading]') === null;
     });
-    assert.equal(getPageTitle(), 'Zoey (@zoey)');
+    assert.strictEqual(getPageTitle(), 'Zoey (@zoey)');
 
     await click('#tomster');
     await waitUntil(() => {
       return find('div[data-test-substate-loading]') === null;
     });
-    assert.equal(getPageTitle(), 'Tomster (@tomster)');
+    assert.strictEqual(getPageTitle(), 'Tomster (@tomster)');
   });
 
   test('front tokens work', async function (assert) {
-    assert.expect(1);
     await visit('/reader');
 
-    assert.equal(getPageTitle(), '(10) Reader | My App');
+    assert.strictEqual(getPageTitle(), '(10) Reader | My App');
   });
 
   test('does not throw if no title element exist', async function (assert) {
     document.head.querySelectorAll('title').forEach((titleElement) => {
       document.head.removeChild(titleElement);
     });
     await visit('/posts');
-    assert.equal(getPageTitle(), 'Posts | My App');
+    assert.strictEqual(getPageTitle(), 'Posts | My App');
   });
 
   test('`titleDidUpdate` hook is called with the new title', async function (assert) {
@@ -108,9 +98,9 @@ module('Acceptance: title', function (hooks) {
     this.owner.register('service:page-title', ExtendedPageTitleService);
 
     await visit('/posts');
-    assert.equal(currentTitle, 'Posts | My App');
+    assert.strictEqual(currentTitle, 'Posts | My App');
 
     await visit('/posts/rails-is-omakase');
-    assert.equal(currentTitle, 'Rails is Omakase | Posts | My App');
+    assert.strictEqual(currentTitle, 'Rails is Omakase | Posts | My App');
   });
 });

test-app/tests/fastboot/title-test.js

@@ -6,88 +6,84 @@ module('FastBoot: title', function (hooks) {
   setup(hooks);
 
   test('the default configuration works', async function (assert) {
-    assert.expect(1);
     let { htmlDocument } = await visit('/posts');
 
-    assert.equal(getPageTitle(htmlDocument), 'Posts | My App');
+    assert.strictEqual(getPageTitle(htmlDocument), 'Posts | My App');
   });
 
   test('the replace attribute works', async function (assert) {
-    assert.expect(1);
     let { htmlDocument } = await visit('/about');
 
-    assert.equal(getPageTitle(htmlDocument), 'About My App');
+    assert.strictEqual(getPageTitle(htmlDocument), 'About My App');
   });
 
   test('custom separators work', async function (assert) {
-    assert.expect(1);
     let { htmlDocument } = await visit('/about/authors');
 
-    assert.equal(getPageTitle(htmlDocument), 'Authors > About My App');
+    assert.strictEqual(getPageTitle(htmlDocument), 'Authors > About My App');
   });
 
   test('custom separators are inherited', async function (assert) {
-    assert.expect(1);
     let { htmlDocument } = await visit('/about/authors/profile');
 
-    assert.equal(
+    assert.strictEqual(
       getPageTitle(htmlDocument),
-      'Profile > Authors > About My App'
+      'Profile > Authors > About My App',
     );
   });
 
   test('rendering only single title element', async function (assert) {
-    assert.expect(2);
     let { htmlDocument } = await visit('/fastboot/multiple/titles');
 
     // Since for our non-fastboot vs fastboot tests we keep original <title>
     // element in index.html, we simply filter it out.
     let numberOfTitleElements = htmlDocument.head.querySelectorAll(
-      'title:not([data-test-ignore-for-fastboot-tests])'
+      'title:not([data-test-ignore-for-fastboot-tests])',
     );
 
-    assert.equal(numberOfTitleElements.length, 1);
-    assert.equal(
+    assert.strictEqual(numberOfTitleElements.length, 1);
+    assert.strictEqual(
       getPageTitle(htmlDocument),
-      'Titles | Multiple | Fastboot | My App'
+      'Titles | Multiple | Fastboot | My App',
     );
   });
 
   test('multiple components in a row work', async function (assert) {
-    assert.expect(1);
     let { htmlDocument } = await visit('/posts/rails-is-omakase');
 
-    assert.equal(
+    assert.strictEqual(
       getPageTitle(htmlDocument),
-      'Rails is Omakase | Posts | My App'
+      'Rails is Omakase | Posts | My App',
     );
   });
 
   test('the prepend=false declaration works', async function (assert) {
-    assert.expect(1);
     let { htmlDocument } = await visit('/authors/tomster');
 
-    assert.equal(getPageTitle(htmlDocument), 'My App | Authors < Tomster');
+    assert.strictEqual(
+      getPageTitle(htmlDocument),
+      'My App | Authors < Tomster',
+    );
   });
 
   test('replace nested in prepends work', async function (assert) {
-    assert.expect(1);
     let { htmlDocument } = await visit('/hollywood');
 
-    assert.equal(getPageTitle(htmlDocument), 'Hollywood ★ Stars everywhere');
+    assert.strictEqual(
+      getPageTitle(htmlDocument),
+      'Hollywood ★ Stars everywhere',
+    );
   });
 
   test('multitoken titles work', async function (assert) {
-    assert.expect(1);
     let { htmlDocument } = await visit('/feeds/tomster');
 
-    assert.equal(getPageTitle(htmlDocument), 'Tomster (@tomster)');
+    assert.strictEqual(getPageTitle(htmlDocument), 'Tomster (@tomster)');
   });
 
   test('front tokens work', async function (assert) {
-    assert.expect(1);
     let { htmlDocument } = await visit('/reader');
 
-    assert.equal(getPageTitle(htmlDocument), '(10) Reader | My App');
+    assert.strictEqual(getPageTitle(htmlDocument), '(10) Reader | My App');
   });
 });