Skip to content

Commit c249df5

Browse files
author
Andrey Fel
committed
Fix bower error
By some reason ember-try is checking for bower looking at scenario.bower, scenario.dependencies and scenario.devDependencies: https://github.com/ember-cli/ember-try/blob/8fca8fc3aad863c5902a965287d728415a4a4663/lib/utils/dependency-manager-adapter-factory.js#L20 Fix the error by moving devDependencies into npm object which is correct anyway, not sure how it worked before. Seems that peerDependencies also should be nullified as otherwise there is an error: ``` ember-exam tried to import "ember-qunit" in "ember-exam/test-support/-private/ember-exam-qunit-test-loader.js" but the package was not resolvable from <path>/ember-exam ```
1 parent 0bb2da6 commit c249df5

1 file changed

Lines changed: 10 additions & 5 deletions

File tree

tests/dummy/config/ember-try.js

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,16 @@ const mergeWith = require('lodash.mergewith');
66

77
function mochaScenario(scenario = {}) {
88
return mergeWith({}, scenario, {
9-
devDependencies: {
10-
'chai-dom': '*',
11-
'ember-cli-chai': '*',
12-
'ember-mocha': '*',
13-
'ember-qunit': null,
9+
npm: {
10+
devDependencies: {
11+
'chai-dom': '*',
12+
'ember-cli-chai': '*',
13+
'ember-mocha': '*',
14+
'ember-qunit': null,
15+
},
16+
peerDependencies: {
17+
'ember-qunit': null,
18+
}
1419
},
1520
});
1621
}

0 commit comments

Comments
 (0)