Skip to content

Commit 7b5f620

Browse files
Split out try scenarios in to real apps for easier debugging (#1448)
* New app boilerplate * Copy tests from v1 addon to broccoli and embroider3-webpack * unify eslint * ope
1 parent 461ac43 commit 7b5f620

84 files changed

Lines changed: 5936 additions & 53 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.github/workflows/ci.yml

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,16 @@ jobs:
2727
- run: pnpm lint
2828

2929
test:
30-
name: Tests
30+
name: "Ember | ${{ matrix.app.name }}"
3131
runs-on: ubuntu-latest
3232
timeout-minutes: 10
33-
33+
strategy:
34+
fail-fast: false
35+
matrix:
36+
app:
37+
- { name: "Broccoli (v1 Addon)", dir: ".", cmd: "pnpm test:ember" }
38+
- { name: "Broccoli (v1 App)", dir: './test-apps/broccoli', cmd: 'pnpm test:ember' }
39+
- { name: "Webpack + Embroider 3 ", dir: './test-apps/embroider3-webpack', cmd: 'pnpm test:ember' }
3440
steps:
3541
- uses: actions/checkout@v4
3642
- uses: pnpm/action-setup@v4
@@ -40,6 +46,8 @@ jobs:
4046
cache: 'pnpm'
4147
- run: pnpm install
4248
- run: pnpm test:ember
49+
- run: ${{ matrix.app.cmd }}
50+
working-directory: ${{ matrix.app.dir }}
4351

4452
test-node:
4553
name: Node Tests
@@ -81,8 +89,6 @@ jobs:
8189
fail-fast: false
8290
matrix:
8391
ember-try-scenario:
84-
- embroider-safe
85-
- embroider-optimized
8692
- ember-lts-4.8
8793
- ember-lts-4.12
8894
- ember-release

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
"format": "prettier . --write",
2323
"lint": "concurrently \"npm:lint:*(!fix)\" --names \"lint:\"",
2424
"lint:format": "prettier . --cache --check",
25-
"lint:js": "eslint .",
25+
"lint:js": "eslint . && pnpm --filter './test-apps/**' lint:js",
2626
"start": "ember serve",
2727
"test": "concurrently \"npm:test:*\"",
2828
"test:ember": "ember test",

0 commit comments

Comments
 (0)