make sure to ignore node_modules for custom blueprints

Author: Kelly Selden

src/get-start-and-end-commands.js

@@ -1,8 +1,14 @@
 'use strict';
 
 const path = require('path');
+const fs = require('fs-extra');
 const utils = require('./utils');
 
+const nodeModulesIgnore = `
+
+/node_modules/
+`;
+
 module.exports = function getStartAndEndCommands({
   packageJson: { name: projectName },
   projectOptions,
@@ -80,16 +86,18 @@ function createProjectFromRemote(command) {
     options
   }) {
     return async function createProject(cwd) {
-      let npxCommand;
       if (options.blueprint.name !== 'ember-cli') {
-        npxCommand = `ember-cli ${command} -b ${options.blueprint.path}`;
-        // npxCommand = `-p github:ember-cli/ember-cli#cfb9780 ember ${command} -b ${options.blueprint.name}@${options.packageVersion}`;
+        await utils.npx(`ember-cli ${command} -b ${options.blueprint.path}`, { cwd });
+        // await utils.npx(`-p github:ember-cli/ember-cli#cfb9780 ember ${command} -b ${options.blueprint.name}@${options.packageVersion}`, { cwd });
+
+        await module.exports.appendNodeModulesIgnore({
+          cwd,
+          projectName: options.projectName
+        });
       } else {
-        npxCommand = `-p ember-cli@${options.packageVersion} ember ${command}`;
+        await utils.npx(`-p ember-cli@${options.packageVersion} ember ${command}`, { cwd });
       }
 
-      await utils.npx(npxCommand, { cwd });
-
       return postCreateProject({
         cwd,
         options
@@ -106,3 +114,21 @@ function postCreateProject({
 }) {
   return path.join(cwd, projectName);
 }
+
+async function appendNodeModulesIgnore({
+  cwd,
+  projectName
+}) {
+  let isIgnoringNodeModules;
+  let gitignore = '';
+  try {
+    gitignore = await fs.readFile(path.join(cwd, projectName, '.gitignore'), 'utf8');
+
+    isIgnoringNodeModules = /^\/?node_modules\/?$/m.test(gitignore);
+  } catch (err) {}
+  if (!isIgnoringNodeModules) {
+    await fs.writeFile(path.join(cwd, projectName, '.gitignore'), `${gitignore}${nodeModulesIgnore}`);
+  }
+}
+
+module.exports.appendNodeModulesIgnore = appendNodeModulesIgnore;

test/unit/get-start-and-end-commands-test.js

@@ -23,12 +23,14 @@ describe(_getStartAndEndCommands, function() {
   let sandbox;
   let npxStub;
   let spawnStub;
+  let appendNodeModulesIgnoreStub;
 
   beforeEach(function() {
     sandbox = sinon.createSandbox();
 
     npxStub = sandbox.stub(utils, 'npx').resolves();
     spawnStub = sandbox.stub(utils, 'spawn').resolves();
+    appendNodeModulesIgnoreStub = sandbox.stub(_getStartAndEndCommands, 'appendNodeModulesIgnore').resolves();
   });
 
   afterEach(function() {
@@ -171,6 +173,11 @@ describe(_getStartAndEndCommands, function() {
           cwd
         }
       ]]);
+
+      expect(appendNodeModulesIgnoreStub.args).to.deep.equal([[{
+        cwd,
+        projectName
+      }]]);
     });
   });